From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6888331B101 for ; Tue, 14 Apr 2026 18:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776191758; cv=none; b=KVdFnt438ajRpVjM4uJWNP6MKF0mNkncNkp7tINCbTJgL3LFA/HAjaTyvVjm+FibCywJxil50PfPGzKIle+vfbqCNVUqCluj7eGpK7mi8ANRKxJDOxnFnJGwFq1BMq2CHNs3V6AJvccx6ffimqnne5SfOFMZRwkDAviu79zt8qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776191758; c=relaxed/simple; bh=4uKTgMOmHlsR+e8TqtxTDuecI1rtiaGc6D1ySeWNnTA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=YWo7vPpN/Eexm02XMwp0YIMVwzNQ75rOrBnklji4CxNVVTwfEwZHtBa1XF4LTVfnztANlcJklVMeVV3cxUzRBC4TguvOOu+1akPwE7luYif07dkm/+j3HSueBBBKF7eWgLEfUM6nY9bWCO01hMSd5K9DmoJ8ZvpqbdUenP8f57c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SVw+15Yv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oh1Iz99e; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SVw+15Yv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oh1Iz99e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776191756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uC1Vo5Pd77iZu5wFk9wyXLnn928QWwCwFFKMvCu6V14=; b=SVw+15YvGoE4UxPvTicfma421Jawv1HejIvF5pLgSw3dbW9kB+AtaP7gLoFByNwViQQp+7 OErbpU1lsQiRMba1R3jVEsI9/chyGj6ktiQK5wxPiLeCjeFCwszULActpcVn1U9wxmMvS3 W9lYAQJxOO01qWMOCr2rlQ06fbq2LCA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-__OSmAQ4O4SOwkuxt2GmKw-1; Tue, 14 Apr 2026 14:35:55 -0400 X-MC-Unique: __OSmAQ4O4SOwkuxt2GmKw-1 X-Mimecast-MFC-AGG-ID: __OSmAQ4O4SOwkuxt2GmKw_1776191755 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8d3bb33c8b8so1256286385a.0 for ; Tue, 14 Apr 2026 11:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776191755; x=1776796555; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=uC1Vo5Pd77iZu5wFk9wyXLnn928QWwCwFFKMvCu6V14=; b=Oh1Iz99ecuIvSzsniANwoIJd7SV2b80IGgpkBg+UW0vcJ8jqpflLCc2Xbex/MKVn0T BF/iGEvDtwpscOiVR7qu1RNayWGDH2tUS8AJBqeE0t12fZ6JyWUuE4RWYZarNSNh0rZ5 lay72Ka+2UEjplaN/cUdG/UpkDI7WkSTT0t3MCZsMUeTS1jpsVFCmp6QUnSQIJvmzmd+ Zv62OmuUdJqZTDQ0N2nfuHDisgk3m1FdOXw9GRiJBhI5Z6LwYwn83CsUDrGTvRQ/M58V zQR3TaitFNIb18bzwL6NrViXB0ddJp87qidw60QbKKwErDCIZ0EcwkjaOsW/9cKcxRlD 8IKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776191755; x=1776796555; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uC1Vo5Pd77iZu5wFk9wyXLnn928QWwCwFFKMvCu6V14=; b=HncMJSTu75PE6meWjZoYj3T2QH/KeUCCn2TYMlg3MqLogCNdsF+BX/iSBl+c4AO29W WJga/saSskXvghXy2QGv1fdtxeKgw4rQeQQ2YO4hVKhOD+ll3Zxk02PldQt/zciz/p7t qe808BEu4hOrlwrvPM6EtLerVg4N8IaoA9Q4gjiTif4SBxhReYgzdo3LUfm1Am11ut7O JJcAf1ShsdRwaLGW7zfuwV0JvJs/psATjrd2WufFW7leoLyj7mdPu28WocZX7XvqUhyj WUSHX+YXEtrurcI8EAbiWjcUJPHmsqwopVomsujRdHaiWF1rDPxzuf70oTaEFTMkevMw sy+Q== X-Forwarded-Encrypted: i=1; AFNElJ/t5kn1VCSJjSClRNTuhRhc4n386U2GHFZdSms8r0MJ2rP6GSia2C/qNcYk5uGMaITo3VYOul5PFZcFNuM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8fqzdAl2UCscfi3RspX7aVPnxOwtysC9B75Jm7463EHGx284Q u4J3waXji4ttl93DKamIp954bLAkIJlzJ1tr1bXJOAZxL6YhpIq/kYEhu8PSUTYDE3YSuj2HpBF JSPKoRDgZ5XOot5HoIikprfuRMWs1Ri/8OSxGsPgNtQutQ2ezLmQXmaD1UwqaonEhMA== X-Gm-Gg: AeBDieudplwpUOVYK/hLWA6MDS2EzZlx7didECTLqeJYxztaWIp+SzPJ9xY5pb4DqT0 Q5mJdUDps75JLwX+KvF9hz0Tkcl/Sx8vVUckwM75QTtBPPUJbh/K5uqOKJEv5JJfAF4He9P1TNO y7GysYRYbr5eD7yB0oW8R+A+O8kRA1ZiavD1PCvEqeo56b+H37t/r7vffs/8Sxfzme9Qukozxru sGwp9atpsPmLilYvy9CF/aKirESFZ6WutlH3DeZdt11TTN3SDfWLsCp6Pxxz7b+2iE+mGE7TmI2 am1IU9xtaLa+QzW2yxAfTvUEo7W1HrOURDF21Uy6iIMCYRWGL2QVbSD8BOqM6oeJD31qIKoEhYP tlttKJRUiVzU34Dr22W+TgvHM7S6/z0vK9QC6j+I2gsAf+TJFDQ56/Q== X-Received: by 2002:a05:620a:7113:b0:8cf:d565:fca4 with SMTP id af79cd13be357-8ddccb3040fmr2700052785a.3.1776191754605; Tue, 14 Apr 2026 11:35:54 -0700 (PDT) X-Received: by 2002:a05:620a:7113:b0:8cf:d565:fca4 with SMTP id af79cd13be357-8ddccb3040fmr2700046185a.3.1776191754027; Tue, 14 Apr 2026 11:35:54 -0700 (PDT) Received: from crwood-thinkpadp16vgen1.minnmso.csb ([2601:447:cc81:56d0:ab94:b2cb:29a6:7ac0]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8ddb646d715sm1120511885a.15.2026.04.14.11.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 11:35:53 -0700 (PDT) Message-ID: <1bc700d91efea3936bfebe77c058f3c402c16aa4.camel@redhat.com> Subject: Re: [PATCH v2] tracing/osnoise: Add option to align tlat threads From: Crystal Wood To: Steven Rostedt , Tomas Glozar Cc: Masami Hiramatsu , Mathieu Desnoyers , John Kacur , Luis Goncalves , Costa Shulyupin , Wander Lairson Costa , LKML , linux-trace-kernel Date: Tue, 14 Apr 2026 13:35:52 -0500 In-Reply-To: <20260414080339.26193a6b@robin> References: <20260302131316.385987-1-tglozar@redhat.com> <20260414080339.26193a6b@robin> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-04-14 at 08:03 -0400, Steven Rostedt wrote: > I noticed that I never ran this through my tests, and I just did now, > and it failed with: >=20 > /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c: I= n function =E2=80=98osnoise_workload_start=E2=80=99: > /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c:29= 29:23: error: =E2=80=98align_next=E2=80=99 undeclared (first use in this fu= nction); did you mean =E2=80=98klist_next=E2=80=99? > 2929 | atomic64_set(&align_next, 0); > | ^~~~~~~~~~ > | klist_next > /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c:29= 29:23: note: each undeclared identifier is reported only once for each func= tion it appears in > CC [M] drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.o > make[5]: *** [/work/build/trace/nobackup/linux-test.git/scripts/Makefile.= build:289: kernel/trace/trace_osnoise.o] Error 1 > make[5]: *** Waiting for unfinished jobs.... Looks like this should be moved into tlat_var_reset(). -Crystal