* [PATCH 6.12 053/122] kheaders: Ignore silly-rename files
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
@ 2025-01-21 17:51 ` Greg Kroah-Hartman
2025-01-21 19:10 ` [PATCH 6.12 000/122] 6.12.11-rc1 review Florian Fainelli
` (7 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2025-01-21 17:51 UTC (permalink / raw)
To: stable
Cc: Greg Kroah-Hartman, patches, David Howells, Masahiro Yamada,
Marc Dionne, linux-afs, linux-nfs, linux-kernel,
Christian Brauner, Sasha Levin
6.12-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <dhowells@redhat.com>
[ Upstream commit 973b710b8821c3401ad7a25360c89e94b26884ac ]
Tell tar to ignore silly-rename files (".__afs*" and ".nfs*") when building
the header archive. These occur when a file that is open is unlinked
locally, but hasn't yet been closed. Such files are visible to the user
via the getdents() syscall and so programs may want to do things with them.
During the kernel build, such files may be made during the processing of
header files and the cleanup may get deferred by fput() which may result in
tar seeing these files when it reads the directory, but they may have
disappeared by the time it tries to open them, causing tar to fail with an
error. Further, we don't want to include them in the tarball if they still
exist.
With CONFIG_HEADERS_INSTALL=y, something like the following may be seen:
find: './kernel/.tmp_cpio_dir/include/dt-bindings/reset/.__afs2080': No such file or directory
tar: ./include/linux/greybus/.__afs3C95: File removed before we read it
The find warning doesn't seem to cause a problem.
Fix this by telling tar when called from in gen_kheaders.sh to exclude such
files. This only affects afs and nfs; cifs uses the Windows Hidden
attribute to prevent the file from being seen.
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20241213135013.2964079-2-dhowells@redhat.com
cc: Masahiro Yamada <masahiroy@kernel.org>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: linux-nfs@vger.kernel.org
cc: linux-kernel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
index 383fd43ac6122..7e1340da5acae 100755
--- a/kernel/gen_kheaders.sh
+++ b/kernel/gen_kheaders.sh
@@ -89,6 +89,7 @@ find $cpio_dir -type f -print0 |
# Create archive and try to normalize metadata for reproducibility.
tar "${KBUILD_BUILD_TIMESTAMP:+--mtime=$KBUILD_BUILD_TIMESTAMP}" \
+ --exclude=".__afs*" --exclude=".nfs*" \
--owner=0 --group=0 --sort=name --numeric-owner --mode=u=rw,go=r,a+X \
-I $XZ -cf $tarfile -C $cpio_dir/ . > /dev/null
--
2.39.5
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
2025-01-21 17:51 ` [PATCH 6.12 053/122] kheaders: Ignore silly-rename files Greg Kroah-Hartman
@ 2025-01-21 19:10 ` Florian Fainelli
2025-01-21 20:57 ` Peter Schneider
` (6 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Florian Fainelli @ 2025-01-21 19:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie
On 1/21/25 09:50, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
2025-01-21 17:51 ` [PATCH 6.12 053/122] kheaders: Ignore silly-rename files Greg Kroah-Hartman
2025-01-21 19:10 ` [PATCH 6.12 000/122] 6.12.11-rc1 review Florian Fainelli
@ 2025-01-21 20:57 ` Peter Schneider
2025-01-21 21:46 ` Salvatore Bonaccorso
` (5 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Peter Schneider @ 2025-01-21 20:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
Am 21.01.2025 um 18:50 schrieb Greg Kroah-Hartman:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg
oddities or regressions found.
Tested-by: Peter Schneider <pschneider1968@googlemail.com>
Beste Grüße,
Peter Schneider
--
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you. -- David McCullough Jr.
OpenPGP: 0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@googlemail.com
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@gmail.com
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2025-01-21 20:57 ` Peter Schneider
@ 2025-01-21 21:46 ` Salvatore Bonaccorso
2025-01-21 22:15 ` Ronald Warsow
2025-01-22 7:04 ` Jon Hunter
2025-01-21 23:05 ` Takeshi Ogasawara
` (4 subsequent siblings)
8 siblings, 2 replies; 25+ messages in thread
From: Salvatore Bonaccorso @ 2025-01-21 21:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
Hi Greg,
On Tue, Jan 21, 2025 at 06:50:48PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
Built and lightly tested, when booting I'm noticing the following in
dmesg:
[ +0.007932] ------------[ cut here ]------------
[ +0.000003] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:5250 place_entity+0x127/0x130
[ +0.000006] Modules linked in: ahci(E) libahci(E) crc32_pclmul(E) xhci_hcd(E) libata(E) psmouse(E) crc32c_intel(E) >
[ +0.000021] CPU: 1 UID: 0 PID: 0 Comm: swapper/1 Tainted: G E 6.12.11-rc1+ #1
[ +0.000004] Tainted: [E]=UNSIGNED_MODULE
[ +0.000002] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ +0.000002] RIP: 0010:place_entity+0x127/0x130
[ +0.000003] Code: 01 6b 28 c6 43 52 00 5b 5d 41 5c 41 5d 41 5e e9 2f 83 bc 00 b9 02 00 00 00 49 c1 ee 0a 49 39 ce 4>
[ +0.000002] RSP: 0018:ffffbe1f400f8d08 EFLAGS: 00010046
[ +0.000003] RAX: 0000000000000000 RBX: ffff9ed7c0c0f200 RCX: 00000000000000c2
[ +0.000002] RDX: 0000000000000000 RSI: 000000000000001d RDI: 000000000078cfd5
[ +0.000002] RBP: 0000000029d40d60 R08: 00000000a8e83f00 R09: 0000000000000002
[ +0.000002] R10: 00000000006e3ab2 R11: ffff9ed7d4056690 R12: ffff9ed83bd360c0
[ +0.000002] R13: 0000000000000000 R14: 00000000000000c2 R15: 000000000016e360
[ +0.000003] FS: 0000000000000000(0000) GS:ffff9ed83bd00000(0000) knlGS:0000000000000000
[ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ +0.000002] CR2: 00007f9f5a7245d8 CR3: 0000000100bfc000 CR4: 0000000000350ef0
[ +0.000003] Call Trace:
[ +0.000003] <IRQ>
[ +0.000002] ? place_entity+0x127/0x130
[ +0.000002] ? __warn.cold+0x93/0xf6
[ +0.000004] ? place_entity+0x127/0x130
[ +0.000003] ? report_bug+0xff/0x140
[ +0.000005] ? handle_bug+0x58/0x90
[ +0.000002] ? exc_invalid_op+0x17/0x70
[ +0.000003] ? asm_exc_invalid_op+0x1a/0x20
[ +0.000006] ? place_entity+0x127/0x130
[ +0.000003] ? place_entity+0x99/0x130
[ +0.000004] reweight_entity+0x1af/0x1d0
[ +0.000003] enqueue_task_fair+0x30c/0x5e0
[ +0.000005] enqueue_task+0x35/0x150
[ +0.000004] activate_task+0x3a/0x60
[ +0.000003] sched_balance_rq+0x7c6/0xee0
[ +0.000008] sched_balance_domains+0x25b/0x350
[ +0.000005] handle_softirqs+0xcf/0x280
[ +0.000006] __irq_exit_rcu+0x8d/0xb0
[ +0.000003] sysvec_apic_timer_interrupt+0x71/0x90
[ +0.000003] </IRQ>
[ +0.000002] <TASK>
[ +0.000002] asm_sysvec_apic_timer_interrupt+0x1a/0x20
[ +0.000002] RIP: 0010:pv_native_safe_halt+0xf/0x20
[ +0.000004] Code: 22 d7 e9 b4 01 01 00 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa eb 0>
[ +0.000002] RSP: 0018:ffffbe1f400bbed8 EFLAGS: 00000202
[ +0.000003] RAX: 0000000000000001 RBX: ffff9ed7c033e600 RCX: ffff9ed7c0647830
[ +0.000001] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 00000000000017b4
[ +0.000002] RBP: 0000000000000001 R08: 0000000000000001 R09: 0000000000000000
[ +0.000002] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
[ +0.000001] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[ +0.000006] default_idle+0x9/0x20
[ +0.000003] default_idle_call+0x29/0x100
[ +0.000002] do_idle+0x1fe/0x240
[ +0.000005] cpu_startup_entry+0x29/0x30
[ +0.000003] start_secondary+0x11e/0x140
[ +0.000004] common_startup_64+0x13e/0x141
[ +0.000007] </TASK>
[ +0.000001] ---[ end trace 0000000000000000 ]---
Not yet bisected which change causes it.
Regards,
Salvatore
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 21:46 ` Salvatore Bonaccorso
@ 2025-01-21 22:15 ` Ronald Warsow
2025-01-22 7:04 ` Jon Hunter
1 sibling, 0 replies; 25+ messages in thread
From: Ronald Warsow @ 2025-01-21 22:15 UTC (permalink / raw)
To: Salvatore Bonaccorso, Greg Kroah-Hartman; +Cc: stable, linux-kernel
On 21.01.25 22:46, Salvatore Bonaccorso wrote:
> Hi Greg,
>
...
>
> Built and lightly tested, when booting I'm noticing the following in
> dmesg:
>
> [ +0.007932] ------------[ cut here ]------------
> [ +0.000003] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:5250 place_entity+0x127/0x130
same here [no time to bisect]
Ronald
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 21:46 ` Salvatore Bonaccorso
2025-01-21 22:15 ` Ronald Warsow
@ 2025-01-22 7:04 ` Jon Hunter
2025-01-22 9:01 ` Ron Economos
1 sibling, 1 reply; 25+ messages in thread
From: Jon Hunter @ 2025-01-22 7:04 UTC (permalink / raw)
To: Salvatore Bonaccorso, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, linux-tegra@vger.kernel.org
Hi Greg,
On 21/01/2025 21:46, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Tue, Jan 21, 2025 at 06:50:48PM +0100, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.12.11 release.
>> There are 122 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
>> and the diffstat can be found below.
>
> Built and lightly tested, when booting I'm noticing the following in
> dmesg:
>
> [ +0.007932] ------------[ cut here ]------------
> [ +0.000003] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:5250 place_entity+0x127/0x130
> [ +0.000006] Modules linked in: ahci(E) libahci(E) crc32_pclmul(E) xhci_hcd(E) libata(E) psmouse(E) crc32c_intel(E) >
> [ +0.000021] CPU: 1 UID: 0 PID: 0 Comm: swapper/1 Tainted: G E 6.12.11-rc1+ #1
> [ +0.000004] Tainted: [E]=UNSIGNED_MODULE
> [ +0.000002] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
> [ +0.000002] RIP: 0010:place_entity+0x127/0x130
> [ +0.000003] Code: 01 6b 28 c6 43 52 00 5b 5d 41 5c 41 5d 41 5e e9 2f 83 bc 00 b9 02 00 00 00 49 c1 ee 0a 49 39 ce 4>
> [ +0.000002] RSP: 0018:ffffbe1f400f8d08 EFLAGS: 00010046
> [ +0.000003] RAX: 0000000000000000 RBX: ffff9ed7c0c0f200 RCX: 00000000000000c2
> [ +0.000002] RDX: 0000000000000000 RSI: 000000000000001d RDI: 000000000078cfd5
> [ +0.000002] RBP: 0000000029d40d60 R08: 00000000a8e83f00 R09: 0000000000000002
> [ +0.000002] R10: 00000000006e3ab2 R11: ffff9ed7d4056690 R12: ffff9ed83bd360c0
> [ +0.000002] R13: 0000000000000000 R14: 00000000000000c2 R15: 000000000016e360
> [ +0.000003] FS: 0000000000000000(0000) GS:ffff9ed83bd00000(0000) knlGS:0000000000000000
> [ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ +0.000002] CR2: 00007f9f5a7245d8 CR3: 0000000100bfc000 CR4: 0000000000350ef0
> [ +0.000003] Call Trace:
> [ +0.000003] <IRQ>
> [ +0.000002] ? place_entity+0x127/0x130
> [ +0.000002] ? __warn.cold+0x93/0xf6
> [ +0.000004] ? place_entity+0x127/0x130
> [ +0.000003] ? report_bug+0xff/0x140
> [ +0.000005] ? handle_bug+0x58/0x90
> [ +0.000002] ? exc_invalid_op+0x17/0x70
> [ +0.000003] ? asm_exc_invalid_op+0x1a/0x20
> [ +0.000006] ? place_entity+0x127/0x130
> [ +0.000003] ? place_entity+0x99/0x130
> [ +0.000004] reweight_entity+0x1af/0x1d0
> [ +0.000003] enqueue_task_fair+0x30c/0x5e0
> [ +0.000005] enqueue_task+0x35/0x150
> [ +0.000004] activate_task+0x3a/0x60
> [ +0.000003] sched_balance_rq+0x7c6/0xee0
> [ +0.000008] sched_balance_domains+0x25b/0x350
> [ +0.000005] handle_softirqs+0xcf/0x280
> [ +0.000006] __irq_exit_rcu+0x8d/0xb0
> [ +0.000003] sysvec_apic_timer_interrupt+0x71/0x90
> [ +0.000003] </IRQ>
> [ +0.000002] <TASK>
> [ +0.000002] asm_sysvec_apic_timer_interrupt+0x1a/0x20
> [ +0.000002] RIP: 0010:pv_native_safe_halt+0xf/0x20
> [ +0.000004] Code: 22 d7 e9 b4 01 01 00 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa eb 0>
> [ +0.000002] RSP: 0018:ffffbe1f400bbed8 EFLAGS: 00000202
> [ +0.000003] RAX: 0000000000000001 RBX: ffff9ed7c033e600 RCX: ffff9ed7c0647830
> [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 00000000000017b4
> [ +0.000002] RBP: 0000000000000001 R08: 0000000000000001 R09: 0000000000000000
> [ +0.000002] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
> [ +0.000001] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> [ +0.000006] default_idle+0x9/0x20
> [ +0.000003] default_idle_call+0x29/0x100
> [ +0.000002] do_idle+0x1fe/0x240
> [ +0.000005] cpu_startup_entry+0x29/0x30
> [ +0.000003] start_secondary+0x11e/0x140
> [ +0.000004] common_startup_64+0x13e/0x141
> [ +0.000007] </TASK>
> [ +0.000001] ---[ end trace 0000000000000000 ]---
>
> Not yet bisected which change causes it.
I am seeing the same on Tegra. I have not looked to see which change
this is yet either.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 7:04 ` Jon Hunter
@ 2025-01-22 9:01 ` Ron Economos
2025-01-22 9:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 25+ messages in thread
From: Ron Economos @ 2025-01-22 9:01 UTC (permalink / raw)
To: Jon Hunter, Salvatore Bonaccorso, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, linux-tegra@vger.kernel.org
On 1/21/25 23:04, Jon Hunter wrote:
> Hi Greg,
>
> On 21/01/2025 21:46, Salvatore Bonaccorso wrote:
>> Hi Greg,
>>
>> On Tue, Jan 21, 2025 at 06:50:48PM +0100, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.12.11 release.
>>> There are 122 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
>>>
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>> linux-6.12.y
>>> and the diffstat can be found below.
>>
>> Built and lightly tested, when booting I'm noticing the following in
>> dmesg:
>>
>> [ +0.007932] ------------[ cut here ]------------
>> [ +0.000003] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:5250
>> place_entity+0x127/0x130
>> [ +0.000006] Modules linked in: ahci(E) libahci(E) crc32_pclmul(E)
>> xhci_hcd(E) libata(E) psmouse(E) crc32c_intel(E) >
>> [ +0.000021] CPU: 1 UID: 0 PID: 0 Comm: swapper/1 Tainted:
>> G E 6.12.11-rc1+ #1
>> [ +0.000004] Tainted: [E]=UNSIGNED_MODULE
>> [ +0.000002] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009),
>> BIOS 1.16.2-debian-1.16.2-1 04/01/2014
>> [ +0.000002] RIP: 0010:place_entity+0x127/0x130
>> [ +0.000003] Code: 01 6b 28 c6 43 52 00 5b 5d 41 5c 41 5d 41 5e e9
>> 2f 83 bc 00 b9 02 00 00 00 49 c1 ee 0a 49 39 ce 4>
>> [ +0.000002] RSP: 0018:ffffbe1f400f8d08 EFLAGS: 00010046
>> [ +0.000003] RAX: 0000000000000000 RBX: ffff9ed7c0c0f200 RCX:
>> 00000000000000c2
>> [ +0.000002] RDX: 0000000000000000 RSI: 000000000000001d RDI:
>> 000000000078cfd5
>> [ +0.000002] RBP: 0000000029d40d60 R08: 00000000a8e83f00 R09:
>> 0000000000000002
>> [ +0.000002] R10: 00000000006e3ab2 R11: ffff9ed7d4056690 R12:
>> ffff9ed83bd360c0
>> [ +0.000002] R13: 0000000000000000 R14: 00000000000000c2 R15:
>> 000000000016e360
>> [ +0.000003] FS: 0000000000000000(0000) GS:ffff9ed83bd00000(0000)
>> knlGS:0000000000000000
>> [ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [ +0.000002] CR2: 00007f9f5a7245d8 CR3: 0000000100bfc000 CR4:
>> 0000000000350ef0
>> [ +0.000003] Call Trace:
>> [ +0.000003] <IRQ>
>> [ +0.000002] ? place_entity+0x127/0x130
>> [ +0.000002] ? __warn.cold+0x93/0xf6
>> [ +0.000004] ? place_entity+0x127/0x130
>> [ +0.000003] ? report_bug+0xff/0x140
>> [ +0.000005] ? handle_bug+0x58/0x90
>> [ +0.000002] ? exc_invalid_op+0x17/0x70
>> [ +0.000003] ? asm_exc_invalid_op+0x1a/0x20
>> [ +0.000006] ? place_entity+0x127/0x130
>> [ +0.000003] ? place_entity+0x99/0x130
>> [ +0.000004] reweight_entity+0x1af/0x1d0
>> [ +0.000003] enqueue_task_fair+0x30c/0x5e0
>> [ +0.000005] enqueue_task+0x35/0x150
>> [ +0.000004] activate_task+0x3a/0x60
>> [ +0.000003] sched_balance_rq+0x7c6/0xee0
>> [ +0.000008] sched_balance_domains+0x25b/0x350
>> [ +0.000005] handle_softirqs+0xcf/0x280
>> [ +0.000006] __irq_exit_rcu+0x8d/0xb0
>> [ +0.000003] sysvec_apic_timer_interrupt+0x71/0x90
>> [ +0.000003] </IRQ>
>> [ +0.000002] <TASK>
>> [ +0.000002] asm_sysvec_apic_timer_interrupt+0x1a/0x20
>> [ +0.000002] RIP: 0010:pv_native_safe_halt+0xf/0x20
>> [ +0.000004] Code: 22 d7 e9 b4 01 01 00 0f 1f 40 00 90 90 90 90 90
>> 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa eb 0>
>> [ +0.000002] RSP: 0018:ffffbe1f400bbed8 EFLAGS: 00000202
>> [ +0.000003] RAX: 0000000000000001 RBX: ffff9ed7c033e600 RCX:
>> ffff9ed7c0647830
>> [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
>> 00000000000017b4
>> [ +0.000002] RBP: 0000000000000001 R08: 0000000000000001 R09:
>> 0000000000000000
>> [ +0.000002] R10: 0000000000000001 R11: 0000000000000000 R12:
>> 0000000000000000
>> [ +0.000001] R13: 0000000000000000 R14: 0000000000000000 R15:
>> 0000000000000000
>> [ +0.000006] default_idle+0x9/0x20
>> [ +0.000003] default_idle_call+0x29/0x100
>> [ +0.000002] do_idle+0x1fe/0x240
>> [ +0.000005] cpu_startup_entry+0x29/0x30
>> [ +0.000003] start_secondary+0x11e/0x140
>> [ +0.000004] common_startup_64+0x13e/0x141
>> [ +0.000007] </TASK>
>> [ +0.000001] ---[ end trace 0000000000000000 ]---
>>
>> Not yet bisected which change causes it.
>
>
> I am seeing the same on Tegra. I have not looked to see which change
> this is yet either.
>
> Jon
>
Seeing this on RISC-V also.
Jan 21 23:51:10 riscv64 kernel: WARNING: CPU: 3 PID: 16 at
kernel/sched/fair.c:5250 place_entity+0x108/0x110
Jan 21 23:51:10 riscv64 kernel: Modules linked in:
Jan 21 23:51:10 riscv64 kernel: CPU: 3 UID: 0 PID: 16 Comm: rcu_preempt
Not tainted 6.12.11-rc1 #2
Jan 21 23:51:10 riscv64 kernel: Hardware name: SiFive HiFive Unmatched
A00 (DT)
Jan 21 23:51:10 riscv64 kernel: epc : place_entity+0x108/0x110
Jan 21 23:51:10 riscv64 kernel: ra : place_entity+0x9c/0x110
Jan 21 23:51:10 riscv64 kernel: epc : ffffffff8006ed68 ra :
ffffffff8006ecfc sp : ffffffc60009bac0
Jan 21 23:51:10 riscv64 kernel: gp : ffffffff81fa6318 tp :
ffffffd680323b00 t0 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: t1 : 0000000000000000 t2 :
0000000000000000 s0 : ffffffc60009bb00
Jan 21 23:51:10 riscv64 kernel: s1 : ffffffd6809f5000 a0 :
000000000053b491 a1 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: a2 : 0000000000000002 a3 :
0000000000000000 a4 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: a5 : 0000000000000000 a6 :
0000000000000000 a7 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: s2 : 0000000031acb37b s3 :
0000000000000000 s4 : 000000000006920d
Jan 21 23:51:10 riscv64 kernel: s5 : ffffffd9fedb2a00 s6 :
ffffffd9fedb2900 s7 : ffffffd6829cbb00
Jan 21 23:51:10 riscv64 kernel: s8 : 0000000000000000 s9 :
0000000000000001 s10: 0000000000000201
Jan 21 23:51:10 riscv64 kernel: s11: 0000000000000000 t3 :
0000000000000000 t4 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: t5 : 0000000000000000 t6 : 0000000000000000
Jan 21 23:51:10 riscv64 kernel: status: 0000000200000100 badaddr:
0000000000000002 cause: 0000000000000003
Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006ed68>]
place_entity+0x108/0x110
Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006efe2>]
reweight_entity+0x182/0x1b0
Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006f0c8>]
update_cfs_group+0x78/0xa8
Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006fc4c>]
dequeue_entities+0x114/0x3d8
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80070084>]
pick_task_fair+0xb4/0x110
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80077a3c>]
pick_next_task_fair+0x1c/0x2f0
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dc5556>] __schedule+0x176/0xc20
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dc6022>] schedule+0x22/0x148
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dcc072>]
schedule_timeout+0x82/0x178
Jan 21 23:51:10 riscv64 kernel: [<ffffffff800cb996>]
rcu_gp_fqs_loop+0x346/0x4e8
Jan 21 23:51:10 riscv64 kernel: [<ffffffff800cea62>]
rcu_gp_kthread+0x12a/0x150
Jan 21 23:51:10 riscv64 kernel: [<ffffffff8004db58>] kthread+0xc8/0xe8
Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dceefe>] ret_from_fork+0xe/0x18
Jan 21 23:51:10 riscv64 kernel: ---[ end trace 0000000000000000 ]---
Reverting commit 11d21f2ae4a254aeef84fcf7b6314f5dd045151f "sched/fair:
Fix EEVDF entity placement bug causing scheduling lag" removes the warning.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 9:01 ` Ron Economos
@ 2025-01-22 9:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 25+ messages in thread
From: Greg Kroah-Hartman @ 2025-01-22 9:29 UTC (permalink / raw)
To: Ron Economos
Cc: Jon Hunter, Salvatore Bonaccorso, stable, patches, linux-kernel,
torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, hargar,
broonie, linux-tegra@vger.kernel.org
On Wed, Jan 22, 2025 at 01:01:42AM -0800, Ron Economos wrote:
> On 1/21/25 23:04, Jon Hunter wrote:
> > Hi Greg,
> >
> > On 21/01/2025 21:46, Salvatore Bonaccorso wrote:
> > > Hi Greg,
> > >
> > > On Tue, Jan 21, 2025 at 06:50:48PM +0100, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.12.11 release.
> > > > There are 122 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> > > >
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > linux-6.12.y
> > > > and the diffstat can be found below.
> > >
> > > Built and lightly tested, when booting I'm noticing the following in
> > > dmesg:
> > >
> > > [ +0.007932] ------------[ cut here ]------------
> > > [ +0.000003] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:5250
> > > place_entity+0x127/0x130
> > > [ +0.000006] Modules linked in: ahci(E) libahci(E) crc32_pclmul(E)
> > > xhci_hcd(E) libata(E) psmouse(E) crc32c_intel(E) >
> > > [ +0.000021] CPU: 1 UID: 0 PID: 0 Comm: swapper/1 Tainted:
> > > G E 6.12.11-rc1+ #1
> > > [ +0.000004] Tainted: [E]=UNSIGNED_MODULE
> > > [ +0.000002] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009),
> > > BIOS 1.16.2-debian-1.16.2-1 04/01/2014
> > > [ +0.000002] RIP: 0010:place_entity+0x127/0x130
> > > [ +0.000003] Code: 01 6b 28 c6 43 52 00 5b 5d 41 5c 41 5d 41 5e e9
> > > 2f 83 bc 00 b9 02 00 00 00 49 c1 ee 0a 49 39 ce 4>
> > > [ +0.000002] RSP: 0018:ffffbe1f400f8d08 EFLAGS: 00010046
> > > [ +0.000003] RAX: 0000000000000000 RBX: ffff9ed7c0c0f200 RCX:
> > > 00000000000000c2
> > > [ +0.000002] RDX: 0000000000000000 RSI: 000000000000001d RDI:
> > > 000000000078cfd5
> > > [ +0.000002] RBP: 0000000029d40d60 R08: 00000000a8e83f00 R09:
> > > 0000000000000002
> > > [ +0.000002] R10: 00000000006e3ab2 R11: ffff9ed7d4056690 R12:
> > > ffff9ed83bd360c0
> > > [ +0.000002] R13: 0000000000000000 R14: 00000000000000c2 R15:
> > > 000000000016e360
> > > [ +0.000003] FS: 0000000000000000(0000) GS:ffff9ed83bd00000(0000)
> > > knlGS:0000000000000000
> > > [ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > [ +0.000002] CR2: 00007f9f5a7245d8 CR3: 0000000100bfc000 CR4:
> > > 0000000000350ef0
> > > [ +0.000003] Call Trace:
> > > [ +0.000003] <IRQ>
> > > [ +0.000002] ? place_entity+0x127/0x130
> > > [ +0.000002] ? __warn.cold+0x93/0xf6
> > > [ +0.000004] ? place_entity+0x127/0x130
> > > [ +0.000003] ? report_bug+0xff/0x140
> > > [ +0.000005] ? handle_bug+0x58/0x90
> > > [ +0.000002] ? exc_invalid_op+0x17/0x70
> > > [ +0.000003] ? asm_exc_invalid_op+0x1a/0x20
> > > [ +0.000006] ? place_entity+0x127/0x130
> > > [ +0.000003] ? place_entity+0x99/0x130
> > > [ +0.000004] reweight_entity+0x1af/0x1d0
> > > [ +0.000003] enqueue_task_fair+0x30c/0x5e0
> > > [ +0.000005] enqueue_task+0x35/0x150
> > > [ +0.000004] activate_task+0x3a/0x60
> > > [ +0.000003] sched_balance_rq+0x7c6/0xee0
> > > [ +0.000008] sched_balance_domains+0x25b/0x350
> > > [ +0.000005] handle_softirqs+0xcf/0x280
> > > [ +0.000006] __irq_exit_rcu+0x8d/0xb0
> > > [ +0.000003] sysvec_apic_timer_interrupt+0x71/0x90
> > > [ +0.000003] </IRQ>
> > > [ +0.000002] <TASK>
> > > [ +0.000002] asm_sysvec_apic_timer_interrupt+0x1a/0x20
> > > [ +0.000002] RIP: 0010:pv_native_safe_halt+0xf/0x20
> > > [ +0.000004] Code: 22 d7 e9 b4 01 01 00 0f 1f 40 00 90 90 90 90 90
> > > 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa eb 0>
> > > [ +0.000002] RSP: 0018:ffffbe1f400bbed8 EFLAGS: 00000202
> > > [ +0.000003] RAX: 0000000000000001 RBX: ffff9ed7c033e600 RCX:
> > > ffff9ed7c0647830
> > > [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
> > > 00000000000017b4
> > > [ +0.000002] RBP: 0000000000000001 R08: 0000000000000001 R09:
> > > 0000000000000000
> > > [ +0.000002] R10: 0000000000000001 R11: 0000000000000000 R12:
> > > 0000000000000000
> > > [ +0.000001] R13: 0000000000000000 R14: 0000000000000000 R15:
> > > 0000000000000000
> > > [ +0.000006] default_idle+0x9/0x20
> > > [ +0.000003] default_idle_call+0x29/0x100
> > > [ +0.000002] do_idle+0x1fe/0x240
> > > [ +0.000005] cpu_startup_entry+0x29/0x30
> > > [ +0.000003] start_secondary+0x11e/0x140
> > > [ +0.000004] common_startup_64+0x13e/0x141
> > > [ +0.000007] </TASK>
> > > [ +0.000001] ---[ end trace 0000000000000000 ]---
> > >
> > > Not yet bisected which change causes it.
> >
> >
> > I am seeing the same on Tegra. I have not looked to see which change
> > this is yet either.
> >
> > Jon
> >
> Seeing this on RISC-V also.
>
> Jan 21 23:51:10 riscv64 kernel: WARNING: CPU: 3 PID: 16 at
> kernel/sched/fair.c:5250 place_entity+0x108/0x110
> Jan 21 23:51:10 riscv64 kernel: Modules linked in:
> Jan 21 23:51:10 riscv64 kernel: CPU: 3 UID: 0 PID: 16 Comm: rcu_preempt Not
> tainted 6.12.11-rc1 #2
> Jan 21 23:51:10 riscv64 kernel: Hardware name: SiFive HiFive Unmatched A00
> (DT)
> Jan 21 23:51:10 riscv64 kernel: epc : place_entity+0x108/0x110
> Jan 21 23:51:10 riscv64 kernel: ra : place_entity+0x9c/0x110
> Jan 21 23:51:10 riscv64 kernel: epc : ffffffff8006ed68 ra : ffffffff8006ecfc
> sp : ffffffc60009bac0
> Jan 21 23:51:10 riscv64 kernel: gp : ffffffff81fa6318 tp : ffffffd680323b00
> t0 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: t1 : 0000000000000000 t2 : 0000000000000000
> s0 : ffffffc60009bb00
> Jan 21 23:51:10 riscv64 kernel: s1 : ffffffd6809f5000 a0 : 000000000053b491
> a1 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: a2 : 0000000000000002 a3 : 0000000000000000
> a4 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: a5 : 0000000000000000 a6 : 0000000000000000
> a7 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: s2 : 0000000031acb37b s3 : 0000000000000000
> s4 : 000000000006920d
> Jan 21 23:51:10 riscv64 kernel: s5 : ffffffd9fedb2a00 s6 : ffffffd9fedb2900
> s7 : ffffffd6829cbb00
> Jan 21 23:51:10 riscv64 kernel: s8 : 0000000000000000 s9 : 0000000000000001
> s10: 0000000000000201
> Jan 21 23:51:10 riscv64 kernel: s11: 0000000000000000 t3 : 0000000000000000
> t4 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: t5 : 0000000000000000 t6 : 0000000000000000
> Jan 21 23:51:10 riscv64 kernel: status: 0000000200000100 badaddr:
> 0000000000000002 cause: 0000000000000003
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006ed68>]
> place_entity+0x108/0x110
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006efe2>]
> reweight_entity+0x182/0x1b0
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006f0c8>]
> update_cfs_group+0x78/0xa8
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff8006fc4c>]
> dequeue_entities+0x114/0x3d8
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80070084>]
> pick_task_fair+0xb4/0x110
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80077a3c>]
> pick_next_task_fair+0x1c/0x2f0
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dc5556>] __schedule+0x176/0xc20
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dc6022>] schedule+0x22/0x148
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dcc072>]
> schedule_timeout+0x82/0x178
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff800cb996>]
> rcu_gp_fqs_loop+0x346/0x4e8
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff800cea62>]
> rcu_gp_kthread+0x12a/0x150
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff8004db58>] kthread+0xc8/0xe8
> Jan 21 23:51:10 riscv64 kernel: [<ffffffff80dceefe>] ret_from_fork+0xe/0x18
> Jan 21 23:51:10 riscv64 kernel: ---[ end trace 0000000000000000 ]---
>
> Reverting commit 11d21f2ae4a254aeef84fcf7b6314f5dd045151f "sched/fair: Fix
> EEVDF entity placement bug causing scheduling lag" removes the warning.
Ah, thanks! I'll go revert that now and push out a -rc2.
greg k-h
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2025-01-21 21:46 ` Salvatore Bonaccorso
@ 2025-01-21 23:05 ` Takeshi Ogasawara
2025-01-21 23:31 ` Shuah Khan
` (3 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Takeshi Ogasawara @ 2025-01-21 23:05 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
Hi Greg
On Wed, Jan 22, 2025 at 2:59 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
6.12.11-rc1 tested.
Build successfully completed.
Boot successfully completed.
No dmesg regressions.
Video output normal.
Sound output normal.
Lenovo ThinkPad X1 Carbon Gen10(Intel i7-1260P(x86_64) arch linux)
[ 0.000000] Linux version 6.12.11-rc1rv
(takeshi@ThinkPadX1Gen10J0764) (gcc (GCC) 14.2.1 20240910, GNU ld (GNU
Binutils) 2.43.1) #1 SMP PREEMPT_DYNAMIC Wed Jan 22 07:38:39 JST 2025
Thanks
Tested-by: Takeshi Ogasawara <takeshi.ogasawara@futuring-girl.com>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2025-01-21 23:05 ` Takeshi Ogasawara
@ 2025-01-21 23:31 ` Shuah Khan
2025-01-21 23:48 ` SeongJae Park
` (2 subsequent siblings)
8 siblings, 0 replies; 25+ messages in thread
From: Shuah Khan @ 2025-01-21 23:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, Shuah Khan
On 1/21/25 10:50, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (5 preceding siblings ...)
2025-01-21 23:31 ` Shuah Khan
@ 2025-01-21 23:48 ` SeongJae Park
2025-01-22 10:04 ` Naresh Kamboju
2025-01-23 8:09 ` Harshit Mogalapalli
8 siblings, 0 replies; 25+ messages in thread
From: SeongJae Park @ 2025-01-21 23:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: SeongJae Park, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie, damon
Hello,
On Tue, 21 Jan 2025 18:50:48 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
This rc kernel passes DAMON functionality test[1] on my test machine.
Attaching the test results summary below. Please note that I retrieved the
kernel from linux-stable-rc tree[2].
Tested-by: SeongJae Park <sj@kernel.org>
[1] https://github.com/damonitor/damon-tests/tree/next/corr
[2] f6b51ed03daa ("Linux 6.12.11-rc1")
Thanks,
SJ
[...]
---
ok 9 selftests: damon: damos_tried_regions.py
ok 10 selftests: damon: damon_nr_regions.py
ok 11 selftests: damon: reclaim.sh
ok 12 selftests: damon: lru_sort.sh
ok 13 selftests: damon: debugfs_empty_targets.sh
ok 14 selftests: damon: debugfs_huge_count_read_write.sh
ok 15 selftests: damon: debugfs_duplicate_context_creation.sh
ok 16 selftests: damon: debugfs_rm_non_contexts.sh
ok 17 selftests: damon: debugfs_target_ids_read_before_terminate_race.sh
ok 18 selftests: damon: debugfs_target_ids_pid_leak.sh
ok 19 selftests: damon: sysfs_update_removed_scheme_dir.sh
ok 20 selftests: damon: sysfs_update_schemes_tried_regions_hang.py
ok 1 selftests: damon-tests: kunit.sh
ok 2 selftests: damon-tests: huge_count_read_write.sh
ok 3 selftests: damon-tests: buffer_overflow.sh
ok 4 selftests: damon-tests: rm_contexts.sh
ok 5 selftests: damon-tests: record_null_deref.sh
ok 6 selftests: damon-tests: dbgfs_target_ids_read_before_terminate_race.sh
ok 7 selftests: damon-tests: dbgfs_target_ids_pid_leak.sh
ok 8 selftests: damon-tests: damo_tests.sh
ok 9 selftests: damon-tests: masim-record.sh
ok 10 selftests: damon-tests: build_i386.sh
ok 11 selftests: damon-tests: build_arm64.sh # SKIP
ok 12 selftests: damon-tests: build_m68k.sh # SKIP
ok 13 selftests: damon-tests: build_i386_idle_flag.sh
ok 14 selftests: damon-tests: build_i386_highpte.sh
ok 15 selftests: damon-tests: build_nomemcg.sh
[33m
[92mPASS [39m
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (6 preceding siblings ...)
2025-01-21 23:48 ` SeongJae Park
@ 2025-01-22 10:04 ` Naresh Kamboju
2025-01-22 10:42 ` Peter Zijlstra
2025-01-22 10:56 ` Arnd Bergmann
2025-01-23 8:09 ` Harshit Mogalapalli
8 siblings, 2 replies; 25+ messages in thread
From: Naresh Kamboju @ 2025-01-22 10:04 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
Peter Zijlstra, Anders Roxell, Vincent Guittot, Dan Carpenter,
Arnd Bergmann
On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro’s test farm.
Regressions on arm64, arm, x86_64, and i386.
The following build warn
WARNING: CPU: 1 PID: 22 at kernel/sched/fair.c:5250 place_entity
(kernel/sched/fair.c:5250 (discriminator 1))
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Boot regression: exception-warning-cpu-pid-at-kernelschedfair-place_entity
Boot log warnings
----------
<4>[ 160.693155] ------------[ cut here ]------------
<4>[ 160.694179] WARNING: CPU: 1 PID: 22 at kernel/sched/fair.c:5250
place_entity (kernel/sched/fair.c:5250 (discriminator 1))
<4>[ 160.695257] Modules linked in: ip_tables x_tables ipv6
<4>[ 160.696471] CPU: 1 UID: 0 PID: 22 Comm: migration/1 Tainted: G
D N 6.12.11-rc1 #1
<4>[ 160.697345] Tainted: [D]=DIE, [N]=TEST
<4>[ 160.697903] Hardware name: linux,dummy-virt (DT)
<4>[ 160.698415] Stopper: migration_cpu_stop+0x0/0x8c8 <- sched_exec
(kernel/sched/core.c:5445)
<4>[ 160.699330] pstate: 234020c9 (nzCv daIF +PAN -UAO +TCO +DIT
-SSBS BTYPE=--)
<4>[ 160.700189] pc : place_entity (kernel/sched/fair.c:5250 (discriminator 1))
<4>[ 160.700827] lr : place_entity (kernel/sched/fair.c:292
kernel/sched/fair.c:289 kernel/sched/fair.c:5177)
<4>[ 160.701267] sp : ffff8000801e79e0
<4>[ 160.701601] x29: ffff8000801e79e0 x28: fff00000cad1d852 x27:
fff00000cad1d8c8
<4>[ 160.702716] x26: 0000000000000000 x25: 1ffe0000195a3b00 x24:
0000000000000000
<4>[ 160.703741] x23: 0000000000000000 x22: 0000000000231608 x21:
0000000972092cd2
<4>[ 160.704817] x20: 0000000000000000 x19: fff00000cad1d800 x18:
1ffff000100f2ec5
<4>[ 160.705954] x17: 0000000000000000 x16: fff00000c03a4d3c x15:
0000000000000000
<4>[ 160.706967] x14: 1ffe00001b532adb x13: 1ffe000019c18922 x12:
fffd80001982cc21
<4>[ 160.708052] x11: 1ffe00001982cc20 x10: fffd80001982cc20 x9 :
dfff800000000000
<4>[ 160.709043] x8 : fff00000cc166107 x7 : fff00000cad1d810 x6 :
fffd80001982cc20
<4>[ 160.710037] x5 : fff00000cc166100 x4 : 1ffe0000195a3b01 x3 :
1ffe00001b535b92
<4>[ 160.711016] x2 : 1ffe00001b535b96 x1 : 000000000000029c x0 :
0000000000000000
<4>[ 160.712071] Call trace:
<4>[ 160.712597] place_entity (kernel/sched/fair.c:5250 (discriminator 1))
<4>[ 160.713221] reweight_entity (kernel/sched/fair.c:3813)
<4>[ 160.713802] update_cfs_group (kernel/sched/fair.c:3975 (discriminator 1))
<4>[ 160.714277] dequeue_entities (kernel/sched/fair.c:7091)
<4>[ 160.714903] dequeue_task_fair (kernel/sched/fair.c:7144 (discriminator 1))
<4>[ 160.716502] move_queued_task.isra.0 (kernel/sched/core.c:2437
(discriminator 1))
<4>[ 160.717432] migration_cpu_stop (kernel/sched/core.c:2481
kernel/sched/core.c:2540)
<4>[ 160.718309] cpu_stopper_thread (kernel/stop_machine.c:511)
<4>[ 160.718871] smpboot_thread_fn (kernel/smpboot.c:164)
<4>[ 160.719699] kthread (kernel/kthread.c:389)
<4>[ 160.720382] ret_from_fork (arch/arm64/kernel/entry.S:861)
<4>[ 160.721092] ---[ end trace 0000000000000000 ]---
metadata:
history: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.10-123-gf6b51ed03daa/testrun/26866897/suite/log-parser-boot/test/exception-warning-cpu-pid-at-kernelschedfair-place_entity/history/
boot log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.10-123-gf6b51ed03daa/testrun/26866897/suite/log-parser-boot/test/exception-warning-cpu-pid-at-kernelschedfair-place_entity/log
## Build
* kernel: 6.12.11-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: f6b51ed03daaa30e4c3b3969505cc9b1625babca
* git describe: v6.12.10-123-gf6b51ed03daa
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.10-123-gf6b51ed03daa
## Test Regressions (compared to v6.12.9-190-gd056ad259f16)
## Metric Regressions (compared to v6.12.9-190-gd056ad259f16)
## Test Fixes (compared to v6.12.9-190-gd056ad259f16)
## Metric Fixes (compared to v6.12.9-190-gd056ad259f16)
## Test result summary
total: 117171, pass: 90748, fail: 8735, skip: 17614, xfail: 74
## Build Summary
* arc: 6 total, 5 passed, 1 failed
* arm: 143 total, 137 passed, 6 failed
* arm64: 58 total, 56 passed, 2 failed
* i386: 22 total, 19 passed, 3 failed
* mips: 38 total, 33 passed, 5 failed
* parisc: 5 total, 3 passed, 2 failed
* powerpc: 44 total, 40 passed, 4 failed
* riscv: 27 total, 24 passed, 3 failed
* s390: 26 total, 22 passed, 4 failed
* sh: 6 total, 5 passed, 1 failed
* sparc: 5 total, 3 passed, 2 failed
* x86_64: 50 total, 49 passed, 1 failed
## Test suites summary
* boot
* commands
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-rust
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 10:04 ` Naresh Kamboju
@ 2025-01-22 10:42 ` Peter Zijlstra
2025-01-22 10:56 ` Arnd Bergmann
1 sibling, 0 replies; 25+ messages in thread
From: Peter Zijlstra @ 2025-01-22 10:42 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Greg Kroah-Hartman, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
Anders Roxell, Vincent Guittot, Dan Carpenter, Arnd Bergmann
On Wed, Jan 22, 2025 at 03:34:16PM +0530, Naresh Kamboju wrote:
> On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.12.11 release.
> > There are 122 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Results from Linaro’s test farm.
> Regressions on arm64, arm, x86_64, and i386.
>
> The following build warn
> WARNING: CPU: 1 PID: 22 at kernel/sched/fair.c:5250 place_entity
> (kernel/sched/fair.c:5250 (discriminator 1))
Odd, are you seeing the same on .13 ?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 10:04 ` Naresh Kamboju
2025-01-22 10:42 ` Peter Zijlstra
@ 2025-01-22 10:56 ` Arnd Bergmann
2025-01-22 10:59 ` Peter Zijlstra
1 sibling, 1 reply; 25+ messages in thread
From: Arnd Bergmann @ 2025-01-22 10:56 UTC (permalink / raw)
To: Naresh Kamboju, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, Linus Torvalds, Andrew Morton,
Guenter Roeck, shuah, patches, lkft-triage, Pavel Machek,
Jon Hunter, Florian Fainelli, Sudip Mukherjee, srw, rwarsow,
Conor Dooley, hargar, Mark Brown, Peter Zijlstra, Anders Roxell,
Vincent Guittot, Dan Carpenter
On Wed, Jan 22, 2025, at 11:04, Naresh Kamboju wrote:
> On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> 0000000000000000
> <4>[ 160.712071] Call trace:
> <4>[ 160.712597] place_entity (kernel/sched/fair.c:5250 (discriminator 1))
> <4>[ 160.713221] reweight_entity (kernel/sched/fair.c:3813)
> <4>[ 160.713802] update_cfs_group (kernel/sched/fair.c:3975 (discriminator 1))
> <4>[ 160.714277] dequeue_entities (kernel/sched/fair.c:7091)
> <4>[ 160.714903] dequeue_task_fair (kernel/sched/fair.c:7144 (discriminator 1))
> <4>[ 160.716502] move_queued_task.isra.0 (kernel/sched/core.c:2437
> (discriminator 1))
I don't see anything that immediately sticks out as causing this,
but I do see five scheduler patches backported in stable-rc
on top of v6.12.8, these are the original commits:
66951e4860d3 ("sched/fair: Fix update_cfs_group() vs DELAY_DEQUEUE")
30dd3b13f9de ("sched_ext: keep running prev when prev->scx.slice != 0")
a2a3374c47c4 ("sched_ext: idle: Refresh idle masks during idle-to-idle transitions")
68e449d849fd ("sched_ext: switch class when preempted by higher priority scheduler")
6268d5bc1035 ("sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops_bypass()")
Arnd
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 10:56 ` Arnd Bergmann
@ 2025-01-22 10:59 ` Peter Zijlstra
2025-01-22 11:11 ` Ron Economos
0 siblings, 1 reply; 25+ messages in thread
From: Peter Zijlstra @ 2025-01-22 10:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Naresh Kamboju, Greg Kroah-Hartman, stable, patches, linux-kernel,
Linus Torvalds, Andrew Morton, Guenter Roeck, shuah, patches,
lkft-triage, Pavel Machek, Jon Hunter, Florian Fainelli,
Sudip Mukherjee, srw, rwarsow, Conor Dooley, hargar, Mark Brown,
Anders Roxell, Vincent Guittot, Dan Carpenter
On Wed, Jan 22, 2025 at 11:56:13AM +0100, Arnd Bergmann wrote:
> On Wed, Jan 22, 2025, at 11:04, Naresh Kamboju wrote:
> > On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
>
> > 0000000000000000
> > <4>[ 160.712071] Call trace:
> > <4>[ 160.712597] place_entity (kernel/sched/fair.c:5250 (discriminator 1))
> > <4>[ 160.713221] reweight_entity (kernel/sched/fair.c:3813)
> > <4>[ 160.713802] update_cfs_group (kernel/sched/fair.c:3975 (discriminator 1))
> > <4>[ 160.714277] dequeue_entities (kernel/sched/fair.c:7091)
> > <4>[ 160.714903] dequeue_task_fair (kernel/sched/fair.c:7144 (discriminator 1))
> > <4>[ 160.716502] move_queued_task.isra.0 (kernel/sched/core.c:2437
> > (discriminator 1))
>
> I don't see anything that immediately sticks out as causing this,
> but I do see five scheduler patches backported in stable-rc
> on top of v6.12.8, these are the original commits:
>
> 66951e4860d3 ("sched/fair: Fix update_cfs_group() vs DELAY_DEQUEUE")
This one reworks reweight_entity(), but I've been running with that on
top of 13-rc6 for a week or so and not seen this.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 10:59 ` Peter Zijlstra
@ 2025-01-22 11:11 ` Ron Economos
2025-01-28 11:46 ` Mike Galbraith
0 siblings, 1 reply; 25+ messages in thread
From: Ron Economos @ 2025-01-22 11:11 UTC (permalink / raw)
To: Peter Zijlstra, Arnd Bergmann
Cc: Naresh Kamboju, Greg Kroah-Hartman, stable, patches, linux-kernel,
Linus Torvalds, Andrew Morton, Guenter Roeck, shuah, patches,
lkft-triage, Pavel Machek, Jon Hunter, Florian Fainelli,
Sudip Mukherjee, srw, rwarsow, Conor Dooley, hargar, Mark Brown,
Anders Roxell, Vincent Guittot, Dan Carpenter
On 1/22/25 02:59, Peter Zijlstra wrote:
> On Wed, Jan 22, 2025 at 11:56:13AM +0100, Arnd Bergmann wrote:
>> On Wed, Jan 22, 2025, at 11:04, Naresh Kamboju wrote:
>>> On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org> wrote:
>>> 0000000000000000
>>> <4>[ 160.712071] Call trace:
>>> <4>[ 160.712597] place_entity (kernel/sched/fair.c:5250 (discriminator 1))
>>> <4>[ 160.713221] reweight_entity (kernel/sched/fair.c:3813)
>>> <4>[ 160.713802] update_cfs_group (kernel/sched/fair.c:3975 (discriminator 1))
>>> <4>[ 160.714277] dequeue_entities (kernel/sched/fair.c:7091)
>>> <4>[ 160.714903] dequeue_task_fair (kernel/sched/fair.c:7144 (discriminator 1))
>>> <4>[ 160.716502] move_queued_task.isra.0 (kernel/sched/core.c:2437
>>> (discriminator 1))
>> I don't see anything that immediately sticks out as causing this,
>> but I do see five scheduler patches backported in stable-rc
>> on top of v6.12.8, these are the original commits:
>>
>> 66951e4860d3 ("sched/fair: Fix update_cfs_group() vs DELAY_DEQUEUE")
> This one reworks reweight_entity(), but I've been running with that on
> top of 13-rc6 for a week or so and not seen this.
The offending commit is 6d71a9c6160479899ee744d2c6d6602a191deb1f
"sched/fair: Fix EEVDF entity placement bug causing scheduling lag"
It works fine on 6.13, at least on RISC-V (which is the only arch I test).
It's already been reverted and 6.12.11-rc2 has been pushed out.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-22 11:11 ` Ron Economos
@ 2025-01-28 11:46 ` Mike Galbraith
2025-01-28 14:39 ` Peter Zijlstra
0 siblings, 1 reply; 25+ messages in thread
From: Mike Galbraith @ 2025-01-28 11:46 UTC (permalink / raw)
To: Ron Economos, Peter Zijlstra, Arnd Bergmann
Cc: Naresh Kamboju, Greg Kroah-Hartman, stable, patches, linux-kernel,
Linus Torvalds, Andrew Morton, Guenter Roeck, shuah, patches,
lkft-triage, Pavel Machek, Jon Hunter, Florian Fainelli,
Sudip Mukherjee, srw, rwarsow, Conor Dooley, hargar, Mark Brown,
Anders Roxell, Vincent Guittot, Dan Carpenter
On Wed, 2025-01-22 at 03:11 -0800, Ron Economos wrote:
> On 1/22/25 02:59, Peter Zijlstra wrote:
> > On Wed, Jan 22, 2025 at 11:56:13AM +0100, Arnd Bergmann wrote:
> > > On Wed, Jan 22, 2025, at 11:04, Naresh Kamboju wrote:
> > > > On Tue, 21 Jan 2025 at 23:28, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > 0000000000000000
> > > > <4>[ 160.712071] Call trace:
> > > > <4>[ 160.712597] place_entity (kernel/sched/fair.c:5250 (discriminator 1))
> > > > <4>[ 160.713221] reweight_entity (kernel/sched/fair.c:3813)
> > > > <4>[ 160.713802] update_cfs_group (kernel/sched/fair.c:3975 (discriminator 1))
> > > > <4>[ 160.714277] dequeue_entities (kernel/sched/fair.c:7091)
> > > > <4>[ 160.714903] dequeue_task_fair (kernel/sched/fair.c:7144 (discriminator 1))
> > > > <4>[ 160.716502] move_queued_task.isra.0 (kernel/sched/core.c:2437
> > > > (discriminator 1))
> > > I don't see anything that immediately sticks out as causing this,
> > > but I do see five scheduler patches backported in stable-rc
> > > on top of v6.12.8, these are the original commits:
> > >
> > > 66951e4860d3 ("sched/fair: Fix update_cfs_group() vs DELAY_DEQUEUE")
> > This one reworks reweight_entity(), but I've been running with that on
> > top of 13-rc6 for a week or so and not seen this.
>
> The offending commit is 6d71a9c6160479899ee744d2c6d6602a191deb1f
> "sched/fair: Fix EEVDF entity placement bug causing scheduling lag"
>
> It works fine on 6.13, at least on RISC-V (which is the only arch I test).
Seems 6.13 is gripe free thanks to it containing 4423af84b297.
I stumbled upon a reproducer for my x86_64 desktop box: all I need do
is fire up a kvm guest in an enterprise configured host. That inspires
libvirt goop to engage group scheduling, splat follows instantly.
Back 4423af84b297 out of 6.13, it starts griping, add it to a 6.12 tree
containing 6d71a9c61604, it stops doing so.
> It's already been reverted and 6.12.11-rc2 has been pushed out.
So stable should perhaps take 4423af84b297 along with 6d71a9c61604?
-Mike
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-28 11:46 ` Mike Galbraith
@ 2025-01-28 14:39 ` Peter Zijlstra
2025-01-28 15:20 ` Mike Galbraith
2025-02-08 14:51 ` [tip: sched/urgent] sched/fair: Adhere to place_entity() constraints tip-bot2 for Peter Zijlstra
0 siblings, 2 replies; 25+ messages in thread
From: Peter Zijlstra @ 2025-01-28 14:39 UTC (permalink / raw)
To: Mike Galbraith
Cc: Ron Economos, Arnd Bergmann, Naresh Kamboju, Greg Kroah-Hartman,
stable, patches, linux-kernel, Linus Torvalds, Andrew Morton,
Guenter Roeck, shuah, patches, lkft-triage, Pavel Machek,
Jon Hunter, Florian Fainelli, Sudip Mukherjee, srw, rwarsow,
Conor Dooley, hargar, Mark Brown, Anders Roxell, Vincent Guittot,
Dan Carpenter
On Tue, Jan 28, 2025 at 12:46:07PM +0100, Mike Galbraith wrote:
> Seems 6.13 is gripe free thanks to it containing 4423af84b297.
>
> I stumbled upon a reproducer for my x86_64 desktop box: all I need do
> is fire up a kvm guest in an enterprise configured host. That inspires
> libvirt goop to engage group scheduling, splat follows instantly.
>
> Back 4423af84b297 out of 6.13, it starts griping, add it to a 6.12 tree
> containing 6d71a9c61604, it stops doing so.
Ooh, does something like the below (+- reverse-renames as applicable to
.12) also help?
---
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b67222dea491..8766f7d3d297 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3781,6 +3781,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
update_entity_lag(cfs_rq, se);
se->deadline -= se->vruntime;
se->rel_deadline = 1;
+ cfs_rq->nr_queued--;
if (!curr)
__dequeue_entity(cfs_rq, se);
update_load_sub(&cfs_rq->load, se->load.weight);
@@ -3811,6 +3812,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
place_entity(cfs_rq, se, 0);
if (!curr)
__enqueue_entity(cfs_rq, se);
+ cfs_rq->nr_queued++;
/*
* The entity's vruntime has been adjusted, so let's check
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-28 14:39 ` Peter Zijlstra
@ 2025-01-28 15:20 ` Mike Galbraith
2025-05-23 15:13 ` Mushahid Hussain
2025-02-08 14:51 ` [tip: sched/urgent] sched/fair: Adhere to place_entity() constraints tip-bot2 for Peter Zijlstra
1 sibling, 1 reply; 25+ messages in thread
From: Mike Galbraith @ 2025-01-28 15:20 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Ron Economos, Arnd Bergmann, Naresh Kamboju, Greg Kroah-Hartman,
stable, patches, linux-kernel, Linus Torvalds, Andrew Morton,
Guenter Roeck, shuah, patches, lkft-triage, Pavel Machek,
Jon Hunter, Florian Fainelli, Sudip Mukherjee, srw, rwarsow,
Conor Dooley, hargar, Mark Brown, Anders Roxell, Vincent Guittot,
Dan Carpenter
On Tue, 2025-01-28 at 15:39 +0100, Peter Zijlstra wrote:
> On Tue, Jan 28, 2025 at 12:46:07PM +0100, Mike Galbraith wrote:
>
> > Seems 6.13 is gripe free thanks to it containing 4423af84b297.
> >
> > I stumbled upon a reproducer for my x86_64 desktop box: all I need do
> > is fire up a kvm guest in an enterprise configured host. That inspires
> > libvirt goop to engage group scheduling, splat follows instantly.
> >
> > Back 4423af84b297 out of 6.13, it starts griping, add it to a 6.12 tree
> > containing 6d71a9c61604, it stops doing so.
>
> Ooh, does something like the below (+- reverse-renames as applicable to
> .12) also help?
Yup, seems to, 6.13 sans 4423af84b297 stopped griping.
> ---
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b67222dea491..8766f7d3d297 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3781,6 +3781,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
> update_entity_lag(cfs_rq, se);
> se->deadline -= se->vruntime;
> se->rel_deadline = 1;
> + cfs_rq->nr_queued--;
> if (!curr)
> __dequeue_entity(cfs_rq, se);
> update_load_sub(&cfs_rq->load, se->load.weight);
> @@ -3811,6 +3812,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
> place_entity(cfs_rq, se, 0);
> if (!curr)
> __enqueue_entity(cfs_rq, se);
> + cfs_rq->nr_queued++;
>
> /*
> * The entity's vruntime has been adjusted, so let's check
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-28 15:20 ` Mike Galbraith
@ 2025-05-23 15:13 ` Mushahid Hussain
0 siblings, 0 replies; 25+ messages in thread
From: Mushahid Hussain @ 2025-05-23 15:13 UTC (permalink / raw)
To: efault
Cc: akpm, anders.roxell, arnd, broonie, conor, dan.carpenter,
f.fainelli, gregkh, hargar, jonathanh, linux-kernel, linux,
lkft-triage, naresh.kamboju, patches, patches, pavel, peterz, re,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
vincent.guittot, hmushi, nh-open-source, sieberf
> On Tue, 2025-01-28 at 15:39 +0100, Peter Zijlstra wrote:
> > On Tue, Jan 28, 2025 at 12:46:07PM +0100, Mike Galbraith wrote:
> >
> >> Seems 6.13 is gripe free thanks to it containing 4423af84b297.
> >>
> >> I stumbled upon a reproducer for my x86_64 desktop box: all I need do
> >> is fire up a kvm guest in an enterprise configured host. That inspires
> >> libvirt goop to engage group scheduling, splat follows instantly.
> >>
> >> Back 4423af84b297 out of 6.13, it starts griping, add it to a 6.12 tree
> >> containing 6d71a9c61604, it stops doing so.
> >
> > Ooh, does something like the below (+- reverse-renames as applicable to
> > .12) also help?
>Yup, seems to, 6.13 sans 4423af84b297 stopped griping.
Hi Peter,
Are there any plans to backport this patch and 6d71a9c61604 into LTS versions
as well? I'm seeing the exact same issue on 6.6 as well, where the bug in
reweight results in incorrect vruntime calculation, leading to the deadline
always being in future, rather than decreasing on each scheduler tick. This
causes a task to run for a longer amount of time, starving other tasks on
the runqueue.
The issue disappears when testing with 4423af84b297 and your patch to avoid
tripping on WARN in place_entity(). I'm happy to push the backported patches
into 6.12 and 6.6, if that's alright.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [tip: sched/urgent] sched/fair: Adhere to place_entity() constraints
2025-01-28 14:39 ` Peter Zijlstra
2025-01-28 15:20 ` Mike Galbraith
@ 2025-02-08 14:51 ` tip-bot2 for Peter Zijlstra
2025-05-23 16:01 ` [PATCH 6.12 000/122] 6.12.11-rc1 review Mushahid Hussain
1 sibling, 1 reply; 25+ messages in thread
From: tip-bot2 for Peter Zijlstra @ 2025-02-08 14:51 UTC (permalink / raw)
To: linux-tip-commits
Cc: Mike Galbraith, Peter Zijlstra (Intel), stable, x86, linux-kernel
The following commit has been merged into the sched/urgent branch of tip:
Commit-ID: 55294004b122c997591d9de8446f5a4c60402805
Gitweb: https://git.kernel.org/tip/55294004b122c997591d9de8446f5a4c60402805
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Tue, 28 Jan 2025 15:39:49 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Sat, 08 Feb 2025 15:43:12 +01:00
sched/fair: Adhere to place_entity() constraints
Mike reports that commit 6d71a9c61604 ("sched/fair: Fix EEVDF entity
placement bug causing scheduling lag") relies on commit 4423af84b297
("sched/fair: optimize the PLACE_LAG when se->vlag is zero") to not
trip a WARN in place_entity().
What happens is that the lag of the very last entity is 0 per
definition -- the average of one element matches the value of that
element. Therefore place_entity() will match the condition skipping
the lag adjustment:
if (sched_feat(PLACE_LAG) && cfs_rq->nr_queued && se->vlag) {
Without the 'se->vlag' condition -- it will attempt to adjust the zero
lag even though we're inserting into an empty tree.
Notably, we should have failed the 'cfs_rq->nr_queued' condition, but
don't because they didn't get updated.
Additionally, move update_load_add() after placement() as is
consistent with other place_entity() users -- this change is
non-functional, place_entity() does not use cfs_rq->load.
Fixes: 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag")
Reported-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20250128143949.GD7145@noisy.programming.kicks-ass.net
---
kernel/sched/fair.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index f4e4d3e..d0b10e1 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3782,6 +3782,7 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
update_entity_lag(cfs_rq, se);
se->deadline -= se->vruntime;
se->rel_deadline = 1;
+ cfs_rq->nr_queued--;
if (!curr)
__dequeue_entity(cfs_rq, se);
update_load_sub(&cfs_rq->load, se->load.weight);
@@ -3808,10 +3809,11 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
enqueue_load_avg(cfs_rq, se);
if (se->on_rq) {
- update_load_add(&cfs_rq->load, se->load.weight);
place_entity(cfs_rq, se, 0);
+ update_load_add(&cfs_rq->load, se->load.weight);
if (!curr)
__enqueue_entity(cfs_rq, se);
+ cfs_rq->nr_queued++;
/*
* The entity's vruntime has been adjusted, so let's check
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-02-08 14:51 ` [tip: sched/urgent] sched/fair: Adhere to place_entity() constraints tip-bot2 for Peter Zijlstra
@ 2025-05-23 16:01 ` Mushahid Hussain
2025-05-23 16:46 ` David Woodhouse
0 siblings, 1 reply; 25+ messages in thread
From: Mushahid Hussain @ 2025-05-23 16:01 UTC (permalink / raw)
To: tip-bot2
Cc: efault, linux-kernel, linux-tip-commits, peterz, stable, x86,
hmushi, nh-open-source, sieberf
> The following commit has been merged into the sched/urgent branch of tip:
>
> Commit-ID: 55294004b122c997591d9de8446f5a4c60402805
> Gitweb: https://git.kernel.org/tip/55294004b122c997591d9de8446f5a4c60402805
> Author: Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Tue, 28 Jan 2025 15:39:49 +01:00
> Committer: Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Sat, 08 Feb 2025 15:43:12 +01:00
Was this merged to sched/urgent or any other branches/RCs? Given gitweb link
sends me to "Bad commit reference". I don't see this commit in sched/urgent:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=sched%2Furgent
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-05-23 16:01 ` [PATCH 6.12 000/122] 6.12.11-rc1 review Mushahid Hussain
@ 2025-05-23 16:46 ` David Woodhouse
0 siblings, 0 replies; 25+ messages in thread
From: David Woodhouse @ 2025-05-23 16:46 UTC (permalink / raw)
To: Mushahid Hussain, tip-bot2
Cc: efault, linux-kernel, linux-tip-commits, peterz, stable, x86,
nh-open-source, sieberf
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On Fri, 2025-05-23 at 16:01 +0000, Mushahid Hussain wrote:
> > The following commit has been merged into the sched/urgent branch of tip:
> >
> > Commit-ID: 55294004b122c997591d9de8446f5a4c60402805
> > Gitweb: https://git.kernel.org/tip/55294004b122c997591d9de8446f5a4c60402805
> > Author: Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Tue, 28 Jan 2025 15:39:49 +01:00
> > Committer: Peter Zijlstra <peterz@infradead.org>
> > CommitterDate: Sat, 08 Feb 2025 15:43:12 +01:00
>
> Was this merged to sched/urgent or any other branches/RCs? Given gitweb link
> sends me to "Bad commit reference". I don't see this commit in sched/urgent:
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=sched%2Furgent
I think something weird has just happened to the tip tree. All the
tip/x86/* branches also seem to have been reset to Linux 6.15-rc6.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 6.12 000/122] 6.12.11-rc1 review
2025-01-21 17:50 [PATCH 6.12 000/122] 6.12.11-rc1 review Greg Kroah-Hartman
` (7 preceding siblings ...)
2025-01-22 10:04 ` Naresh Kamboju
@ 2025-01-23 8:09 ` Harshit Mogalapalli
8 siblings, 0 replies; 25+ messages in thread
From: Harshit Mogalapalli @ 2025-01-23 8:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, Vegard Nossum, Darren Kenny
Hi Greg,
On 21/01/25 23:20, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.12.11 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 23 Jan 2025 17:45:02 +0000.
> Anything received after that time might be too late.
>
No problems seen on x86_64 and aarch64 with our testing.
Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thanks,
Harshit
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.11-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
^ permalink raw reply [flat|nested] 25+ messages in thread