public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@meta.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Vernet <void@manifault.com>,
	linux-kernel@vger.kernel.org, kernel-team@fb.com,
	Ingo Molnar <mingo@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	gautham.shenoy@amd.com
Subject: Re: schbench v1.0
Date: Fri, 21 Apr 2023 14:14:10 -0400	[thread overview]
Message-ID: <1bd3bb9c-581e-2e18-aa41-ecf000e3686e@meta.com> (raw)
In-Reply-To: <20230420150537.GC4253@hirez.programming.kicks-ass.net>

On 4/20/23 11:05 AM, Peter Zijlstra wrote:
> On Mon, Apr 17, 2023 at 10:10:25AM +0200, Chris Mason wrote:
> 
>> F128 N10                EEVDF    Linus
>> Wakeup  (usec): 99.0th: 755      1,266
>> Request (usec): 99.0th: 25,632   22,304
>> RPS    (count): 50.0th: 4,280    4,376
>>
>> F128 N10 no-locking     EEVDF    Linus
>> Wakeup  (usec): 99.0th: 823      1,118
>> Request (usec): 99.0th: 17,184   14,192
>> RPS    (count): 50.0th: 4,440    4,456
> 
> With the below fixlet (against queue/sched/eevdf) on my measly IVB-EP
> (2*10*2):
> 
> ./schbench -F128 -n10 -C
> 
> Request Latencies percentiles (usec) runtime 30 (s) (153800 total samples)
> 	  90.0th: 6376       (35699 samples)
> 	* 99.0th: 6440       (9055 samples)
> 	  99.9th: 7048       (1345 samples)
> 
> CFS
> 
> schbench -m2 -F128 -n10	-r90	OTHER	BATCH
> Wakeup  (usec): 99.0th:		6600	6328
> Request (usec): 99.0th:		35904	14640
> RPS    (count): 50.0th:		5368	6104
> 

Peter and I went back and forth a bit and now schbench git has a few fixes:

- README.md updated

- warmup time defaults to zero (disabling warmup).  This was causing the
stats inconsistency Peter noticed below.

- RPS calculated more often.  Every second instead of every reporting
interval.

- thread count scaled to CPU count when -m is used.  The thread count is
per messenge thread, so when you use -m2 like Peter did in these runs,
he was ending up with 2xNUM_CPUs workers.  That's why his wakeup
latencies are so high, he had double the work that I did.

I'll experiment with some of the suggestions he made too.

-chris


  parent reply	other threads:[~2023-04-21 18:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  8:10 schbench v1.0 Chris Mason
2023-04-20 15:05 ` Peter Zijlstra
2023-04-20 18:56   ` Peter Zijlstra
2023-04-21 18:14   ` Chris Mason [this message]
2023-08-14 12:30     ` Chen Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bd3bb9c-581e-2e18-aa41-ecf000e3686e@meta.com \
    --to=clm@meta.com \
    --cc=gautham.shenoy@amd.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox