From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756640AbdDGVye (ORCPT ); Fri, 7 Apr 2017 17:54:34 -0400 Received: from imap0.codethink.co.uk ([185.43.218.159]:58564 "EHLO imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbdDGVy0 (ORCPT ); Fri, 7 Apr 2017 17:54:26 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Apr 2017 22:54:19 +0100 From: Ben Dooks To: Thierry Reding Cc: linux-kernel@lists.codethink.co.uk, swarren@wwwdotorg.org, gnurou@gmail.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] memory: tegra: fix fdc test bug Organization: Codethink Ltd In-Reply-To: <20170407174301.GA4386@ulmo.ba.sec> References: <20170407172820.21292-1-ben.dooks@codethink.co.uk> <20170407174301.GA4386@ulmo.ba.sec> Message-ID: <1bfab352ccd1581882d6e82b6eb72cb4@codethink.com> User-Agent: Roundcube Webmail/1.1.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-07 18:43, Thierry Reding wrote: > On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote: >> The fdc variable is a bool, taking the address of this will generally >> produce true, thus skewing any users of the >> tegra_mc_set_latency_allowance >> code. >> >> Note, this does not seem to be producing a compiler warning. This was >> only >> spotted as it meant a caller was seeing 3 times higher than expected >> register results. >> >> Signed-off-by: Ben Dooks >> --- >> drivers/memory/tegra/mc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > What tree is this based on? I don't see this code anywhere in mainline. Apologies, turns out this a vendor added function. -- Ben