From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD2EB36AB53 for ; Thu, 7 May 2026 15:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168131; cv=none; b=AT/ZBsZ2ZZdFhjmmzaUPZA+vopK1MyP7TLIFzjRJmI8iLs+vB4wI0Ou5Aael3J8NyAYBqIIiLLup4AtPHXzLuUdKisPvNT56wIYaOrIgZ9yQsZZSH3NQs1R7MeOy4KPzEXj06w86xnyH6apLw3wSSEE8C8umAnFrlPIv0FKssPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168131; c=relaxed/simple; bh=aNyByG9sNTBiqaSV6nYGCh6plWf+Y8ycKOc8LjiEnWA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=puTC3sHCBk2rwfOVfgSVvIvSCnVcdfSNezKIgW761rPbldbS5wOwQAQzT1KJlgDZMzx1WzcKoR3gonVcHeuMV2tPprAdKs07F+O7ysAZ/nauPj3uEcnrhbl+DvcfcieFc4ivhdENij+C5ZPu/ieVP3VBCdHzKXk/c7Cdv/wxwC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SG4UGnKN; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SG4UGnKN" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso11619515e9.3 for ; Thu, 07 May 2026 08:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168128; x=1778772928; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Yei7lOebU/Uz3u8Jf+bfKKJkQIzcyOOAKefSxTqCzB8=; b=SG4UGnKNjStoqXBtuUL0EbnZ9jZljOaRCTHxH45LYY2AoVzqbkMiX+xKP379AcRSsI ZMH/+jfmIxLFdRkRr20KbGQgkOdAJydE+xYmW8KD8evVXzh6tGi5au4juV8uCQnAUkSx NJQpeZG/gWfsUKvA7hhxhwpejImAfrUXWan7TDXjLk3w48z1VrN0HHc4TwplUmc1kHsM ToVOUuivF/Zl+SIPOGhwyz5SmIHjCSVtmz1u2G7QaLzbePlOhozOiHySp/+qShQ3MPtq 4S69WNe+1DILUVN6OY04UwiWv/ez2U1lhLcRmShBPzxOL3xsicpeIZFVo1RTdqVYLZba k2Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168128; x=1778772928; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yei7lOebU/Uz3u8Jf+bfKKJkQIzcyOOAKefSxTqCzB8=; b=SYqslDhbOyWn2BEQ1DsrNO/avrnBhCFezC1Vu9kDWVmTWBgU5ZoWi+ijJrXa0UjaYw NVcBIpUXZ66f2lCqGAqO+/DbeZCfSsBGkBAVH3OJ/AN4742tuXvoKhPXEzaRjkeQqZRI +XLvss3Utj7K+1P3WpOrX4DhoR+3GP5HkGFA4N7dCnT2ROZ8M/bawkGsCpgv4vuT04/K DWEDdedSwfpfgW6+GG3Q8+EUjrB5WmGHiFxKXGqbgTIcZmmmGvGWVv/FL9eQZkI4ClVT 8+r7cpSlyzh0NmcPA7bX3Gs5frjDesuhrA9vS8ILEu7y3RymWAxivomMOdzXVImMkT7o bKdQ== X-Forwarded-Encrypted: i=1; AFNElJ9fMu0XKAqKndQhcw2z0QohZ7jp7lwYbUnYIuM4LBKPUNxD9NtbDJAKGIvP9XRQOPOnh6w5QVJLR6UgtUc=@vger.kernel.org X-Gm-Message-State: AOJu0YwTILaaB3Hz7/a3ZdRMGow5cRJgtcGlxzq0fpsBo6UxwotH2EN1 RJekZ682u2FoKWXPpxeXnltB0gBYfLmBWPyWAwfObnMm748e0DDocMW9zlRz9dCOu2I= X-Gm-Gg: AeBDievwgCNjSO+QEGavNdtAYwINV/bJ5/SgYZM4VMF6Qx/ySP7P3e44cuSctHnOfo2 0CiDzLXOocN6RZKhLuWOa1ve7X5pzwQnxKmwOEMzrVYnVwM1LbGZi1W8OP6DMsMC2OVfZ9PY+IC tASVXW7UokhkVmGfll7WSjOwTif1nLJXCzdVJuysPoa27064R/lsV0kYi8SvLr2ofM1w5qlB05O iTz9GXJmrPQtfQM9w1ylfnvk2M0oJuxzVlbDOmTADNyCa6R13zAOGoBFuZJnb3fD3t3KFZAV6LU 1a3oQRJlxsGu5ortVApS/jGBbWmWJrGs45dmaRzSzORoJ6dB4kBGYxnrcm90f1zdFuU6/s0xyI2 TV3E5RraNu/QJs8s4DXg8uU+KO+fn+KejZ5OfXNvHnKr3utkoacCulUqj+jtYkPOSO+5IfPNHwi DvTeRAI2aSDRWLM8NnQFRldM6VrTNeTPnRvc6DmQBEJtAKUEsRPKiiTIoTKYkvuLBQw2o8X7z7A n02xR1+3J+CpAmftgokd7cO9sFV X-Received: by 2002:a05:600c:811a:b0:483:7903:c3b1 with SMTP id 5b1f17b1804b1-48e51f35d0emr140931315e9.20.1778168127868; Thu, 07 May 2026 08:35:27 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53108c4csm63010005e9.6.2026.05.07.08.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:35:27 -0700 (PDT) Message-ID: <1c01b79d-e716-47bf-87a1-fb9f630a993c@linaro.org> Date: Thu, 7 May 2026 17:35:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 03/10] drm/panel/novatek-nt37700f: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-3-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-3-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-novatek-nt37700f.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > index 74f46a268c0f6..c221dd498fed4 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt37700f.c > @@ -225,9 +225,12 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi) > struct nt37700f_tianma *ctx; > int ret; > > - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > - if (!ctx) > - return -ENOMEM; > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + &nt37700f_tianma_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > ctx->supply = devm_regulator_get(dev, "power"); > if (IS_ERR(ctx->supply)) > @@ -247,8 +250,6 @@ static int nt37700f_tianma_probe(struct mipi_dsi_device *dsi) > dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST | > MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; > > - drm_panel_init(&ctx->panel, dev, &nt37700f_tianma_panel_funcs, > - DRM_MODE_CONNECTOR_DSI); > ctx->panel.prepare_prev_first = true; > > ctx->panel.backlight = nt37700f_tianma_create_backlight(dsi); > Reviewed-by: Neil Armstrong Thanks, Neil