Re: [PATCH v3 00/11] remoteproc: imx_dsp_rproc: Refactor to use new ops and remove switch-case logic

[Iuliana Prodan <iuliana.prodan@nxp.com>]

On 11/11/2025 3:41 AM, Peng Fan (OSS) wrote:
> This patchset aligns imx_dsp_rproc with the cleanup and modernization
> previously applied to imx_rproc.c. The goal is to simplify the driver by
> transitioning to the new ops-based method, eliminating the legacy
> switch-case logic for a cleaner and more maintainable design.
> 
> Patches 1–5: General cleanup, including code simplification and adoption
>               of the devres API.
> Patches 6–10: Transition to the new ops-based approach, removing the
>                switch-case structure.
> Patch 11: Remove the obsolete enum imx_rproc_method.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

For the series:

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
on i.MX8M Plus, i.MX8ULP, i.MX8QM, i.MX8QXP

Iulia

> ---
> Changes in v3:
> - Collected R-b
> - Simplify commit log for patch 4 per Frank.
> - Link to V2: https://lore.kernel.org/all/20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com/
> 
> Changes in v2:
> - Collected R-b
> - Patch 3: Update commit per Frank/Daniel
> - patch 8: Use priv->dsp_dcfg->dcfg to avoid adding "const struct imx_rproc_dsp_dcfg *dsp_dcfg"
> - Link to v1: https://lore.kernel.org/linux-remoteproc/CAEnQRZAOTFw=sBppHTYQAdfDBuNqkqk6gVO4FyP0EBsva3Oi+Q@mail.gmail.com/T/#m27c93af9fb1e7fdeb0766bdbffbaae39d79eefab
> 
> ---
> Peng Fan (11):
>        remoteproc: imx_dsp_rproc: simplify power domain attach and error handling
>        remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper
>        remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper
>        remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors
>        remoteproc: imx_dsp_rproc: Drop extra space
>        remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg
>        remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match
>        remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case
>        remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case
>        remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case
>        remoteproc: imx_rproc: Remove enum imx_rproc_method
> 
>   drivers/remoteproc/imx_dsp_rproc.c | 342 ++++++++++++++++++++-----------------
>   drivers/remoteproc/imx_rproc.h     |  14 --
>   2 files changed, 182 insertions(+), 174 deletions(-)
> ---
> base-commit: ab40c92c74c6b0c611c89516794502b3a3173966
> change-id: 20251111-imx-dsp-2025-11-11-1b0957e4cf5c
> 
> Best regards,