Re: Fw: ati-remote strangeness from 2.6.12 onwards

[mdew <some.nzguy@gmail.com>]

I discovered a minor change in 2.6.10-mm1, changing this value back
corrects the "ok" button issue.


diff -urN linux/drivers/usb/input/ati_remote.c
linux-2.6.11/drivers/usb/input/ati_remote.c
--- linux/drivers/usb/input/ati_remote.c        2005-08-02
17:56:26.000000000 +1200
+++ linux-2.6.11/drivers/usb/input/ati_remote.c 2005-08-02
17:54:34.000000000 +1200
@@ -263,7 +263,7 @@
        {KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1},      /* right */
        {KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1},       /* down */
        {KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1},         /* up */
-       {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1},      /* "OK" */
+       {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1},         /* "OK" */
        {KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */
        {KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1},   /* VOL - */
        {KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1},       /* MUTE  */


On 7/31/05, Andrew Morton <akpm@osdl.org> wrote:
> 
> 
> Begin forwarded message:
> 
> Date: Sun, 31 Jul 2005 12:18:23 +1200
> From: mdew <some.nzguy@gmail.com>
> To: linux-kernel <linux-kernel@vger.kernel.org>
> Subject: ati-remote strangeness from 2.6.12 onwards
> 
> 
> using 2.6.11 everything works fine, Upgrading too 2.6.13-rc3 I noticed 2 errors,
> 
> (1) When setting the HZ rating too 250 or 100 will cause the driver to
> excessfully repeat keys/accelerate when pressing a button, making it
> unusable :(
> 
> (2) the "Ok" button no longer works in anything after and including
> 2.6.12-rc1 (I've tested upto 2.6.13-rc3), 2.6.11 works fine. xbindkeys
> doesnt register any "ok" key presses on 2.6.12-rc1 onwards.
> 
> 2.6.11 xbindkeys responses (nothing shows up in -rc1)
> 
> mediabawx2:~# xbindkeys -mk
> Press combination of keys or/and click under the window.
> You can use one of the two lines after "NoCommand"
> in $HOME/.xbindkeysrc to bind a key.
> 
> --- Press "q" to stop. ---
> "NoCommand"
> m:0x0 + c:36
> Return
> "NoCommand"
> m:0x0 + c:36
> Return
> 
> 
> Thanks :)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>