From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262760AbVHDW0D (ORCPT ); Thu, 4 Aug 2005 18:26:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262759AbVHDWYC (ORCPT ); Thu, 4 Aug 2005 18:24:02 -0400 Received: from zproxy.gmail.com ([64.233.162.205]:51319 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S262762AbVHDWXs convert rfc822-to-8bit (ORCPT ); Thu, 4 Aug 2005 18:23:48 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MwPxoyTbnr0yIldNnIAU2l6xJqvcRyCPN48FgCl2TpW25fL5aRYB9xhYiEcNZdgN1lBKgj0X8HKJMt4aEqjSNA7lLnMJsw42rf0nQbdFqMl8AR3WMIWxLyhIo2mteo/wcOGfSyURAudih6Gcpec3bZwk6N4UhDDXEn//YQK4t18= Message-ID: <1c1c863605080415233c6aac0@mail.gmail.com> Date: Fri, 5 Aug 2005 10:23:45 +1200 From: Ryan Brown To: Andrew Morton Subject: Re: Fw: ati-remote strangeness from 2.6.12 onwards Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, vojtech@suse.cz, dtor_core@ameritech.net In-Reply-To: <20050804101515.4a983b29.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <20050730173253.693484a2.akpm@osdl.org> <1c1c8636050801220442d8351c@mail.gmail.com> <20050804101515.4a983b29.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Sorry Andrew, but the diff was incorrectly made, the updated patch, reverts the changes too TV, DVD and OK Button, from 2.6.12-rc1. diff -ruN linux-2.6.12/drivers/usb/input/ati_remote.c linux-2.6.12-modified/drivers/usb/input/ati_remote.c --- linux-2.6.12/drivers/usb/input/ati_remote.c 2005-06-18 07:48:29.000000000 +1200 +++ linux-2.6.12-modified/drivers/usb/input/ati_remote.c 2005-08-03 09:54:48.000000000 +1200 @@ -252,8 +252,8 @@ {KIND_FILTERED, 0xdd, 0x18, EV_KEY, KEY_KPENTER, 1}, /* "check" */ {KIND_FILTERED, 0xdb, 0x16, EV_KEY, KEY_MENU, 1}, /* "menu" */ {KIND_FILTERED, 0xc7, 0x02, EV_KEY, KEY_POWER, 1}, /* Power */ - {KIND_FILTERED, 0xc8, 0x03, EV_KEY, KEY_TV, 1}, /* TV */ - {KIND_FILTERED, 0xc9, 0x04, EV_KEY, KEY_DVD, 1}, /* DVD */ + {KIND_FILTERED, 0xc8, 0x03, EV_KEY, KEY_PROG1, 1}, /* TV */ + {KIND_FILTERED, 0xc9, 0x04, EV_KEY, KEY_PROG2, 1}, /* DVD */ {KIND_FILTERED, 0xca, 0x05, EV_KEY, KEY_WWW, 1}, /* WEB */ {KIND_FILTERED, 0xcb, 0x06, EV_KEY, KEY_BOOKMARKS, 1}, /* "book" */ {KIND_FILTERED, 0xcc, 0x07, EV_KEY, KEY_EDIT, 1}, /* "hand" */ @@ -263,7 +263,7 @@ {KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1}, /* right */ {KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1}, /* down */ {KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1}, /* up */ - {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1}, /* "OK" */ + {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1}, /* "OK" */ {KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */ {KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1}, /* VOL - */ {KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1}, /* MUTE */ On 8/5/05, Andrew Morton wrote: > mdew wrote: > > > > I discovered a minor change in 2.6.10-mm1, changing this value back > > corrects the "ok" button issue. > > > > > > diff -urN linux/drivers/usb/input/ati_remote.c > > linux-2.6.11/drivers/usb/input/ati_remote.c > > --- linux/drivers/usb/input/ati_remote.c 2005-08-02 > > 17:56:26.000000000 +1200 > > +++ linux-2.6.11/drivers/usb/input/ati_remote.c 2005-08-02 > > 17:54:34.000000000 +1200 > > @@ -263,7 +263,7 @@ > > {KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1}, /* right */ > > {KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1}, /* down */ > > {KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1}, /* up */ > > - {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1}, /* "OK" */ > > + {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1}, /* "OK" */ > > {KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */ > > {KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1}, /* VOL - */ > > {KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1}, /* MUTE */ > > This appears to be already applied in 2.6.12-rc5. >