From: Jiri Slaby <jirislaby@kernel.org>
To: lizhe <sensor1010@163.com>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type
Date: Tue, 3 Jan 2023 12:23:10 +0100 [thread overview]
Message-ID: <1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org> (raw)
In-Reply-To: <20230103110255.2699-1-sensor1010@163.com>
On 03. 01. 23, 12:02, lizhe wrote:
> in linflex_config_port() the member variable will be
> assigned again . see linflex_config_port()
Fine, but can you make the subject and the commit message a little bit
saner?
I.e. no tabs, no spaces before semicolons and colons. The subject should
be something like "serial: linflexuart: remove redundant uart type
_assignment_" and so on.
> Signed-off-by: lizhe <sensor1010@163.com>
Is this your legal name?
> ---
> drivers/tty/serial/fsl_linflexuart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
> return PTR_ERR(sport->membase);
>
> sport->dev = &pdev->dev;
> - sport->type = PORT_LINFLEXUART;
> sport->iotype = UPIO_MEM;
> sport->irq = platform_get_irq(pdev, 0);
> sport->ops = &linflex_pops;
--
js
suse labs
prev parent reply other threads:[~2023-01-03 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 11:02 [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type lizhe
2023-01-03 11:23 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sensor1010@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox