From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Henry Lin <henryl@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] xhci: fix runtime PM imbalance in USB2 resume
Date: Wed, 2 Mar 2022 11:16:30 +0200 [thread overview]
Message-ID: <1c41cf52-df45-baba-fdfc-03545cefcbcf@linux.intel.com> (raw)
In-Reply-To: <20220302065106.85021-1-henryl@nvidia.com>
On 2.3.2022 8.51, Henry Lin wrote:
> A race between system resume and device-initiated resume may result in
> runtime PM imbalance on USB2 root hub. If a device-initiated resume
> starts and system resume xhci_bus_resume() directs U0 before hub driver
> sees the resuming device in RESUME state, device-initiated resume will
> not be finished in xhci_handle_usb2_port_link_resume(). In this case,
> usb_hcd_end_port_resume() call is missing.
>
> This changes calls usb_hcd_end_port_resume() if resuming device reaches
> U0 to keep runtime PM balance.
>
> Fixes: a231ec41e6f6 ("xhci: refactor U0 link state handling in get_port_status")
> Signed-off-by: Henry Lin <henryl@nvidia.com>
> ---
Thanks, adding to queue
-Mathias
prev parent reply other threads:[~2022-03-02 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 5:53 [PATCH] xhci: fix runtime PM imbalance in USB2 resume Henry Lin
2022-02-25 6:23 ` Greg Kroah-Hartman
2022-02-25 6:40 ` Henry Lin
2022-02-25 6:49 ` Greg Kroah-Hartman
2022-02-25 7:02 ` Henry Lin
2022-02-25 7:15 ` [PATCH v2] " Henry Lin
2022-02-25 9:16 ` Greg KH
2022-02-26 16:06 ` Henry Lin
2022-02-26 16:20 ` Henry Lin
2022-02-28 10:56 ` Mathias Nyman
2022-03-01 10:28 ` Henry Lin
2022-03-01 15:49 ` Mathias Nyman
2022-03-01 19:18 ` Henry Lin
2022-03-02 6:51 ` [PATCH v3] " Henry Lin
2022-03-02 9:16 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c41cf52-df45-baba-fdfc-03545cefcbcf@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox