From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: "Thomas Kühnel" <thomas.kuehnel@avm.de>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] fs/ntfs3: Fixes for big endian systems
Date: Fri, 30 Dec 2022 16:07:12 +0400 [thread overview]
Message-ID: <1c45a3aa-275a-2815-79bf-ef72df30db97@paragon-software.com> (raw)
In-Reply-To: <20211207102454.576906-1-thomas.kuehnel@avm.de>
On 07.12.2021 14:24, Thomas Kühnel wrote:
> I tried running the NTFS3 driver on a MIPS big endian system and
> noticed various errors when it tried to access bitmaps structures
> that are stored as little endian on disk.
>
> These patches were mainly tested in a qemu mips environment.
>
> I'm open for suggestions how to better implement the second patch
> "add functions to modify LE bitmaps". It adds copies of two functions
> from lib/bitmap.c but modified to work with little endian bitmaps.
> Other filesystems seem to have similar functions defined locally like
> le_bitmap_set in btrfs or ext4_set_bits in ext4 but no global
> implementation exists.
>
> Thomas Kühnel (3):
> fs/ntfs3: fix endian conversion in ni_fname_name
> fs/ntfs3: add functions to modify LE bitmaps
> fs/ntfs3: use _le variants of bitops functions
>
> fs/ntfs3/bitmap.c | 56 +++++++++++++++++++++++++++++++++++++++-------
> fs/ntfs3/frecord.c | 4 +++-
> fs/ntfs3/fslog.c | 4 ++--
> fs/ntfs3/fsntfs.c | 8 +++----
> fs/ntfs3/index.c | 14 ++++++------
> fs/ntfs3/ntfs_fs.h | 3 +++
> 6 files changed, 67 insertions(+), 22 deletions(-)
>
>
> base-commit: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
Hello Thomas,
Thanks for patches, they have been applied long ago.
Sorry for not responding immediately.
prev parent reply other threads:[~2022-12-30 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:24 [PATCH 0/3] fs/ntfs3: Fixes for big endian systems Thomas Kühnel
2021-12-07 10:24 ` [PATCH 1/3] fs/ntfs3: fix endian conversion in ni_fname_name Thomas Kühnel
2021-12-07 16:00 ` kernel test robot
2021-12-09 10:50 ` Thomas Kühnel
2021-12-07 10:24 ` [PATCH 2/3] fs/ntfs3: add functions to modify LE bitmaps Thomas Kühnel
2021-12-07 17:31 ` kernel test robot
2021-12-07 10:24 ` [PATCH 3/3] fs/ntfs3: use _le variants of bitops functions Thomas Kühnel
2022-12-30 12:07 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c45a3aa-275a-2815-79bf-ef72df30db97@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=thomas.kuehnel@avm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox