From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 385693C4561 for ; Tue, 5 May 2026 18:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004955; cv=none; b=X8udPtGlgL5D6rzoZMK5SYTefmO/Afy7lEkfj7opxO3jUCHxo3Sv64PmbH01GyH7vW1wNbI8b4x9MFzZzKue+fiir2bwJqYQabKZur4xXDkp+TT4S9ZbDef9fy148HQpnxjzWIxwBw38Ciq9iivFVA0u/L+5DY3mg44ymGkXNYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004955; c=relaxed/simple; bh=nLIMB1PdV3eOid1SLb0XX+dckuXtlfeDMJV7ZHeV5YM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NouVXE3kY1HUJaoCK/VK4tNIr93rtXAfhRdLuQ5+DVTEHuAO8spukhrVWuX/rdvlvbu5CrPpedtKUKJav8fpWaTNTP9ZdcojKkwgPaiXWe9V/VgnhifV2o5Y3Xx6qLT5mEnyT1BFHSo1QrktXgbAthcJDC1V4JRmNhAmnev0q2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XFjPsvTQ; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XFjPsvTQ" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-4042905015cso3521517fac.0 for ; Tue, 05 May 2026 11:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1778004953; x=1778609753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p4A7BikZMtv/yj3plsfhVEeOjiwdWqagCxXKNIKmazk=; b=XFjPsvTQZ2hFmeCwuntc1QgBNrKOOwbZYRTGyNwLzYksrtQd8xXMOUuM8Q1eItf5k8 13eAD5HM5/Zr0JWN/myHhkGY0HCuZ2BN6OAEAV7vhdDqvTZJKphrIGJo8fn2TWQouGrd 8VfViCh6Fqz+JbQYJa3xEgHrzczEp5du0Z07o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778004953; x=1778609753; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p4A7BikZMtv/yj3plsfhVEeOjiwdWqagCxXKNIKmazk=; b=gvHoCW8YgynAI+x7eI93y90fYTuBdJeCLO7YQPrgPiPKlI1oUBSo56LvG3L8fxo3NP aOQ/SQ81y4aB4onuQ+llWkeZ7dkJTqGgMMFzATYrKCKZ4oMO2maA396ZBUUPqx5f7jdz OPppkwk3bUcHXSxcPVy8XdgIFfuv22ntphwUzoR5BzT9RjYTrvPJOVCN0vY/uF1ExGEe r5ajH2otx1Qtjz0iIw2bTrEIYW/SFJgTemuJbRxOxboErgFbIzoxRiIHjAHG1hE+jQMy V6MQHcth0dMIavYArTP6oITWwkOsVCCPNx+Jl0selMj/mcnas6Kf7rflAqngy2TGMANb qngA== X-Forwarded-Encrypted: i=1; AFNElJ9B3OYO9EDZDcvTBcl1QFXCMQLVfpOpX2T8a/M1yHMDW5GOiQH6Lok6G5KAmgZzxou9lf/me8xH5QPmzVg=@vger.kernel.org X-Gm-Message-State: AOJu0YzNEpwqSZgLC2M7cOKXBfIx7kEEFpI8ChFzcG3e3YXK3voSPzzi Nr35h9uWFCnXmIpESCYVputpaMtNYuTQqkwm5LQ0rlwzwTTCAfJpNsbOchWCqbFfI60= X-Gm-Gg: AeBDieu2FTW8pBow2vC8SnOVv7vJbIOxIvkHNyPcTn3jd4MH/CFdRmbxbj/NOEsXmwD Xi/uNEcu/6yWXZfe03+O8qONUnielDw876itFHLjdgSVYFJKQscQW6MKciKqe54kptq7sXcDevE 0Vq7YPbC40aLGnsq4GJMUcTliYUebr6niiXD/X9PP6bfjCzxhuNern5MnR/qeTWM+l6IGMExVym h13xPYzbaAJEBYIP7IPNbDbYHOnmylUJL+dsLO9hWtUV/YOh1crIIJkCZKwDgIdmoLwR+XleiYR sD4atkCBCQZFmZw5kayGaBAT5UH61CK00yT1dk3H3LnC52Jt25NKnWmkXccXiRMRZjTQ/4OQ3L/ O5+Avzh1jMPMIIybH4oZLKjJ2B22G3x70XsZKJVkwYpmT+cBVjt9B9R8pSSMCr9jeLpJ3+Pu+CH vFE4lDvkXxTpx5uMC1FWUKOX3Jx+TQMsWJKRTXqOWQ9g== X-Received: by 2002:a05:6870:c201:b0:40e:dcc9:c3a9 with SMTP id 586e51a60fabf-434f56d7d32mr274919fac.3.1778004953077; Tue, 05 May 2026 11:15:53 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43454cbd8dbsm14446656fac.11.2026.05.05.11.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 11:15:52 -0700 (PDT) Message-ID: <1c8b0149-261a-447c-acd9-4ee62b74adfd@linuxfoundation.org> Date: Tue, 5 May 2026 12:15:51 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] usbip: vhci_hcd: reduce CONFIG_USBIP_VHCI_NR_HCS upper bound to 32 To: Adrian Wowk , valentina.manea.m@gmail.com, shuah@kernel.org Cc: i@zenithal.me, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260414010050.158064-1-dev@adrianwowk.com> <20260414010050.158064-3-dev@adrianwowk.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260414010050.158064-3-dev@adrianwowk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/13/26 19:00, Adrian Wowk wrote: > Each VHCI HC instance registers two USB buses (one HS, one SS). > USB_MAXBUS in drivers/usb/core/hcd.c is hard-coded to 64, giving an > effective maximum of 32 VHCI HC instances (32 * 2 = 64 buses). > > The Kconfig range for USBIP_VHCI_NR_HCS currently allows up to 128, > which will cause probe failures for any HC instance beyond the 32nd. > These probe failures trigger the NULL pointer dereference fixed in the > previous commit. > > Reduce the upper bound to 32 to reflect the real maximum imposed by > USB_MAXBUS. Note that probe failures can still occur below this limit > if real hardware has already claimed enough USB bus numbers, making > the NULL check fix necessary regardless. > > Signed-off-by: Adrian Wowk > --- > drivers/usb/usbip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig > index b9f94e2e278..50945b6fae1 100644 > --- a/drivers/usb/usbip/Kconfig > +++ b/drivers/usb/usbip/Kconfig > @@ -40,7 +40,7 @@ config USBIP_VHCI_HC_PORTS > > config USBIP_VHCI_NR_HCS > int "Number of USB/IP virtual host controllers" > - range 1 128 > + range 1 32 > default 1 > depends on USBIP_VHCI_HCD > help Looks good to me. Reviewed-by: Shuah Khan Greg, Please pick this up. thanks, -- Shuah