Re: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload support

Andrew Lunn
2023-09-21T20:32:40Z

> > + if (!netif_running(ndev)) {
> > + netdev_err(ndev, "interface is down, link speed unknown\n");
> > + return -ENETDOWN;
> > + }
>
> Do we really need this?

The error message suggests it is wrong anyway. netif_running() being
true means it is admin up. But the carrier might be down, and so the
link speed is unknown. So maybe this should be using netif_carrier_ok() ?

Andrew