From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: linux-mips@linux-mips.org, msalter@redhat.com,
dmitry.torokhov@gmail.com, Ralf Baechle <ralf@linux-mips.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO
Date: Fri, 16 Jun 2017 10:45:05 -0700 [thread overview]
Message-ID: <1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1706160249370.23046@tp.orcam.me.uk>
On 06/15/2017 06:56 PM, Maciej W. Rozycki wrote:
> On Mon, 5 Jun 2017, Florian Fainelli wrote:
>
>> Out of the many MIPS platforms only 3 appear to be actually using an
>> I8042 keyboard controller: SGI, JAZZ and LOOGSON64, remove
>> ARCH_MIGHT_HAVE_PC_SERIO from the top-level MIPS Kconfig symbol and move
>> it down to those platforms that need it.
>
> How did you determine that? Malta for one not only has an SMSC FDC37M817
> Super I/O Controller featuring an 8042-compatible core, but actual PS/2
> keyboard and mouse connectors as well.
I was just grepping for i8042 in platform code to determine that, this
came after having SERIO accidentally enabled on my platform
(BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap
out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that
don't need it.
Will come up with a v2 that includes malta, any other platforms for
which it's not obvious?
--
Florian
next prev parent reply other threads:[~2017-06-16 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 17:10 [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO Florian Fainelli
2017-06-16 1:56 ` Maciej W. Rozycki
2017-06-16 17:45 ` Florian Fainelli [this message]
2017-06-16 20:18 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=msalter@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).