Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources

Conor Dooley
2023-04-11T21:07:00Z

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
> Different compatible parse device tree resources work in different ways.

Right now there is only one compatible, so this commit message needs to
be expanded on to provide more information on your motivation.

> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
> {
> struct jh71xx_pmu_dev *pmd;
> @@ -296,23 +325,20 @@ static int jh71xx_pmu_probe(struct platform_device *pdev)
> if (!pmu)
> return -ENOMEM;
>
> - pmu->base = device_node_to_regmap(np);
> - if (IS_ERR(pmu->base))
> - return PTR_ERR(pmu->base);
> -
> - pmu->irq = platform_get_irq(pdev, 0);
> - if (pmu->irq < 0)
> - return pmu->irq;
> -
> - ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
> - 0, pdev->name, pmu);
> - if (ret)
> - dev_err(dev, "failed to request irq\n");
> + spin_lock_init(&pmu->lock);
>
> match_data = of_device_get_match_data(dev);
> if (!match_data)
> return -EINVAL;
>
> + if (match_data->pmu_parse_dt) {

How can this be false?

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]