Re: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources

Changhuang Liang
2023-04-12T07:53:04Z

On 2023/4/12 5:06, Conor Dooley wrote:
> On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
>> Different compatible parse device tree resources work in different ways.
>
> Right now there is only one compatible, so this commit message needs to
> be expanded on to provide more information on your motivation.
>

OK, will add more commit message.

>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>
>> static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
>> {
[...]
>>
>> match_data = of_device_get_match_data(dev);
>> if (!match_data)
>> return -EINVAL;
>>
>> + if (match_data->pmu_parse_dt) {
>
> How can this be false?
>
> Cheers,
> Conor.

Yes, it will not be false, I will delete this if condition