Re: [PATCH v1 1/7] dt-bindings: power: Constrain properties for JH7110 PMU

Changhuang Liang
2023-04-12T02:51:18Z

On 2023/4/12 4:13, Conor Dooley wrote:
> On Mon, Apr 10, 2023 at 11:47:37PM -0700, Changhuang Liang wrote:
>> When use "starfive,jh7110-pmu-dphy" compatible, do not need the reg and
>> interrupts properties.
>
> Please write a commit message explaining why this is needed.
> The commit message as-is is insufficient, but also IMO wrong incorrect.
> I think it would more accurately be "...: add jh7110 dphy pmu support" or
> similar & the body should explain why this particular PMU has no
> reg/interrupts.
>
> Cheers,
> Conor.
>

OK, Thanks for your comments, I will reorganize the commit message more clarity.

>>
>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>> ---
>> .../bindings/power/starfive,jh7110-pmu.yaml | 14 ++++++++++++--
>> include/dt-bindings/power/starfive,jh7110-pmu.h | 3 +++
[...]
>>