From: "Huang, Kai" <kai.huang@intel.com>
To: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"peterz@infradead.org" <peterz@infradead.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"x86@kernel.org" <x86@kernel.org>,
"kas@kernel.org" <kas@kernel.org>,
"sagis@google.com" <sagis@google.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"ashish.kalra@amd.com" <ashish.kalra@amd.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH v4 1/7] x86/kexec: Consolidate relocate_kernel() function parameters
Date: Mon, 21 Jul 2025 21:36:48 +0000 [thread overview]
Message-ID: <1d2956ba8c7f0198ed76e09e2f1540d53c96815b.camel@intel.com> (raw)
In-Reply-To: <7eb254a7-473a-94c6-8dd5-24377ed67a34@amd.com>
On Mon, 2025-07-21 at 16:27 -0500, Tom Lendacky wrote:
> > > > @@ -204,7 +202,7 @@ SYM_CODE_START_LOCAL_NOALIGN(identity_mapped)
> > > > * entries that will conflict with the now unencrypted memory
> > > > * used by kexec. Flush the caches before copying the kernel.
> > > > */
> > > > - testq %r8, %r8
> > > > + testq $RELOC_KERNEL_HOST_MEM_ACTIVE, %r11
> > >
> > > Hmmm... can't both bits be set at the same time? If so, then this will
> > > fail. This should be doing bit tests now.
> >
> > TEST instruction performs logical AND of the two operands, therefore the
> > above equals to:
> >
> > set ZF if "R11 AND BIT(1) == 0".
> >
> > Whether there's any other bits set in R11 doesn't impact the above, right?
> >
>
> Doh! My bad, yes, not sure what I was thinking there.
>
Np and thanks! I'll address your other comments but I'll see whether Boris
has any other comments first.
next prev parent reply other threads:[~2025-07-21 21:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 21:46 [PATCH v4 0/7] TDX host: kexec/kdump support Kai Huang
2025-07-17 21:46 ` [PATCH v4 1/7] x86/kexec: Consolidate relocate_kernel() function parameters Kai Huang
2025-07-21 14:40 ` Tom Lendacky
2025-07-21 21:20 ` Huang, Kai
2025-07-21 21:27 ` Tom Lendacky
2025-07-21 21:36 ` Huang, Kai [this message]
2025-07-21 23:05 ` H. Peter Anvin
2025-07-21 23:29 ` Huang, Kai
2025-07-21 23:42 ` Huang, Kai
2025-07-22 0:44 ` H. Peter Anvin
2025-07-22 0:53 ` Huang, Kai
2025-07-23 8:13 ` Huang, Kai
2025-07-22 14:58 ` Borislav Petkov
2025-07-23 2:13 ` Huang, Kai
2025-07-17 21:46 ` [PATCH v4 2/7] x86/sme: Use percpu boolean to control WBINVD during kexec Kai Huang
2025-07-17 21:46 ` [PATCH v4 3/7] x86/virt/tdx: Mark memory cache state incoherent when making SEAMCALL Kai Huang
2025-07-22 14:52 ` Chao Gao
2025-07-23 1:59 ` Huang, Kai
2025-07-23 6:47 ` Chao Gao
2025-07-17 21:46 ` [PATCH v4 4/7] x86/kexec: Disable kexec/kdump on platforms with TDX partial write erratum Kai Huang
2025-07-17 21:46 ` [PATCH v4 5/7] x86/virt/tdx: Remove the !KEXEC_CORE dependency Kai Huang
2025-07-17 21:46 ` [PATCH v4 6/7] x86/virt/tdx: Update the kexec section in the TDX documentation Kai Huang
2025-07-17 21:46 ` [PATCH v4 7/7] KVM: TDX: Explicitly do WBINVD when no more TDX SEAMCALLs Kai Huang
2025-07-21 13:08 ` [PATCH v4 0/7] TDX host: kexec/kdump support Tom Lendacky
2025-07-21 14:50 ` Tom Lendacky
2025-07-21 21:30 ` Huang, Kai
2025-07-21 21:30 ` Huang, Kai
2025-07-22 13:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d2956ba8c7f0198ed76e09e2f1540d53c96815b.camel@intel.com \
--to=kai.huang@intel.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).