Re: [PATCH V2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l

kgunda
2019-11-06T06:44:03Z

On 2019-11-06 00:49, Stephen Boyd wrote:
> Quoting Kiran Gunda (2019-11-04 21:21:49)
>> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
>> found on SC7180 based platforms.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> - Changes from V1:
>> Sorted the macros and compatibles.
>
> I don't see anything sorted though.
>
Sorry .. I might have misunderstood your comment. Let me know if my
understanding is correct.

>>>> And compatible here.
>>> And on macro name here.

This means you want to sort all the existing compatible and macros in
alpha numeric order ?

>>>> Please sort on compatible string
This means you want sort in the order how the compatibles are defined ?

>>
>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++
>> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> index 1437062..b5fc64e 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
>> @@ -32,6 +32,8 @@ Required properties:
>> "qcom,pm8998",
>> "qcom,pmi8998",
>> "qcom,pm8005",
>> + "qcom,pm6150",
>> + "qcom,pm6150l",
>
> And this looks badly tabbed or something?
>
My bad, I used tabs. Will correct it in next post.
>> or generalized "qcom,spmi-pmic".
>> - reg: Specifies the SPMI USID slave address for this
>> device.
>> For more information see:
>> diff --git a/drivers/mfd/qcom-spmi-pmic.c
>> b/drivers/mfd/qcom-spmi-pmic.c
>> index e8fe705..74b7980 100644
>> --- a/drivers/mfd/qcom-spmi-pmic.c
>> +++ b/drivers/mfd/qcom-spmi-pmic.c
>> @@ -34,6 +34,8 @@
>> #define PM8998_SUBTYPE 0x14
>> #define PMI8998_SUBTYPE 0x15
>> #define PM8005_SUBTYPE 0x18
>> +#define PM6150_SUBTYPE 0x28
>> +#define PM6150L_SUBTYPE 0x27
>>
>> static const struct of_device_id pmic_spmi_id_table[] = {
>> { .compatible = "qcom,spmi-pmic", .data = (void
>> *)COMMON_SUBTYPE },
>> @@ -53,6 +55,8 @@
>> { .compatible = "qcom,pm8998", .data = (void
>> *)PM8998_SUBTYPE },
>> { .compatible = "qcom,pmi8998", .data = (void
>> *)PMI8998_SUBTYPE },
>> { .compatible = "qcom,pm8005", .data = (void
>> *)PM8005_SUBTYPE },
>> + { .compatible = "qcom,pm6150", .data = (void
>> *)PM6150_SUBTYPE },
>> + { .compatible = "qcom,pm6150l", .data = (void
>> *)PM6150L_SUBTYPE },
>> { }
>> };
>>