From: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>,
<manivannan.sadhasivam@linaro.org>,
<James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <andersson@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>,
Nitin Rawat <quic_nitirawa@quicinc.com>
Subject: Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature
Date: Fri, 20 Dec 2024 15:36:00 +0530 [thread overview]
Message-ID: <1d407f42-681d-4e8b-86f5-a4d368987115@quicinc.com> (raw)
In-Reply-To: <eadb98dd-f482-4479-8ff8-dcf301edf18c@acm.org>
On 19-Dec-24 10:53 PM, Bart Van Assche wrote:
> On 12/18/24 10:16 PM, Ram Kumar Dwivedi wrote:
>> On 18-Dec-24 10:49 PM, Bart Van Assche wrote:
>>> On 12/18/24 7:11 AM, Ram Kumar Dwivedi wrote:
>>>> + uint8_t val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
>>>
>>> This array can be declared 'static const', isn't it?
>>
>> As this value is not modified in this function, we will declare it as const in next patchset
>
> Why only 'const'? Why not 'static const' as everyone else does for this
> type of arrays?
Hi Bart,
This function will be only called once during boot and "val" is a local variable, we don't see any advantage in making it static.
If you still recommend, i will add the static keyword in next patchset.
Thanks,
Ram.
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2024-12-20 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 15:11 [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature Ram Kumar Dwivedi
2024-12-18 17:19 ` Bart Van Assche
2024-12-19 6:16 ` Ram Kumar Dwivedi
2024-12-19 17:23 ` Bart Van Assche
2024-12-20 10:06 ` Ram Kumar Dwivedi [this message]
2024-12-20 17:16 ` Bart Van Assche
2024-12-23 13:30 ` Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d407f42-681d-4e8b-86f5-a4d368987115@quicinc.com \
--to=quic_rdwivedi@quicinc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andersson@kernel.org \
--cc=bvanassche@acm.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).