From: Matthias Brugger <matthias.bgg@gmail.com>
To: James Liao <jamesjj.liao@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>, Kevin Hilman <khilman@kernel.org>,
Daniel Kurtz <djkurtz@chromium.org>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform
Date: Tue, 25 Oct 2016 16:04:05 +0200 [thread overview]
Message-ID: <1d5cda95-467a-4f95-1cc9-b8f156271a54@gmail.com> (raw)
In-Reply-To: <1476953798-23263-2-git-send-email-jamesjj.liao@mediatek.com>
Hi James,
On 10/20/2016 10:56 AM, James Liao wrote:
> -static int scpsys_probe(struct platform_device *pdev)
> +static void init_clks(struct platform_device *pdev, struct clk *clk[CLK_MAX])
I prefer struct clk **clk.
> +{
> + int i;
> +
> + for (i = CLK_NONE + 1; i < CLK_MAX; i++)
> + clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> +}
> +
> +static struct scp *init_scp(struct platform_device *pdev,
> + const struct scp_domain_data *scp_domain_data, int num)
> {
> struct genpd_onecell_data *pd_data;
> struct resource *res;
> - int i, j, ret;
> + int i, j;
> struct scp *scp;
> - struct clk *clk[MT8173_CLK_MAX];
> + struct clk *clk[CLK_MAX];
should be *[CLK_MAX - 1] but I would prefer to define in the enum:
CLK_MAX = CLK_VENC_LT,
If you are ok with it, I can fix both of my comments when applying.
Regards,
Matthias
next prev parent reply other threads:[~2016-10-25 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 8:56 [PATCH v9 0/4] Mediatek MT2701 SCPSYS power domain support James Liao
2016-10-20 8:56 ` [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform James Liao
2016-10-25 14:04 ` Matthias Brugger [this message]
2016-10-28 9:36 ` James Liao
2016-10-30 23:57 ` Matthias Brugger
2016-10-20 8:56 ` [PATCH v9 2/4] soc: mediatek: Init MT8173 scpsys driver earlier James Liao
2016-10-31 0:08 ` Matthias Brugger
2016-10-31 2:08 ` James Liao
2016-11-15 10:45 ` Honghui Zhang
2016-10-20 8:56 ` [PATCH v9 3/4] soc: mediatek: Add MT2701 power dt-bindings James Liao
2016-10-30 23:57 ` Matthias Brugger
2016-10-31 0:01 ` Matthias Brugger
2016-10-20 8:56 ` [PATCH v9 4/4] soc: mediatek: Add MT2701 scpsys driver James Liao
2016-10-30 23:57 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5cda95-467a-4f95-1cc9-b8f156271a54@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox