From: Michal Simek <michal.simek@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Conall O'Griofa <conall.o'griofa@xilinx.com>,
<linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v1 1/2] iio: adc: xilinx-xadc: Make use of device properties
Date: Mon, 4 Jul 2022 12:43:26 +0200 [thread overview]
Message-ID: <1d6eba67-5a63-e1b2-c9cd-583b950ddca6@amd.com> (raw)
In-Reply-To: <YsBYvPKfZRLygCyz@smile.fi.intel.com>
Hi Andy,
On 7/2/22 16:39, Andy Shevchenko wrote:
> On Mon, Jun 20, 2022 at 04:58:04PM +0200, Michal Simek wrote:
>> On 6/3/22 19:32, Jonathan Cameron wrote:
>>> On Tue, 31 May 2022 17:11:17 +0300
>>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>>
>>>> Convert the module to be property provider agnostic and allow
>>>> it to be used on non-OF platforms.
>>>>
>>>> Add mod_devicetable.h include.
>>>>
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>
>>> These both seem good to me, but as the driver is fairly actively maintained,
>>> I'll let this one sit on the list for a while so others can take a look.
>>>
>>> Whilst it 'seems' unlikely anyone will ever use this driver with other firmware
>>> I am keen to reduce the number of of-specific drivers in IIO just to avoid
>>> any chance of cut and paste.
>>>
>>> Who knows, I'm trying to run an aspeed-i2c driver with ACPI at the moment
>>> because it's handy for a emulated setup, so maybe the same will one day happen
>>> with this device :) Weirder things have happened.
>>
>> Conall: Can you please test these changes and provide your feedback?
>
> Hmm... No news?
Anand unfortunately left the company. I have asked testing team to test this
patch and they can't see any issue.
That's why:
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2022-07-04 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 14:11 [PATCH v1 1/2] iio: adc: xilinx-xadc: Make use of device properties Andy Shevchenko
2022-05-31 14:11 ` [PATCH v1 2/2] iio: adc: xilinx-xadc: Drop duplicate NULL check in xadc_parse_dt() Andy Shevchenko
2022-06-03 17:32 ` [PATCH v1 1/2] iio: adc: xilinx-xadc: Make use of device properties Jonathan Cameron
2022-06-20 14:58 ` Michal Simek
2022-07-02 14:39 ` Andy Shevchenko
2022-07-04 10:43 ` Michal Simek [this message]
2022-07-04 16:18 ` Andy Shevchenko
2022-07-13 16:12 ` Jonathan Cameron
2022-07-02 14:52 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d6eba67-5a63-e1b2-c9cd-583b950ddca6@amd.com \
--to=michal.simek@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conall.o'griofa@xilinx.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox