public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: common: ms_sensors: Remove unnecessary cast on void pointer
Date: Sun, 2 Apr 2017 09:48:07 +0100	[thread overview]
Message-ID: <1db695c8-44ba-cd0a-bb19-e935725db1a5@kernel.org> (raw)
In-Reply-To: <20170401140921.GA24486@singhal-Inspiron-5558>

On 01/04/17 15:09, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Applied.
> ---
>  drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> index ecf7721..125b5ff 100644
> --- a/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> +++ b/drivers/iio/common/ms_sensors/ms_sensors_i2c.c
> @@ -74,7 +74,7 @@ EXPORT_SYMBOL(ms_sensors_reset);
>  int ms_sensors_read_prom_word(void *cli, int cmd, u16 *word)
>  {
>  	int ret;
> -	struct i2c_client *client = (struct i2c_client *)cli;
> +	struct i2c_client *client = cli;
>  
>  	ret = i2c_smbus_read_word_swapped(client, cmd);
>  	if (ret < 0) {
> @@ -107,7 +107,7 @@ int ms_sensors_convert_and_read(void *cli, u8 conv, u8 rd,
>  {
>  	int ret;
>  	__be32 buf = 0;
> -	struct i2c_client *client = (struct i2c_client *)cli;
> +	struct i2c_client *client = cli;
>  
>  	/* Trigger conversion */
>  	ret = i2c_smbus_write_byte(client, conv);
> 

      reply	other threads:[~2017-04-02  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 14:09 [PATCH] iio: common: ms_sensors: Remove unnecessary cast on void pointer simran singhal
2017-04-02  8:48 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1db695c8-44ba-cd0a-bb19-e935725db1a5@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox