From: Haiyue Wang <haiyuewa@163.com>
To: David Wei <dw@davidwei.uk>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Simon Horman <horms@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] selftests: iou-zcrx: Clean up build warnings for error format
Date: Sat, 3 May 2025 16:29:53 +0800 [thread overview]
Message-ID: <1dcf5c8e-13c6-4969-90aa-a2b8d84050da@163.com> (raw)
In-Reply-To: <12ecd375-441d-440d-bb63-d83651cbb049@davidwei.uk>
On 2025/5/3 11:24, David Wei wrote:
> On 5/2/25 10:50, Haiyue Wang wrote:
>> Clean up two build warnings:
>>
>> [1]
>>
>> iou-zcrx.c: In function ‘process_recvzc’:
>> iou-zcrx.c:263:37: warning: too many arguments for format [-Wformat-
>> extra-args]
>> 263 | error(1, 0, "payload mismatch at ", i);
>> | ^~~~~~~~~~~~~~~~~~~~~~
>>
>> [2] Use "%zd" for ssize_t type as better
>>
>> iou-zcrx.c: In function ‘run_client’:
>> iou-zcrx.c:357:47: warning: format ‘%d’ expects argument of type
>> ‘int’, but argument 4 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=]
>> 357 | error(1, 0, "send(): %d", sent);
>> | ~^ ~~~~
>> | | |
>> | int ssize_t
>> {aka long int}
>> | %ld
>>
>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>
>> ---
>> v2:
>> - Dont't wrap the build warning message to make scripts/
>> checkpatch.pl happy,
>> keep it as for readability.
>> - Change the format for ssize_t from "%ld" to "%zd" as Simon
>> suggested.
>> - Change the target to net-next tree.
>> v1: https://lore.kernel.org/netdev/20250502042240.17371-1-
>> haiyuewa@163.com/
>
> Thanks for the cleanups. But next time please note that there is a 24h
> cooldown on respins in netdev.
Will take care next time. Thanks, David.
>
> Reviewed-by: David Wei <dw@davidwei.uk>
next prev parent reply other threads:[~2025-05-03 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 17:50 [PATCH net-next v2] selftests: iou-zcrx: Clean up build warnings for error format Haiyue Wang
2025-05-03 3:24 ` David Wei
2025-05-03 8:29 ` Haiyue Wang [this message]
2025-05-06 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcf5c8e-13c6-4969-90aa-a2b8d84050da@163.com \
--to=haiyuewa@163.com \
--cc=andrew+netdev@lunn.ch \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox