From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbdJSLf1 (ORCPT ); Thu, 19 Oct 2017 07:35:27 -0400 Received: from mout.web.de ([212.227.17.12]:61698 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdJSLfZ (ORCPT ); Thu, 19 Oct 2017 07:35:25 -0400 Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage() To: Joe Perches , kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org Cc: Jessica Yu , Rusty Russell , LKML References: <20171019110824.wqkep7bpcx3dcw5w@redbean> <43c71898-82c3-215a-3176-e1a6d56ef10a@users.sourceforge.net> <1508412567.6806.36.camel@perches.com> From: SF Markus Elfring Message-ID: <1dee801c-37b5-4d72-b33f-ebdc135b4f25@users.sourceforge.net> Date: Thu, 19 Oct 2017 13:35:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508412567.6806.36.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Fd5Ss5bJYeZnLGvA+IuQtYvlKsv4U/b1RL1/xO4rM6gZRr9ohNk KjRgR2qYBUpmo2HNyVkL5MQIeK4ZwMsg3z38DSNKOvtuNWisQoK9D/MtXa8eR8iAXNlnab9 s2wQusm68IvSI45R5XB1ol7h6Cbnj/lybIM39NFnf13emayKx0wDhBg7RzRCDuCICs2Eccp cWNqsxpNAoKwNfS32hvTQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:D0ChSXBtoVk=:eWBUFzGwK37atCR/uZ3sYY 3B8nen0voQJbD0oPKhy7g41W+BOUPvd9us1baCL5ImOZI7uMMS/0DFj1xmMvP+7uBxwhdwe+T K8DXvHioe5qwEnIxyAGEEsT3kAq2G63uLkPo1t2ru2Otb95yOX4IKf/oL575xSfAEqYh6YVY4 KKKVrJ6ljA4y1sJcwlWd7Mb+TFh0BqP3wMZhcL1ooLf+ymMENHinWWnME1d6E0ANhKyqhLqzo /qfre9C3634ElCJVSytjGwf2Piev3ziui3PDY2IcwT/ov49D8eu3uCTfVR19JV303q8OMBrjp 454FrpTYi+US3XkzR61wFvuFf/VUbeqjvyfft4CcIHJ/pzqOTPNvjOOJfRZcPZ0A4a62Cbhwy 7O6JFAMZJxVb8H29J4DXz5Fa+CGFR4b/BlpXeK6HVUg7YwBlLr7G6TKsl6i0RkRYggPpUZvvE ulm6p4zS0hup8V8TTEEvJr708dDhi0P+gEVcJXrnceSitEjNConimTNn6VUCYYDlnh6mnjKvT f7rUtqIWJG5gbw+liSpGPiT2hYrVl6MX3xIviFrfTd3AFSy9rVPjjlOHOnujyasJjtLsTkV9s JyS4/1JQxslEIfoiMGpe2KDFZG1pHOFB7o5MSUOaAUYuBe1/gISiDTdpTg56K5XeGpf/iTahy m7ctbXyTKp5MRM4GGycIB0CIW/mhClJNpoVVd6F9kjhtjk3+D/l0aVbUFgo1JDfvpbqpG5+82 UFQlc/1+BlZ15j7uOOwIA8EibUaLMnikUmqpoNoZrN5kpcpegOfnZYiFdvW04ffvxTVQ0h/Gp b/RQyOoSHXfsPky1ieOVAlcBwtT1tQ2ZDgGNX2iZdcURj3z4bI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> Omit an extra message for a memory allocation failure in this function. >>>> >>>> This issue was detected by using the Coccinelle software. >>>> >>>> Signed-off-by: Markus Elfring >>> >>> Applied to modules-next, thanks. >> >> Thanks for your acceptance of this update suggestion after a bit of clarification. >> >> Do you see any need that I should extend subsequent commit messages >> for this software transformation pattern? > > Add a description of _why_ this is being done. > > Something like: > > "because there is a dump_stack() done on allocation failures > without __GFP_JNOWARN" How do you think about to convert such a description into a special format for further reference documentation? Regards, Markus