linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Bandan Das <bsd@redhat.com>, kvm <kvm@vger.kernel.org>,
	guangrong.xiao@linux.intel.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] mmu: don't set the present bit unconditionally
Date: Tue, 5 Jul 2016 12:50:50 +0200	[thread overview]
Message-ID: <1dfa91d7-a9e7-4fb1-c04e-3431b387c6fd@redhat.com> (raw)
In-Reply-To: <CANRm+CzkiE-ZbuMJEHR8orS68vh81w+KFtRr33ug2kaDADWWeg@mail.gmail.com>



On 05/07/2016 07:50, Wanpeng Li wrote:
>> > This needs a comment:
>> >
>> >         /*
>> >          * There are two cases in which execonly is false: 1) for
>> >          * non-EPT page tables, in which case we need to set the
>> >          * P bit; 2) for EPT page tables where an X-- page table
> In the scenario of non-EPT shadow page table and non-nested, the
> present bit can't be set any more since
> context->guest_rsvd_check.bad_mt_xwr is always 0.

This will be fixed with a new shadow_present_mask variable.

Paolo

  reply	other threads:[~2016-07-05 10:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  4:32 [PATCH 0/5] Add support for EPT execute only for nested hypervisors Bandan Das
2016-06-28  4:32 ` [PATCH 1/5] mmu: mark spte present if the x bit is set Bandan Das
2016-06-28  8:44   ` Paolo Bonzini
2016-06-28 17:33     ` Bandan Das
2016-06-28 20:17       ` Paolo Bonzini
2016-06-28 20:37         ` Bandan Das
2016-06-28 20:49           ` Paolo Bonzini
2016-06-28 21:04             ` Bandan Das
2016-06-29  3:01             ` Xiao Guangrong
2016-07-05  3:06             ` Wanpeng Li
2016-07-05 10:50               ` Paolo Bonzini
2016-07-05 11:29                 ` Wanpeng Li
2016-06-28  4:32 ` [PATCH 2/5] mmu: pass execonly value when initializing rsvd bits Bandan Das
2016-06-29  3:07   ` Xiao Guangrong
2016-06-28  4:32 ` [PATCH 3/5] mmu: don't set the present bit unconditionally Bandan Das
2016-06-28  8:57   ` Paolo Bonzini
2016-06-28 17:30     ` Bandan Das
2016-06-28 20:21       ` Paolo Bonzini
2016-07-05  5:50     ` Wanpeng Li
2016-07-05 10:50       ` Paolo Bonzini [this message]
2016-06-29  3:17   ` Xiao Guangrong
2016-06-29  8:18     ` Paolo Bonzini
2016-06-30  7:18       ` Xiao Guangrong
2016-06-28  4:32 ` [PATCH 4/5] mmu: remove is_present_gpte() Bandan Das
2016-06-28  4:32 ` [PATCH 5/5] nvmx: advertise support for ept execute only Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dfa91d7-a9e7-4fb1-c04e-3431b387c6fd@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bsd@redhat.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).