From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbcGEKu4 (ORCPT ); Tue, 5 Jul 2016 06:50:56 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37415 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcGEKuy (ORCPT ); Tue, 5 Jul 2016 06:50:54 -0400 Subject: Re: [PATCH 3/5] mmu: don't set the present bit unconditionally To: Wanpeng Li References: <1467088360-10186-1-git-send-email-bsd@redhat.com> <1467088360-10186-4-git-send-email-bsd@redhat.com> <60e083e8-596a-5641-fcb9-ede8bce32b58@redhat.com> Cc: Bandan Das , kvm , guangrong.xiao@linux.intel.com, "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <1dfa91d7-a9e7-4fb1-c04e-3431b387c6fd@redhat.com> Date: Tue, 5 Jul 2016 12:50:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2016 07:50, Wanpeng Li wrote: >> > This needs a comment: >> > >> > /* >> > * There are two cases in which execonly is false: 1) for >> > * non-EPT page tables, in which case we need to set the >> > * P bit; 2) for EPT page tables where an X-- page table > In the scenario of non-EPT shadow page table and non-nested, the > present bit can't be set any more since > context->guest_rsvd_check.bad_mt_xwr is always 0. This will be fixed with a new shadow_present_mask variable. Paolo