[PATCH v4 2/3] PCI/AER: Print UNCOR_STATUS bits that might be ANFE

Zhenzhong Duan
2024-05-09T08:51:39Z

When an Advisory Non-Fatal error(ANFE) triggers, both correctable error(CE)
status and ANFE related uncorrectable error(UE) status will be printed:

AER: Correctable error message received from 0000:b7:02.0
PCIe Bus Error: severity=Correctable, type=Transaction Layer, (Receiver ID)
device [8086:0db0] error status/mask=00002000/00000000
[13] NonFatalErr
Uncorrectable errors that may cause Advisory Non-Fatal:
[18] TLP

Tested-by: Yudong Wang <yudong.wang@intel.com>
Co-developed-by: "Wang, Qingshun" <qingshun.wang@linux.intel.com>
Signed-off-by: "Wang, Qingshun" <qingshun.wang@linux.intel.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
drivers/pci/pcie/aer.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index f2839b51321a..ed435f09ac27 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -681,6 +681,7 @@ static void __aer_print_error(struct pci_dev *dev,
{
const char **strings;
unsigned long status = info->status & ~info->mask;
+ unsigned long anfe_status = info->anfe_status;
const char *level, *errmsg;
int i;

@@ -701,6 +702,20 @@ static void __aer_print_error(struct pci_dev *dev,
info->first_error == i ? " (First)" : "");
}
pci_dev_aer_stats_incr(dev, info);
+
+ if (!anfe_status)
+ return;
+
+ strings = aer_uncorrectable_error_string;
+ pci_printk(level, dev, "Uncorrectable errors that may cause Advisory Non-Fatal:\n");
+
+ for_each_set_bit(i, &anfe_status, 32) {
+ errmsg = strings[i];
+ if (!errmsg)
+ errmsg = "Unknown Error Bit";
+
+ pci_printk(level, dev, " [%2d] %s\n", i, errmsg);
+ }
}

void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
--
2.34.1