From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFE02581 for ; Sun, 14 Dec 2025 00:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765670698; cv=none; b=g2isnO1SR9nw7C2ibVV+hrOvV0LQtTMUlm7Xv+6bApbOTJsGo9Y7oMvu3wPVZW/SB7aLpUWu2rdJ58wn9fGHSbKr2xCcV5DUeCoJenuzayQzsD6uzZTz1ADV9i0C3At5Qskn8pVDLz3sEEdgkqVJ1HA+J0cpcWJ9wUkOhTF2+58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765670698; c=relaxed/simple; bh=+zQAz+Rb/94sTj+jzifGC0Wl/VBMTW3fTEGmfxduBUk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ECoO7FD8wfkpT5skG/QQscDJ+8u57FRhoHjbhjziQznFRVXBFKG1Z1XDMaKkU/eOzzsd5GYFXdUd+LGsWde313pKN3jh8wQGlzx9JRD1LEiw3jr1YQ/S0qrmu3Px257vhhdy3kkpi0+MJmioL0kYIPmefLayEseUMkf2GgR1gk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iNoA/bek; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iNoA/bek" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-37e8892d4e0so2435551fa.1 for ; Sat, 13 Dec 2025 16:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765670695; x=1766275495; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5BgboonVbxKrO9X8kRKN4BUW9psx0IkF2ipu6x5mfes=; b=iNoA/bekPHTxP1q3Nr2OzNojY8sy6H/d8k9YHmSPWix9gHriFGPYgqcX23fodFeet1 OgIpuxYVeYK/hzPB6YQyyDCOJrMAQZqgwp1YvLu/43oq4+oe1ABoBMWzrLfh2b7/Kww6 rOsiw9yETELqkwFxZfk2PCw63/W4ciQNm9HO5ckuLLz6CSc/iNyOG8+HVK+2gbZB2U3Y ORxlAn+cjwaDRICR/8cI7neCFXdXEqlv7PTFjiwNczwqAJVkJBkS7AsgbrCXZNx3fUrK 7SfXVedYW2/KctJKCc5MO1T8+N+z/79T4IGVcznJ3dzYhupRzqoMJ/zX7HjXlv+B9oc3 HpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765670695; x=1766275495; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5BgboonVbxKrO9X8kRKN4BUW9psx0IkF2ipu6x5mfes=; b=Bl8r0wFGMYtYyNYtoxll7fBAP1z9673oxvCnkH76olS9vDtkRM6al2+LiW2UQxYOsn 1+AZTbk3opaN/3VfVZJ+VYQs0VzSctYH+pITmd0mhagZiiM9yriT0Q5FyQEPk5rbaVl9 H05wPzATe7mNqRVX4phLeBxll/zf33X83lpTMdctA6KW4UxY+fhKBUj9Oghe/vcX1K4x hACwFvkI+yWF9/0YEnzHBwr9vrucUhpr4smwjTXJCgJS6kZfjojFhcsWuosR83sxvsRR Yv1F+frzZvPwrePGYfN4Ghw706VDeK026FTlR8iU9/Dqqk7hhjkG7hyc7SCb+0ud1OhN nu3g== X-Forwarded-Encrypted: i=1; AJvYcCUF7HPtFgWTBVpBABL3gS6QCBJxH3EatjBbKYlbdqFTH5POxw2SQYq/pVkxqDqi8hf5Ro2f8bNx3McMOqU=@vger.kernel.org X-Gm-Message-State: AOJu0YxJwZV31hmsofry4Kc5jE5pjK9q4GpBGEojE5B0LP4yzNGlLxjM Wss8sw8EuD6K105sHm2Aj7Q95lcWp4AQhOUiMuJwiSuErMhBZesOYReHRZhbXQp1xOo= X-Gm-Gg: AY/fxX71mcwjtYiaQuQQ9fwO/Xmf712jr/bSNEDNVjewzzL/F65AfeENPPR+jBSNJDb Xd4L41nRAe+6HLbFN4OQNtERw+ExFkBbnY2bbj8HmEQEGDhSbGgXwXd5dHtozUnTk4822erXSDq zhOzVZO1VdlSm9tRh3RZrC67gj9Qea3Ojee9cR9khSdlPZN1x+jXuTYKTht1hNfblpDW7tbkyBl 5TLe2PiLytpOH7HgoshDFhKOWah9xUyG7NSfgO1srK7AFF9tiXitfgQIZuFEzpWqHvP+RpleN7U 89k7/VtJHO4VJe2myDuyoDJq5nTBRpQsEj6qg4wdyBlFZhE/mKPMpKUgX7H4sMMBqIWUQXSVEDs /TU9HyNiTpySkDH7wkiwQnqeVTT5Pg4HhRX55/OJUB4umta8W8W1AegqIBrLXgQKfxuCs7laUWX cfjcncp/7+DmCAsZdSrJ7HJ5jL9FtozZWx2mmhpYh8hjTEe5OckddDYAeOAktFn0IeVC9JrrPqd LsI X-Google-Smtp-Source: AGHT+IG0gHywQrxKrfUQzEHRspDDk2UVqLJp4GZHTOJ02LFhlHAWCfdGIvRgbfMc4gVJJKA+2cbEpg== X-Received: by 2002:a05:6512:b98:b0:594:93b8:88a0 with SMTP id 2adb3069b0e04-598faa8dc1fmr1251168e87.6.1765670694934; Sat, 13 Dec 2025 16:04:54 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-598f3195e52sm3425805e87.84.2025.12.13.16.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Dec 2025 16:04:53 -0800 (PST) Message-ID: <1e09a93a-d42f-4a23-b346-9f158a60d8aa@linaro.org> Date: Sun, 14 Dec 2025 02:04:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: dt-bindings: Correct camss VDDA PLL supply description To: david@ixit.cz, Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vikram Sharma , Kapatrala Syed , Hariram Purushothaman , Richard Acayan Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz> From: Vladimir Zapolskiy In-Reply-To: <20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/25 00:55, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of > voltage from the description. > > Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845") > Signed-off-by: David Heidelberg > --- > Added only Fixes tag for the initial commit, not all the copy-paste > propagated ones. Generally it should be possible to specify a list of Fixes: tags. However, despite the change is the proper one, there is an opinion that Fixes tags are not applicable to dt bindings with a given reason that only executed code can be fixed. So you may be asked to remove even a single Fixes tag. > Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml | 2 +- > Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml | 2 +- > Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +- > Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml | 2 +- > Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +- > Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > index 019caa2b09c32..9009cfe993d75 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > @@ -130,7 +130,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > ports: > $ref: /schemas/graph.yaml#/properties/ports > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > index ee35e3bc97ffd..cb922f90fe900 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > @@ -129,7 +129,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > ports: > $ref: /schemas/graph.yaml#/properties/ports > diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > index c99fe4106eee9..2231d7216f62a 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > @@ -268,7 +268,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > required: > - clock-names > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml > index 35c40fe223767..8e6ca94c88695 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml > @@ -95,7 +95,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > ports: > $ref: /schemas/graph.yaml#/properties/ports > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > index 82bf4689d3300..d50e096b900db 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml > @@ -211,7 +211,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > required: > - clock-names > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > index ebf68ff4ab961..ccd2d024bfd10 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > @@ -300,7 +300,7 @@ properties: > > vdda-pll-supply: > description: > - Phandle to 1.8V regulator supply to PHY refclk pll block. > + Phandle to regulator supply to PHY refclk pll block. > > required: > - clock-names > As for the change itself it is good, I'd prefer to get a correction to 1.2V in the documentation rather than a complete removal though. In any case, Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir