From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4EC357A31 for ; Fri, 30 Jan 2026 17:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769795452; cv=none; b=hPsptxvFxLkcs1S5uY6TwYHfAdoTZPzo9Z1sd7Xdsc6py8vHa6bRcrm2iiLMblFcjZJ9IHr1v1NivyyvxsxCt2HWrJhsGfBQCNtyoXvjH7HZCE+w47oZGgNqewz8lmLnGQxh9k+EYEpd0OCk7nJ2+64paWeNkAxl09lUseXFlSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769795452; c=relaxed/simple; bh=vvaTCzXJ9V5mfgWbMCl8iE4gm3vkaKZjN4OAKmUIhoM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMeB/dfqYL6oEtFARTD6I6Td6nqfiG/1taD6Re8IWJP+kTwPWK3Y8qLm0vKMl6f9Kl3K3F6D5FBLq3IKeoogUVksfSuDAo5sdFUGV/tARA9EVXJaR1aJehVWMcBrhgtkSFwgiCz1EZmZZusHUJGlLm8wBAGjzDyq/eZE+e7A56Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nkeqsev0; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nkeqsev0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769795451; x=1801331451; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vvaTCzXJ9V5mfgWbMCl8iE4gm3vkaKZjN4OAKmUIhoM=; b=nkeqsev0bLebkp3Dze/da1z3E+mSoqElH2ClMsBwcysG9psN9TtIW9m1 9ZIIDYnyIjKvjzasSB72DKFq8GhNbJOGQsyp7IItGqCUlezYvRSGpPsGm Q7mMkRQz6QhUCW4HWy9SW2jmad+7tvKiEhe8YVchl89VPrYrNl04Tf+wz R+ijnB6kbdHDiVWFd24OF+KmKcw/MPlZohfhUVWTFlbcX+F0v8w4L8fZN PXtHoYED9qbSbr8h3SLJQUGY3bFc7L1jJVloCms90Wlb4Za0nLkMFLrd+ f5835ScYtISohL/IVFHG62qt+xw7zwORVvbEfYh+ui6MEpW+GN91EIWKo Q==; X-CSE-ConnectionGUID: bIBhXmYDSU2WQdCkvp3QZQ== X-CSE-MsgGUID: XDxSZch5Ro2+xrrkbzNwjw== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="71214123" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="71214123" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 09:50:50 -0800 X-CSE-ConnectionGUID: OQvW1dI0SWq7EyMDU3NFfQ== X-CSE-MsgGUID: 8SEnrDhjTV6POCL2AzriLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="209152725" Received: from cjhill-mobl.amr.corp.intel.com (HELO [10.125.110.58]) ([10.125.110.58]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 09:50:48 -0800 Message-ID: <1e142e20-e3b8-4bc7-9d92-c3001b11a5fb@intel.com> Date: Fri, 30 Jan 2026 09:50:48 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] x86/cpu/intel: Add implicit RFDS mitigation for Goldmont and Tremont-D To: Joongsun Moon-Lee , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Cc: "H . Peter Anvin" , Peter Zijlstra , Pawan Gupta , Josh Poimboeuf , linux-kernel@vger.kernel.org References: <20260129154342.3867-1-moontorise@cfg.kr> <20260130123340.1544-1-moontorise@cfg.kr> <20260130123340.1544-3-moontorise@cfg.kr> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20260130123340.1544-3-moontorise@cfg.kr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/30/26 04:33, Joongsun Moon-Lee wrote: ... > Force X86_FEATURE_RFDS_CLEAR for these models in init_intel() to enable > the mitigation automatically. For Tremont-D, limit the quirk to stepping 7, > as stepping 5 does not support mitigation according to Intel's guidance [1]. Thank $DEITY for the CSV: > https://github.com/intel/Intel-affected-processor-list/blob/main/Intel_affected_processor_list.csv $ csvtool namedcol "CPUID Family_Model,Stepping,MCU Update,Register File Data Sampling (RFDS) (Floating Point/Integer / Single Instruction/Multiple Data) - CVE-2023-28746 - INTEL-SA-00898" Intel_affected_processor_list.csv \ | egrep '^06_86H|06_5CH' Yields: 06_5CH,A,0x28, MCU+Software 06_86H,5,0x4c000026,No planned mitigation 06_86H,7,0x4c000026,MCU+Software Which is actually readable, unlike the HTML table. But, honestly, other than the table saying "MCU+Software", I don't see any indication that VERW does what you want it to do on these CPUs. Intel's guidance[1] only says: ... software should only apply the VERW mitigations as an RFDS mitigation if RFDS_CLEAR is enumerated. So I think you're going _entirely_ on the "MCU+Software" in the table/csv above. Is there anything else? It sounds like you haven't actually tested in VERW does what you want it to. > +/* > + * These CPUs mitigate RFDS via VERW but do not enumerate the RFDS_CLEAR bit > + * in IA32_ARCH_CAPABILITIES MSR. > + */ > +static const struct x86_cpu_id implicit_rfds_list[] = { > + X86_MATCH_VFM(INTEL_ATOM_GOLDMONT, 0), > + X86_MATCH_VFM_STEPS(INTEL_ATOM_TREMONT_D, 7, 7, 0), > + {}, > +}; Please make this look like all the other lists and make an attempt to vertically align things. 1. https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/register-file-data-sampling.html