Re: [PATCH net-next v4 02/15] net: dsa: vsc73xx: convert to PHYLINK

Florian Fainelli
2024-02-13T23:19:38Z

On 2/13/24 14:03, Pawel Dembicki wrote:
> This patch replaces the adjust_link api with the phylink apis that provide
> equivalent functionality.
>
> The remaining functionality from the adjust_link is now covered in the
> phylink_mac_link_* and phylink_mac_config.
>
> Removes:
> .adjust_link
> Adds:
> .phylink_mac_config
> .phylink_mac_link_up
> .phylink_mac_link_down

The implementation of phylink_mac_link_down() strictly mimics what had
been done by adjust_link() in the phydev->link == 0 case, but it really
makes me wonder whether some bits do not logically belong to
phylink_mac_link_up(), like "Accept packets again" for instance.

Are we certain there was not an assumption before that we would get
adjust_link() called first with phydev->link = 0, and then phydev->link
=1 and that this specific sequence would program things just the way we
want?
--
Florian