From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EFDE39B970 for ; Fri, 10 Jul 2026 08:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671024; cv=none; b=q3P9coBQCBxA6s2Z2EGXj0A1+4aHn9gSI1DEuBYsAfiL9CQxpaZ0RnK0dUVRUoRrG9n5C7TU+dkRrrIExE49h7FCKc7geGQewXHCuEBo+DbXEHEGzhgW/7ynCrz4K+WyI/2kR1DRUxpfgGWPdFZ1e5tkU4Lv6fcDmY9F6dDno/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783671024; c=relaxed/simple; bh=TYmwlF0/zWoMcq+0F9hfD02z0clAaQMpdmpDnz0NFng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P7dduWXEdBzK9DgBjAIc/MkqWySfDH3bvaJ6rbsFJpG/OJdEaOF+JyyCBmB31uC9BAo/t41o+iMgD09gvMwKWcT7Akb9BnIQ6omH+48VgmCmi0PBFOsxeYY/Fjr48F6JC3gmv9kf3gS5/x2Q4HnL9/ssUhtGERd+Yx5UwcCCNEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=hPIU5oua; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="hPIU5oua" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7mJmd4024913; Fri, 10 Jul 2026 08:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=AHDsFM i/TGo1n41jN1GI2sFJMmRgrR171764xb7VuCw=; b=hPIU5oua6yBQruSoKuY9Xf Zd3cGijNN5z9cpPSwM3SgVuK3TfyTtGA3ipXvE6XIb9AReJL5h1jmX2pUnioz3+g bHefVLVcQ/R7StpScHQgBDdCakblaDHce0ebkLOyg/ZJGLGc8ERi2YFTupvkdcrD CCreVMI8skFxaCcYh01qRtgS5FdWZ1da2Yo7owdySiWInZU0GvQ91ELrH8GIqzYo O/gdFhA6l57kIFHkJTvvn8GbEFL2ZVYpkBXZDioIKdRQzd4Am3Ax7DXYpIkHDYJr CSVCheGBV2gGagqHmWQQPmLWmNa9wlI2+CHJdivDyXaRGEILHkDqN8p1NfTVv7cg == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6rke5xpd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 08:10:04 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66A84jKw008259; Fri, 10 Jul 2026 08:10:03 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7eqggv8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 08:10:03 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66A8A0na22479426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jul 2026 08:10:00 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C85DF58062; Fri, 10 Jul 2026 08:10:00 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91F575805E; Fri, 10 Jul 2026 08:09:57 +0000 (GMT) Received: from [9.43.90.92] (unknown [9.43.90.92]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Jul 2026 08:09:57 +0000 (GMT) Message-ID: <1e72d8d2-ecfb-42c8-9ba4-97cf70f8b70b@linux.ibm.com> Date: Fri, 10 Jul 2026 13:39:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/18] list: Permit context-unguarded access with list_empty_careful() To: Christoph Hellwig , Marco Elver Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com References: <20260706141452.3008233-1-nilay@linux.ibm.com> <20260706141452.3008233-15-nilay@linux.ibm.com> <20260709063020.GC18056@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20260709063020.GC18056@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=M7J97Sws c=1 sm=1 tr=0 ts=6a50a8dc cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=1XWaLZrsAAAA:8 a=x7wxYoYxGjGoRpqTYEQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA3NCBTYWx0ZWRfXx4hBz9tNFLxj aznqZGnkNINZclQXgTb7gLSdpvcc6BdJ9QgdCcd4wksoihojhUlHcs4hVNqCwksII4g0L2AKt6X D0KIuIr+KOtwVXzsNeDLJ/o0e3/IsKVfVdtGzfBqre/hgIbHkP8BaULsmOVIlvRxVI2mp/z9WqL mzLZN2qhjbnvAMXrU5FRsKRSqQ+n9tzRR3JuubmzAzklXR3CBF1KTsPlPuYIW5nLV8yTXXJUKgc l5brru29EMn/JbPk9MoMgA5iSxD72cEGg1qWxhDPX6/X8R7OCwFphWMa/vNaiGxWajHt420g9QI 6R5LJmAMDCFGL2y6rCu2UMYf4fe93aqvgGhg30VMAq2+6KuHZj3TrqPEln/2wQo5Vv1k76Pt7Gn B/P3fBSLhVJKOD16uD73a8EmcbsEFMOCx2C0Ck6cSJNvUZmX4P8T+F96sjTzv/2/v7ppgSSavEJ /nE3z2QdJXhrGDIKwTw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA3NCBTYWx0ZWRfX4A4vqXu+2qpG F6i865eOl0YuajISeUFhf1af0C1mIu4GAWQalPjh3/q2R3TkSBpCGzAHVcbk4C6WNxihs6kDUMD +JF7e3h+E05MVV4fDZn+My2BaLR02yI= X-Proofpoint-GUID: uc_WQRERGeJxbc8ensrKpUfVdtxFEloy X-Proofpoint-ORIG-GUID: 54v5Di_ezg29vN3KkPnvG2giajRKTjT2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100074 Hi Marco, On 7/9/26 12:00 PM, Christoph Hellwig wrote: > On Mon, Jul 06, 2026 at 07:44:16PM +0530, Nilay Shroff wrote: >> From: Marco Elver >> >> With Context Analysis (viz. Clang's Thread Safety Analysis), list_heads >> that are __guarded_by(..) require holding the appropriate context lock >> when accessing and manipulating them via the list API. Because Clang's >> warning diagnostics do not perform inter-procedural analysis, this is >> enforced by Clang with -Wthread-safety-pointer in the caller at the call >> boundary; a warning is produced when passing a pointer to a guarded >> variable without holding the appropriate context locks: > > Same thing here, maybe try to get this to Linus late in the current > window as it's trivial and makes dependency management much easier. > > If that doesn't work, move it to the front of the series. > Would it be possible for you to send a pull request for Linus directly, or would it need to go through another maintainer? If you're able to send it directly, we also have patch 09/18 in this series that should go to Linus. In that case, I'd suggest including both patches in the same pull request. Otherwise, as Christoph suggested, I'll move these patches to the beginning of the series in the next revision. Thanks, --Nilay