From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, pavel@kernel.org,
sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com,
laurent.pinchart@ideasonboard.com, hverkuil+cisco@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema
Date: Thu, 25 Dec 2025 09:37:16 +0100 [thread overview]
Message-ID: <1e8ec6ac-91e2-411c-8ca5-562b48443be6@kernel.org> (raw)
In-Reply-To: <CA+hkOd4B425PRzirxLW-J2L+mDGusfRDJ5y1nKLwG9a-dd4M8A@mail.gmail.com>
On 24/12/2025 22:07, Alex Tran wrote:
>>> + maxItems: 1
>>> +
>>> + reset-gpios:
>>> + description:
>>> + XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
>>> + is in hardware standby mode when the signal is in the low state.
>>> + maxItems: 1
>>> +
>>> + flash-leds:
>>> + $ref: /schemas/media/video-interfaces.yaml#
>>
>> This and...
>>
>>> +
>>> + lens-focus:
>>> + $ref: /schemas/media/video-interfaces.yaml#
>>
>> ... this are weird. LEDs are not video interfaces, for sure. lens focus
>> shouldn't be video interface, either.
>>
>> You also miss unevaluatedProps there.
>>
>> This needs careful fixing/rewriting, with explanation in commit msg.
>>
>
> My mistake. The correct schema reference for these 2 should be video
> interface devices.
No. LEDs are not video interface devices, either. LEDs are LEDs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-25 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 22:03 [PATCH v1 0/2] media: dt-bindings: Convert toshiba,et8ek8 and ti,omap3isp to YAML schema Alex Tran
2025-12-20 22:03 ` [PATCH v1 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema Alex Tran
2025-12-21 15:05 ` Krzysztof Kozlowski
2025-12-24 21:07 ` Alex Tran
2025-12-25 8:37 ` Krzysztof Kozlowski [this message]
2025-12-20 22:03 ` [PATCH v1 2/2] media: dt-bindings: ti,omap3isp: " Alex Tran
2025-12-21 15:08 ` Krzysztof Kozlowski
2025-12-24 21:46 ` Alex Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8ec6ac-91e2-411c-8ca5-562b48443be6@kernel.org \
--to=krzk@kernel.org \
--cc=alex.t.tran@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox