From: Walker Chen <walker.chen@starfivetech.com>
To: Mark Brown <broonie@kernel.org>
Cc: Claudiu Beznea <Claudiu.Beznea@microchip.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] ASoC: starfive: Cleanup and fix error check for JH7110 TDM
Date: Thu, 8 Jun 2023 20:17:02 +0800 [thread overview]
Message-ID: <1eab400c-b568-3042-ebb6-e8244dee0149@starfivetech.com> (raw)
In-Reply-To: <c974d0c7-b091-4d5c-b73c-1b6584eb823a@sirena.org.uk>
On 2023/6/8 18:50, Mark Brown wrote:
> On Thu, Jun 08, 2023 at 06:43:09PM +0800, Walker Chen wrote:
>> On 2023/6/8 18:15, Mark Brown wrote:
>
>> > I can't find the comments you're referring to in there.
>
>> You should see the following comments in the link above:
>
>> > + #define CLKPOL_BIT 5
>> > + #define TRITXEN_BIT 4
>> > + #define ELM_BIT 3
>> > + #define SYNCM_BIT 2
>> > + #define MS_BIT 1
>
>> Instead of these *_BIT defines as plain numbers you can defined them using
>> BIT() macro and use macros in place instead of
>
> The usual pattern is to have defines for both the shift and the mask,
> not just one.
OK, I see. It's not necessary to make these changes.
Thanks.
Best regards,
Walker
next prev parent reply other threads:[~2023-06-08 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:14 [PATCH v1] ASoC: starfive: Cleanup and fix error check for JH7110 TDM Walker Chen
2023-06-07 11:44 ` Mark Brown
2023-06-08 2:15 ` Walker Chen
2023-06-08 10:15 ` Mark Brown
2023-06-08 10:43 ` Walker Chen
2023-06-08 10:50 ` Mark Brown
2023-06-08 12:17 ` Walker Chen [this message]
2023-06-09 7:50 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eab400c-b568-3042-ebb6-e8244dee0149@starfivetech.com \
--to=walker.chen@starfivetech.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox