From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbdHUU6B (ORCPT ); Mon, 21 Aug 2017 16:58:01 -0400 Received: from mout.web.de ([212.227.15.3]:64622 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753680AbdHUU6A (ORCPT ); Mon, 21 Aug 2017 16:58:00 -0400 Subject: [PATCH 4/4] w1-masters: Improve a size determination in four functions From: SF Markus Elfring To: "Andrew F. Davis" , Christophe Jaillet , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Evgeniy Polyakov , "Maciej S. Szmigiero" , Sebastian Reichel , Wei Yongjun Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <1ed286dc-aa2f-8b84-e0d5-ed2f43faaa27@users.sourceforge.net> Date: Mon, 21 Aug 2017 22:57:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:DPHtWmXJch9l6tiBXbtahfZ+aa0/NxhcQFnBEVi55w8Sfv5PP36 Ew3itJTqYJ9RKznCB93LKpMzaEsdmyEHkTHPkKBcV1KMp4tyICyzdrF3F1d8qVjtoBoYgKY Ki6bOiAI/3w72goCVfvWq1ytRXV73ec7PvJEKguRSkev91Z2iXefiV9UUj5GxTW/y4ldZDP ZkVQkiJnCx+3ci8Eq8kQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:33E261rMkBI=:R66ParZqo+rMwMLXcT0YC2 g9tptgOPZkqOv9cP3XEBgirE1JOPVvanmUyFiOHvNvtJqQ55coWIZwRQBdBR+uN/CE5EdFOj+ Cjmgzj9y1gL+Oq3Z6aaqOMB4Wnr5YjwF+La1FC4gprFisAPHV8zc5CfP4uVPndrpEfp08dV3d orOjGo6aFdGbti9YQlGKo+FT15RTfc83vzQUe62/K6nsDFLUcm5dvtoMnpFfuLQjipdxbKUM+ Bx/KQXYR7SKwjD8/tbb3EzN7lKsOJHBy921qCXp+dGBrObmd+Hom29wsWkvmrMXqLFbbBxvd0 PhqMVA3v17Y/GHP7q8TPVy6ri3BFljXKSjQiYWjJp0EvmJVbi6R4fkw2JPjnVWGtqyZjlblQi 1euNkVw5Yy5em7q2iq+lyZJjNlQm45HWODkL93mjo/FBTp6jbG6X3vTGXe9cU7IBw09KSENd8 AuOnfsxCsrlASF+fGSx/kN632hw/rxS9uPorSpDYQQUQJ6N6uomSAPA5RVGqTEdBQJNa4Z5cT H9zRx8NiVeMBNByPl06jgtBDbaU6cphuCSctdBdq+uFfnJyi5HBEtFxGv6tYB8+ONBlZSFZr0 3EPZSHhOSaQD4oae0MnoWI8L6fjPv21/V8Y1lBjd4a/tLHVVGgdgykGw1wtt0tTOXxpBwQ5ra l1NbfpuiotvX+fgO/gGHfc+QUvxBQvp/Mwh+1efVPpVvw76z23sd4juvZE+pLuWocqW1x5n0V 39INUDrd2YACLwOeXhtOlbIFhtWPGdHvQfsxRvyVcLXnlc0ec7n5vaeLYjC5d091+iR29edhu qm90aNwOCe48tLXbzBniguXtmS4OtjWvEeiH1Xgb0s/SmiMUbJfbeSSRdgp6tXEgwFi5T/J Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 21 Aug 2017 21:53:21 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/w1/masters/ds2482.c | 3 ++- drivers/w1/masters/ds2490.c | 2 +- drivers/w1/masters/mxc_w1.c | 3 +-- drivers/w1/masters/w1-gpio.c | 3 +-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index d49681cd29af..7c3e25108285 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -451,7 +451,8 @@ static int ds2482_probe(struct i2c_client *client, I2C_FUNC_SMBUS_BYTE)) return -ENODEV; - if (!(data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL))) { + data = kzalloc(sizeof(*data), GFP_KERNEL); + if (!data) { err = -ENOMEM; goto exit; } diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c index c0ee6ca9ce93..1e5b81490ffe 100644 --- a/drivers/w1/masters/ds2490.c +++ b/drivers/w1/masters/ds2490.c @@ -994,5 +994,5 @@ static int ds_probe(struct usb_interface *intf, struct ds_device *dev; int i, err, alt; - dev = kzalloc(sizeof(struct ds_device), GFP_KERNEL); + dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (!dev) diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c index 74f2e6e6202a..40a34942d07f 100644 --- a/drivers/w1/masters/mxc_w1.c +++ b/drivers/w1/masters/mxc_w1.c @@ -103,6 +103,5 @@ static int mxc_w1_probe(struct platform_device *pdev) unsigned int clkdiv; int err; - mdev = devm_kzalloc(&pdev->dev, sizeof(struct mxc_w1_device), - GFP_KERNEL); + mdev = devm_kzalloc(&pdev->dev, sizeof(*mdev), GFP_KERNEL); if (!mdev) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index 6e8b18bf9fb1..a92eb1407f0f 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1/masters/w1-gpio.c @@ -128,6 +128,5 @@ static int w1_gpio_probe(struct platform_device *pdev) return -ENXIO; } - master = devm_kzalloc(&pdev->dev, sizeof(struct w1_bus_master), - GFP_KERNEL); + master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL); if (!master) -- 2.14.0