From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>, Greg KH <greg@kroah.com>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, eranian@google.com,
namhyung@kernel.org, acme@kernel.org, jolsa@redhat.com
Subject: Re: [PATCH 2/7] perf: Create a symlink for a PMU
Date: Fri, 25 Jun 2021 12:18:28 -0400 [thread overview]
Message-ID: <1edc6666-c4b3-ebf5-964a-e5ffc97d8563@linux.intel.com> (raw)
In-Reply-To: <82fe02c8-2ac6-fc53-490c-382df3e07dc4@linux.intel.com>
On 6/25/2021 11:57 AM, Liang, Kan wrote:
>
>
> On 6/25/2021 11:44 AM, Andi Kleen wrote:
>>
>>> We have an attribute "caps/pmu_name" for the core PMU. Maybe we
>>> should add it for uncore PMU as well. For example,
>>>
>>> $ cat /sys/devices/uncore_type_0_0/caps/pmu_name
>>> cha_0
>>>
>>> Userspace tool can get clues about what type_0_0 is.
>>
>> It would break all the old tools, but I suppose it could work for
>> updated tools.
>>
>
> Right, users have to update their perf tool to use the new name,
> uncore_cha_0.
I think the above example is misleading. Let me rephrase.
Here is what I'm planing to do in V2.
With the V2 platform-specific patch, uncore driver will only create a
meaningful uncore name, e.g., uncore_cha_0.
An attribute "caps/pmu_name" is also created to indicate the previous
name. For example,
$ cat /sys/devices/uncore_cha_0/caps/pmu_name
type_0_0
If any users use the old numeric name, they have to update either their
script or a perf tool which supports "caps/pmu_name".
In the future, if the users already use a perf tool which supports
"caps/pmu_name", nothing needs to be updated. The old numeric name
should just work.
Thanks,
Kan
next prev parent reply other threads:[~2021-06-25 16:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 1:22 [PATCH 0/7] perf: Add Sapphire Rapids server uncore support kan.liang
2021-06-24 1:22 ` [PATCH 1/7] driver core: Add a way to get to bus devices kset kan.liang
2021-06-24 5:41 ` Greg KH
2021-06-24 1:22 ` [PATCH 2/7] perf: Create a symlink for a PMU kan.liang
2021-06-24 5:48 ` Greg KH
2021-06-24 14:24 ` Andi Kleen
2021-06-24 14:29 ` Greg KH
2021-06-24 15:24 ` Andi Kleen
2021-06-24 15:31 ` Greg KH
2021-06-24 17:07 ` Liang, Kan
2021-06-24 17:35 ` Greg KH
2021-06-24 17:49 ` Andi Kleen
2021-06-25 5:18 ` Greg KH
2021-06-25 5:17 ` Greg KH
2021-06-24 17:28 ` Andi Kleen
2021-06-25 5:19 ` Greg KH
2021-06-25 14:22 ` Andi Kleen
2021-06-25 14:38 ` Greg KH
2021-06-25 14:49 ` Andi Kleen
2021-06-25 15:03 ` Liang, Kan
2021-06-25 15:44 ` Andi Kleen
2021-06-25 15:57 ` Liang, Kan
2021-06-25 16:18 ` Liang, Kan [this message]
2021-06-27 11:02 ` Greg KH
2021-06-27 16:30 ` Andi Kleen
2021-06-28 6:55 ` Greg KH
2021-06-28 15:00 ` Andi Kleen
2021-06-24 1:22 ` [PATCH 3/7] perf/x86/intel/uncore: Create a symlink for an uncore PMU kan.liang
2021-06-24 5:44 ` Greg KH
2021-06-24 1:22 ` [PATCH 4/7] perf/x86/intel/uncore: Add Sapphire Rapids server support kan.liang
2021-06-24 1:22 ` [PATCH 5/7] perf/x86/intel/uncore: Factor out snr_uncore_mmio_map() kan.liang
2021-06-24 1:22 ` [PATCH 6/7] perf/x86/intel/uncore: Support free-running counters on Sapphire Rapids server kan.liang
2021-06-24 1:22 ` [PATCH 7/7] perf/x86/intel/uncore: Fix invalid unit check kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1edc6666-c4b3-ebf5-964a-e5ffc97d8563@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=greg@kroah.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox