From: Arjan van de Ven <arjan@linux.intel.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Greg KH <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Oliver Neukum <oneukum@suse.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Len Brown <len.brown@intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-pm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] PM: hibernate: allow wait_for_device_probe() to timeout when resuming from hibernation
Date: Mon, 11 Jul 2022 10:58:32 -0700 [thread overview]
Message-ID: <1eed4bc7-fe26-a302-461b-33439f96779f@linux.intel.com> (raw)
In-Reply-To: <601436f2-b13e-6c24-bcfd-29548e288f23@I-love.SAKURA.ne.jp>
On 7/11/2022 3:44 AM, Tetsuo Handa wrote:
> On 2022/07/11 17:12, Greg KH wrote:
>> creating a
>> locking loop like this should be resolved first,
>
> Rafael and Arjan, can we agree with removing wait_for_device_probe() from snapshot_open() ?
>
we can probably remove it. the "fun" is then that devices you need might not be ready once you remove it.
so if we otherwise would panic, we should at least try again after some delay...
(since a panic() is very nasty to debug for all the obvious reasons.. especially is the screen isn't on yet)
next prev parent reply other threads:[~2022-07-11 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 2:23 [PATCH v2 1/4] char: misc: allow calling open() callback without misc_mtx held Tetsuo Handa
2022-07-10 2:24 ` [PATCH v2 2/4] PM: hibernate: call wait_for_device_probe() without system_transition_mutex held Tetsuo Handa
2022-07-10 2:25 ` [PATCH v2 3/4] PM: hibernate: allow wait_for_device_probe() to timeout when resuming from hibernation Tetsuo Handa
2022-07-10 2:25 ` [PATCH v2 4/4] PM: hibernate: don't set PF_FREEZER_SKIP flag when manipulating /dev/snapshot Tetsuo Handa
2022-07-15 17:46 ` Rafael J. Wysocki
2022-07-11 8:12 ` [PATCH v2 3/4] PM: hibernate: allow wait_for_device_probe() to timeout when resuming from hibernation Greg KH
2022-07-11 10:44 ` Tetsuo Handa
2022-07-11 17:58 ` Arjan van de Ven [this message]
2022-07-11 18:14 ` Rafael J. Wysocki
2022-07-12 1:52 ` Tetsuo Handa
2022-07-14 18:48 ` Rafael J. Wysocki
2022-07-11 18:13 ` Rafael J. Wysocki
2022-07-15 17:42 ` [PATCH v2 2/4] PM: hibernate: call wait_for_device_probe() without system_transition_mutex held Rafael J. Wysocki
2022-07-22 4:24 ` Tetsuo Handa
2022-07-11 8:10 ` [PATCH v2 1/4] char: misc: allow calling open() callback without misc_mtx held Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eed4bc7-fe26-a302-461b-33439f96779f@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rjw@sisk.pl \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox