From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08FE19EEC2 for ; Fri, 2 Jan 2026 12:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358481; cv=none; b=qJiTzEHHgEFFZ4pIhBOYbLQXlR2+trwxFynN3TbSO5jCnvZPIMTMOHuoRV54/x76CkjJbVyTKtLg8m4pRXS6gy7G+x6Hj01s2+Nz0MZybopEosjnTyIhtdxxUhEBYE71yXzWprfe0179+JO8LFp33W06Mq6wCHJL+NuEuvfYjCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767358481; c=relaxed/simple; bh=UeTFQF1PziKAmdLwwjNI7yNAsyhVBMKAkEAuEqIHDaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UQRczYThaZorYVkqxxzSdP1QpWGte89z8N/F18s7lND2JYvY8DZv5CqUr/fX4ZdfmzOaSXu3CS+RGcW+E0mDPWhlOm3fL6deSyTGmAYZ+pdVSuc6JyqAGJz7Qt8ovH8JIbeKdXXQoKBMBTFs9M9AdlTOg2ZAPnG1XwIxf3qhlkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OtLFpswe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OtLFpswe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20581C116B1; Fri, 2 Jan 2026 12:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767358481; bh=UeTFQF1PziKAmdLwwjNI7yNAsyhVBMKAkEAuEqIHDaU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OtLFpswexxJuC50BSkYOlGAoAe6ToG+qgpaKowWUxBbyGmJdJxXrBfzBMduLzp1eU ZE18eOolo3cqXLU8d8ylsp4WVd+TouXva7hjW2B5HcM6cOAfy3Ogev6Z/w8hZ93EJP k4e1+P8ycLwDJhKnrAeex+kGSBo4PBSCtpBlw/qTjxUkxWaq42YPUsRpJPx+k83bkN JMo92fdntFbKpk4mfpvLXJYnYnzn5wo9rFnidc4P962f9hX13kI7HjMuZJcfObK61A pf3CuQ3upylErHfI5Vq+oCCp6H1xePcOkGcpVtR8a4GKN/MER36kgODlM0Lo6MCgfn of0y3K7D7ah2A== Message-ID: <1eef3c49-83a7-48d4-96ad-ffb71df2be7a@kernel.org> Date: Fri, 2 Jan 2026 13:54:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] soc: nxp: Add a simple NXP LPC32xx socinfo driver To: Vladimir Zapolskiy , Arnd Bergmann Cc: Piotr Wojtaszczyk , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260101235647.2411062-1-vz@mleia.com> <20260101235647.2411062-3-vz@mleia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/01/2026 13:36, Vladimir Zapolskiy wrote: > On 1/2/26 11:58, Krzysztof Kozlowski wrote: >> On 02/01/2026 00:56, Vladimir Zapolskiy wrote: >>> Add NXP LPC32xx specific driver to get unique SoC ID from System Control >>> Block registers and export it to userspace. >>> >>> Signed-off-by: Vladimir Zapolskiy >>> --- >>> drivers/soc/Kconfig | 1 + >>> drivers/soc/Makefile | 1 + >>> drivers/soc/nxp/Kconfig | 16 +++++ >>> drivers/soc/nxp/Makefile | 2 + >>> drivers/soc/nxp/lpc32xx-soc.c | 114 ++++++++++++++++++++++++++++++++++ >>> 5 files changed, 134 insertions(+) >>> create mode 100644 drivers/soc/nxp/Kconfig >>> create mode 100644 drivers/soc/nxp/Makefile >>> create mode 100644 drivers/soc/nxp/lpc32xx-soc.c >>> >>> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >>> index a2d65adffb80..c21b0d2f58fc 100644 >>> --- a/drivers/soc/Kconfig >>> +++ b/drivers/soc/Kconfig >>> @@ -18,6 +18,7 @@ source "drivers/soc/loongson/Kconfig" >>> source "drivers/soc/mediatek/Kconfig" >>> source "drivers/soc/microchip/Kconfig" >>> source "drivers/soc/nuvoton/Kconfig" >>> +source "drivers/soc/nxp/Kconfig" >>> source "drivers/soc/pxa/Kconfig" >>> source "drivers/soc/qcom/Kconfig" >>> source "drivers/soc/renesas/Kconfig" >>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile >>> index 47a3925ff84c..a04c21a8a5a4 100644 >>> --- a/drivers/soc/Makefile >>> +++ b/drivers/soc/Makefile >>> @@ -24,6 +24,7 @@ obj-y += loongson/ >>> obj-y += mediatek/ >>> obj-y += microchip/ >>> obj-y += nuvoton/ >>> +obj-y += nxp/ >>> obj-y += pxa/ >>> obj-y += qcom/ >>> obj-y += renesas/ >> >> Missing maintainers entry. >> >> >>> + >>> +static int lpc32xx_soc_probe(struct platform_device *pdev) >>> +{ >>> + struct soc_device_attribute *soc_dev_attr; >>> + struct device *dev = &pdev->dev; >>> + struct soc_device *soc_dev; >>> + struct regmap *scb; >>> + u32 serial_id[4]; >>> + int ret; >>> + >>> + soc_dev_attr = devm_kzalloc(dev, sizeof(*soc_dev_attr), GFP_KERNEL); >>> + if (!soc_dev_attr) >>> + return -ENOMEM; >>> + >>> + soc_dev_attr->family = "NXP LPC32xx"; >>> + >>> + ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine); >>> + if (ret) >>> + return ret; >>> + >>> + scb = syscon_regmap_lookup_by_compatible("nxp,lpc3220-scb"); >> >> This is undocumented ABI. > > What is the expected level of documentation for syscon? git grep nxp,lpc3220-scb gives me 0 results. Documentation is supposed to be in this patchset. If it is not, you have changelog part to explain dependencies and unusual things. > >> Anyway, you should look up devices via phandles. >> > > I may miss the context, was syscon_regmap_lookup_by_compatible() deprecated? Not deprecated. It has its own purpose, so you can explain why here you cannot have phandle. Without phandle you do not have proper device probe ordering and you do not properly express the dependency between hardware modules. Maybe this is not even real hardware, which you attach your driver to, so that's another thing to consider. Anyway, commit msg should explain all these. > > Most of drivers/soc uses syscon_regmap_lookup_by_compatible() variant over > syscon_regmap_lookup_by_phandle(), and overall They have their own reason. > > % git grep syscon_regmap_lookup_by_compatible v6.19-rc1 | wc -l > 105 > Best regards, Krzysztof