From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Peter Jones <pjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] iscsi_ibft: Fix missing break in switch statement
Date: Tue, 12 Feb 2019 12:49:54 -0600 [thread overview]
Message-ID: <1efba085-8a04-9080-df7f-091b5fa7ceda@embeddedor.com> (raw)
In-Reply-To: <20190212184636.GB19464@localhost.localdomain>
On 2/12/19 12:46 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 11, 2019 at 12:43:23PM -0600, Gustavo A. R. Silva wrote:
>> Add missing break statement in order to prevent the code from falling
>> through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.
>>
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
>
> Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git
Great.
Thanks, Konrad.
--
Gustavo
prev parent reply other threads:[~2019-02-12 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:43 [PATCH] iscsi_ibft: Fix missing break in switch statement Gustavo A. R. Silva
2019-02-12 18:46 ` Konrad Rzeszutek Wilk
2019-02-12 18:49 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efba085-8a04-9080-df7f-091b5fa7ceda@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=konrad@darnok.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox