From: Yin Fengwei <fengwei.yin@intel.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: kernel test robot <oliver.sang@intel.com>,
Yosry Ahmed <yosryahmed@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
kernel test robot <lkp@intel.com>,
Huang Ying <ying.huang@intel.com>,
Feng Tang <feng.tang@intel.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>
Subject: Re: [memcg] a8c49af3be: hackbench.throughput -13.7% regression
Date: Wed, 27 Apr 2022 13:03:58 +0800 [thread overview]
Message-ID: <1efe101a-da55-3043-c964-f23e10bcfa79@intel.com> (raw)
In-Reply-To: <CALvZod4_vNWYxzGR3BksZYgoti-9hOioMGwF2UVRnwcAGpFqXA@mail.gmail.com>
On 4/27/2022 1:02 PM, Shakeel Butt wrote:
> Hi Yin,
>
> On Tue, Apr 26, 2022 at 7:53 PM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
> [...]
>>
>> If I comment out one line added by the commit <a8c49af3be> :
>> static void memcg_account_kmem(struct mem_cgroup *memcg, int nr_pages)
>> {
>> /* mod_memcg_state(memcg, MEMCG_KMEM, nr_pages); */ <--- comment out this line.
>
> Can you to comment out the following block instead of the above line
> and see if there is any impact?
>
>> if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) {
>> if (nr_pages > 0)
>> page_counter_charge(&memcg->kmem, nr_pages);
>> else
>> page_counter_uncharge(&memcg->kmem, -nr_pages);
>> }
>> }
OK. I will give it a try and send the result out.
Regards
Yin, Fengwei
>>
next prev parent reply other threads:[~2022-04-27 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 5:58 [memcg] a8c49af3be: hackbench.throughput -13.7% regression kernel test robot
2022-04-27 2:52 ` Yin Fengwei
2022-04-27 4:34 ` Yosry Ahmed
2022-04-27 4:59 ` Yin Fengwei
2022-04-27 5:08 ` Shakeel Butt
2022-04-27 5:02 ` Shakeel Butt
2022-04-27 5:03 ` Yin Fengwei [this message]
2022-04-28 5:12 ` Yin Fengwei
2022-04-28 13:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efe101a-da55-3043-c964-f23e10bcfa79@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mhocko@kernel.org \
--cc=oliver.sang@intel.com \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox