From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B3C3BAD88 for ; Tue, 25 Aug 2026 06:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640133; cv=none; b=dGbzhz7DUbyxpUVMziDaZLQYkmTA7IP/OCL2D6MiT6hZoT+9sey/jHd59+pZCBzsklJ7IjOpQU2g964PUP9Tt35wHWW+lXTVITBP6j14vDMvQrIGLawzWfH7pRBJ+QQyhPIYB6XvI/h1qjz7M0kys3H0d4V8RCzAxLbTAmi/Bu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640133; c=relaxed/simple; bh=z/MW6hdf6AdeWAZWmO9mE/qaq7ILEGN/u9MVny8De2g=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=qjdycT6+sFCM4y2AsPgN0isnsrPavkOHF5yPW/zRS6kuG+4isNa4+8gc7LfS/lPHcUQI7IlvA/zMqNENCTuERpP67us6kqIccdIDvWymdb00lO3xsxTSTkZ4PHUypdXJLklvhjXAqrl072yNRoJnloO8lQUvrC2hH6IJNojS+/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L9vRbYpo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L9vRbYpo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0266E1F000E9; Tue, 25 Aug 2026 06:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787640132; bh=k2frwSbW5ls9FKRLoiPqylB/8nDRy7vYulFwoTe4v4E=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=L9vRbYpo8ePlcmUe1YP6Sud3q4pOfJIUnctdnDkOI20xOitUKzHU3gYS4u0HPRweX lYUFsxxcxjnwGQB7Ifqw12hSALH1BI+7PT3nKISmLehTLfIyKqqkk1O6jpskkcZD+9 m2V6TcIa6G2UDuWweii+UzlQb+eptc3NpaeAoMC48EJGtwMQ0yeUb+RSQ9jkmschZ9 flmbqQN6bnJF1+HCp6tIVXd9AAEOhAFiLXwQ4/RYz3cCYW9orpZySeK0IzyyBN3B2y U6QIvpQ+pNhkZFUvT0L/T4tW+OSTR+lg7xnHHdtbdeGbzf75fnMJmxeW1IJieIBep1 JCI0LPNF9KuIQ== Message-ID: <1f08233f-1bbc-433a-9da9-b36157e09f3a@kernel.org> Date: Tue, 25 Aug 2026 14:42:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 09/12] f2fs: cache: use compress cache To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-10-chao@kernel.org> <20260825054356.401106-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825054356.401106-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:43, Wenjie Qi wrote: > Hi Chao, > >> entry = f2fs_grab_cache(COMPRESS_CACHE(sbi), blkaddr, >> F2FS_CACHE_LOCK_CREATE); >> if (IS_ERR(entry)) >> return; >> >> entry->ino = ino; > > and inode invalidation reads: > >> if (IS_COMPRESS_CACHE(cache) && entry->ino != ino) >> continue; > > A newly created entry is inserted into the radix tree before > `f2fs_grab_cache()` acquires its entry lock and returns. Its initial `ino` is > zero, and inode invalidation reads `entry->ino` without taking that lock. Right, better to not change original logic. Thanks,