From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4DB6166F for ; Tue, 23 Jan 2024 17:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706032565; cv=none; b=pv0SEsyuQ2CsmhP5oQfIZ+qQ2nN8Dx8F4xBZfUC8IjMhida/vYYi2OAen84fewlge9XLUNpNHe4Z6d5lbwTRNHD9yO6SwpKRLEbC+QyM0ko8pS28wf+lefOPSQEsUj1nAC225aqZgbU+/0esLunH7g+8Pp66nS2V9uQJRZD0XNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706032565; c=relaxed/simple; bh=lTw2d+jEr19zQERliBwvc7vpz5HMAj1TWQn6WLETomM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e1Unk4HwNHQvWkN3wb/4PaSO2Biy4Co4++hdcrAD2ciF9uwPHByJ/7Xdg1/cvuB2OcGyZWllDz097HEN7oicVwLFFHRPizptDY9T2wabdocLqP1c9Ppae0MtRSq20CavSl+SQtxeDb1QTnTuhRWZ9Jxu2pImI6CanMWF3bYhhQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JU/tK5wa; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JU/tK5wa" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6dd7b2bc6bfso165386b3a.1 for ; Tue, 23 Jan 2024 09:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1706032563; x=1706637363; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vW1EwQtQkDL16oAi0iCe/mJ0F+Pfw76tUi9aoHvOjRw=; b=JU/tK5waHfMH8WO44+HFW1Vsar7DtylGPb1mVFd2Mmo0EGwGTUwWAKtC/83BvcSiCz lfsLhOXpIM9m92iOd73LXlaKVEe531tqPyARu2x4r2XJ9inIK5FjIt/pYEm3GCaAJheA WJJIklfn6wnTAGDa+Jq8VeRTTBV7BmkiI+xFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706032563; x=1706637363; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vW1EwQtQkDL16oAi0iCe/mJ0F+Pfw76tUi9aoHvOjRw=; b=PEcVZv1dM4YJLXBI3Pjl201Q2jyLDghbAqL0oI+KDe2hOXjhxfLeFi2wthCWNMCZXd MOP60Y4ldxk3a7lpblN34xah7UfpiCOhpsMIQn5VlYoF5GSsK+G8KQjuvnYSW8KQd2tP /RnyCAvz4dRVVMP7ZzewHiQjXepYETlEI+9sJQ5xQxS8BZSlIjw987Lv/J4DtwNOy/gd 1pZjDEbo1DacnIjykV2cnzp8MwERZo8HJANZ+OVqZfNEWvMwK1YlnsL8sWVZHv1mVz41 QI0VXBTPVV22S8DORt6JspTJKfuFbp6tg8Elv/5S292LtdFyBsstnf69TIMH9bNc5xsd qHkg== X-Gm-Message-State: AOJu0YwLYJOifl+S+786Kndb7mFpG82RQwG+1oPCoLlkmzp+4XNrg8XD NGvNdq4vq5Dda3zQfxQxZnDqfepSOeWUdbkZ1WFiY1rQS3t8ePAqGMTvJ02q3jI= X-Google-Smtp-Source: AGHT+IGS2tOvuR7n33KSMNw4mOSzqzR31U9JGY3psgHs+GV4iEzWcOcjv2KXq+2/qM/y0ShIPbl1Dg== X-Received: by 2002:a05:6a20:671b:b0:19b:7fba:7d34 with SMTP id q27-20020a056a20671b00b0019b7fba7d34mr10178109pzh.6.1706032563332; Tue, 23 Jan 2024 09:56:03 -0800 (PST) Received: from [128.240.2.100] (rbi200e.jcresorts.com. [206.170.126.10]) by smtp.gmail.com with ESMTPSA id ks11-20020a056a004b8b00b006d6b91c6eb6sm12207705pfb.13.2024.01.23.09.56.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 09:56:02 -0800 (PST) Message-ID: <1f220805-d5b8-4f84-9edd-ff3a9659eb19@linuxfoundation.org> Date: Tue, 23 Jan 2024 10:55:58 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] kselftest/seccomp: Report each expectation we assert as a KTAP test To: Mark Brown , Kees Cook , Andy Lutomirski , Will Drewry , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell , Shuah Khan References: <20240122-b4-kselftest-seccomp-benchmark-ktap-v3-0-785bff4c04fd@kernel.org> <20240122-b4-kselftest-seccomp-benchmark-ktap-v3-2-785bff4c04fd@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240122-b4-kselftest-seccomp-benchmark-ktap-v3-2-785bff4c04fd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/22/24 14:08, Mark Brown wrote: > The seccomp benchmark test makes a number of checks on the performance it > measures and logs them to the output but does so in a custom format which > none of the automated test runners understand meaning that the chances that > anyone is paying attention are slim. Let's additionally log each result in > KTAP format so that automated systems parsing the test output will see each > comparison as a test case. The original logs are left in place since they > provide the actual numbers for analysis. > > As part of this rework the flow for the main program so that when we skip > tests we still log all the tests we skip, this is because the standard KTAP > headers and footers include counts of the number of expected and run tests. > > Tested-by: Anders Roxell > Signed-off-by: Mark Brown > --- > - return 0; > + if (ret) { > + ksft_print_msg("Saw unexpected benchmark result. Try running again with more samples?\n"); > + } > + WARNING: braces {} are not necessary for single statement blocks > + ksft_finished(); > } > Mark, Can you fix this warning. Tried fixing it --fix-inplace and no luck. thanks, -- Shuah