From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF3817BB21
	for <linux-kernel@vger.kernel.org>; Tue, 25 Aug 2026 02:16:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787624162; cv=none; b=J7U1s49AUhuSrwwuEQrB1V8E0jnvgg51+dp8w8GF+PSZmjoz5yH2HkSU5MgUJx7dEa0y7mlRH854c0SpfbDLsv1S3GHISmnckpB/0PZzgES/q9hTVskbEG94ZcEOGoXL5gB4c1zggBr3JpYndvLqo9vCpVNnDHp7CVWFaXn8CyI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787624162; c=relaxed/simple;
	bh=y9iHbDk+Y4xbtzJ0IWVixPjtYiYIexRkpXUMX1DEKhk=;
	h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From:
	 In-Reply-To:Content-Type; b=LCq8SBXD7eGvYZbW/w29erBmph0fgcQogj4YPlyVu84E/xq0Z/kv/pB3LSgp4hN0q5HvkpQpuuquSfiDDn0eJel0AON5m79T0CeAIXbhk3/NapNduvHH2/BYZIhLPKyy3uKXqcZZK4OhfNNFvd0SapEbdWU5drsRgXEJXfty/mE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lDJn1EUw; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lDJn1EUw"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85CE81F000E9;
	Tue, 25 Aug 2026 02:16:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787624161;
	bh=0BWzbOU5qxkoOhUU4melE2nZy3BDaGobChMEGGofXzM=;
	h=Date:Cc:Subject:To:References:From:In-Reply-To;
	b=lDJn1EUwk7Js07/NUOz6YOrG7Qa094WRBLh4PJdaSo3SQ3W6y1BQy5DEpjXHDP2nw
	 v3OKnMoSE2M0lmNpssmy61nhTIk9eXs3xgcHyXfainGL7/ktZWiPodsG11CWg7X5n0
	 Jv9JbFqqZT41G5rP4CqrZigYtLr3wFhSTGj1Wc2KtpjuUBAMSTxZZXdlfXYSFdwHDj
	 V0wji/DVlbPp6R/M2WUS9I3GDIPr5+bDwOG/I1PrM9BnXCVZWZhusc40rOntLyaUMi
	 hT/NlvGIjFKC5rvXHtL7Q7DsEDcTrInR3ErsImV+bcKCwnpdxgSzfIST5tsPwSjHNH
	 0diFoOQlDuDug==
Message-ID: <1f2d21bc-4b06-471c-a06d-faeebf76a525@kernel.org>
Date: Tue, 25 Aug 2026 10:15:58 +0800
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: chao@kernel.org
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while
 it's unlinked
To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net
References: <20260818200121.2684318-1-jaegeuk@kernel.org>
 <aohtWfHNbUwxoQg2@google.com> <aoylp9llX9zlKm-g@google.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <aoylp9llX9zlKm-g@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8/25/26 04:12, Jaegeuk Kim via Linux-f2fs-devel wrote:
> f2fs_symlink()
> 1. f2fs_new_inode
> 2. f2fs_add_link
> 3. write_being|end to fill the symlink path
> 4. flush dirty pages and or checkpoint
> 
> Step 4 is nice to succeed, which doesn't become a reason to roll back
> the created symlink. OTOH, if we get an error till step 3, don't leave
> its dentry and its inode.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

v3 fixes generic/233 failure, looks good to me.

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,