Re: [PATCH v3 00/14] Improvements for (nested) SVM testing

Yosry Ahmed
2025-11-14T05:42:49Z

On Thu, Nov 13, 2025 at 04:46:13PM -0800, Sean Christopherson wrote:
> On Mon, 10 Nov 2025 23:26:28 +0000, Yosry Ahmed wrote:
> > This is a combined v2/v3 of the patch series in [1] and [2], with a
> > couple of extra changes.
> >
> > The series mostly includes fixups and cleanups, and more importantly new
> > tests for selective CR0 write intercepts and LBRV, which cover bugs
> > recently fixed by [3] and [4].
> >
> > [...]
>
> Applied to kvm-x86 next. In the future, please only bundle related and/or
> dependent patches, especially for one-off patches. It's a lot easier on my
> end (and likely for most maintainers and reviewers) to deal separate series.
>
> E.g. if you need to spin a new version, then you aren't spamming everyone
> with 10+ patches just to rev one patch that might not even be realted to the
> rest. And having separate series makes it easier to select exactly what I
> want to apply.

Noted. I thought that I was going to end up sending a handful of
scattered patches and it will actually end up being difficult for you to
keep track of them. To be honest, it was also easier for me :P

Anyway, will separate such changes going forward!

>
> Concretely, at a glance, this could/should be 7 different patches/series:
>
> 1, 2, 3-5 + 7 + 10-11, 6, 8, 9, 12-13, 14

3-5 + 7 + 10-11 is more-or-less what was in v1. I piled the rest on the
series :)

>
> [01/14] scripts: Always return '2' when skipping tests
> https://github.com/kvm-x86/kvm-unit-tests/commit/1825b2d46c1a
> [02/14] x86/vmx: Skip vmx_pf_exception_test_fep early if FEP is not available
> https://github.com/kvm-x86/kvm-unit-tests/commit/cab22b23b676
> [03/14] x86/svm: Cleanup selective cr0 write intercept test
> https://github.com/kvm-x86/kvm-unit-tests/commit/5f57e54c42e6
> [04/14] x86/svm: Move CR0 selective write intercept test near CR3 intercept
> https://github.com/kvm-x86/kvm-unit-tests/commit/0fa8b9beffba
> [05/14] x86/svm: Add FEP helpers for SVM tests
> https://github.com/kvm-x86/kvm-unit-tests/commit/1c5e0e1c75aa
> [06/14] x86/svm: Report unsupported SVM tests
> https://github.com/kvm-x86/kvm-unit-tests/commit/d7e64b50d0e3
> [07/14] x86/svm: Move report_svm_guest() to the top of svm_tests.c
> https://github.com/kvm-x86/kvm-unit-tests/commit/9af8f8e09dff
> [08/14] x86/svm: Print SVM test names before running tests
> https://github.com/kvm-x86/kvm-unit-tests/commit/044c33c54661
> [09/14] x86/svm: Deflake svm_tsc_scale_test
> [ DROP ]
> [10/14] x86/svm: Generalize and improve selective CR0 write intercept test
> https://github.com/kvm-x86/kvm-unit-tests/commit/cc34f04ac665
> [11/14] x86/svm: Add more selective CR0 write and LMSW test cases
> https://github.com/kvm-x86/kvm-unit-tests/commit/09e2c95edefd
> [12/14] x86/svm: Cleanup LBRV tests
> https://github.com/kvm-x86/kvm-unit-tests/commit/114a564310f6
> [13/14] x86/svm: Add more LBRV test cases
> https://github.com/kvm-x86/kvm-unit-tests/commit/ffd01c54af99
> [14/14] x86/svm: Rename VMCB fields to match KVM
> [ WAIT ]
>
> --
> https://github.com/kvm-x86/kvm-unit-tests/tree/next