From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
daniel@ffwll.ch, airlied@gmail.com, mripard@kernel.org,
tzimmermann@suse.de, maarten.lankhorst@linux.intel.com
Cc: lucas.demarchi@intel.com, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/xe: Remove unneeded semicolon
Date: Wed, 03 Jan 2024 14:11:57 +0100 [thread overview]
Message-ID: <1f5633526f6f2d39382fa638adc0e5c0b3cb61ab.camel@linux.intel.com> (raw)
In-Reply-To: <20240103011515.56529-1-yang.lee@linux.alibaba.com>
Hi, Yang,
On Wed, 2024-01-03 at 09:15 +0800, Yang Li wrote:
> ./drivers/gpu/drm/xe/xe_rtp.c:168:2-3: Unneeded semicolon
>
Could you please reformulate using imperative "Remove..." rather than
citing a style alert?
With that,
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/xe/xe_rtp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_rtp.c
> b/drivers/gpu/drm/xe/xe_rtp.c
> index fb44cc7521d8..316ed2f6d1f0 100644
> --- a/drivers/gpu/drm/xe/xe_rtp.c
> +++ b/drivers/gpu/drm/xe/xe_rtp.c
> @@ -165,7 +165,7 @@ static void rtp_get_context(struct
> xe_rtp_process_ctx *ctx,
> *gt = (*hwe)->gt;
> *xe = gt_to_xe(*gt);
> break;
> - };
> + }
> }
>
> /**
prev parent reply other threads:[~2024-01-03 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 1:15 [PATCH -next] drm/xe: Remove unneeded semicolon Yang Li
2024-01-03 13:11 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f5633526f6f2d39382fa638adc0e5c0b3cb61ab.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox