From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303AbdEENxZ (ORCPT ); Fri, 5 May 2017 09:53:25 -0400 Received: from mout.web.de ([212.227.15.14]:60928 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbdEENxW (ORCPT ); Fri, 5 May 2017 09:53:22 -0400 Subject: [PATCH 1/5] drm/sti: Reduce function calls for sequence output at five places From: SF Markus Elfring To: dri-devel@lists.freedesktop.org, Benjamin Gaignard , David Airlie , Fabien Dessenne , Vincent Abriou Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <1f5c5b0d-77c4-6efc-7906-cee76c33d2b0@users.sourceforge.net> Date: Fri, 5 May 2017 15:52:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:y0Jz04eeK26dqSD/Q6ud8rG4WYxE4MFmGP70DyoquznlEpAUOje Nh40y/x4aVVlmjAs13mqYvUh4Pht9oZARCvpy+Nzr3WpjjOw2a+wgLPe/7IxG7s3fFVJ/Jq /Ru/L4Cpof7Loxl7y6n1l0C/OrIH4Vbz4QO/0A6T4VCXRadlvMRPHS8uUJgDKC6isiI9NDb DSnXhLuselYRTq4fTdmFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WhqGDxYvUp0=:JknY5gdifFqfuNl5JzYu4K u8E7nOFnzLtJo5Kqen8YiOUU/HsOAR1iZ039WqnP2+oGy+Csgpn7SVhK8hc/2bnEUOdlQx1Gy ufXHm/HMj1Jg/fKlAEY4dULYeO0zphI4arI53YC7DSSqkWWrPDpvQgS5iRjOi8dGNDqUD5ZYY HWl9uYHzVVmHTeRsBMczJibXbeKQtbe+Wi9uW6oh4syEYE1b64sn0Rhl4Cyv0xEML6MHUE+Ex xCx/fQym/9GRWPY/BezWYTeOUIRKbCeVZNHcREg3/gCFsR7Hw+Hm8G/z48o+o7fVAHSMNw62J k0SmHyM2KvDI96EU3dy2FLUjso6dVcnNYFxNgJD7Cpuqzb1BzrDgCZzmYAZnrJSlfCEI5Ya8y hQVlII6zmW5pmh6mfVVsHFJI/I1E6u5yiIMRQP8cRzbp7hx6N+9lw/bR+6ZK7/Ksk+h+yMI9x bmQ382tIlSGvWuPIdojBOc4JfRb0f8kgJzzMqpbPAFpIe2LSYQI34+E5DgeYcNI4FvYaUWle/ /2gebHJ6LArDh03SXTUBbwH+O4Z4gu3aXclQmABqWTrHbaOHIIFFLGb99JHPCpibdIM7nJjD0 NLdm9wBTHSaKDsbAGL7uLcxfj6XWEjDchRJIueG3mdV6DHCQjExaPUe+gUTcYR77CP3xN7Lsv AseLg7m5m3ukpaA4vHIN8JyA22Z6psNy2GJOMRn9kgH46DwZ7LgoBnswqcdqXdCI9TYP1iez6 LAmQxjL73pYG2ReI1Ga72kmilZ3FhtVIw6/DlrNkpfRXMQ/v2LO/953P+S7C8LNwsqkS+MUg4 Vd1J8c+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 14:54:52 +0200 Some data were put into a sequence by separate function calls. Print the same data by five single function calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/sti/sti_gdp.c | 3 +-- drivers/gpu/drm/sti/sti_hda.c | 6 ++---- drivers/gpu/drm/sti/sti_hdmi.c | 6 ++---- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c index 88f16cdf6a4b..3caced5f2e86 100644 --- a/drivers/gpu/drm/sti/sti_gdp.c +++ b/drivers/gpu/drm/sti/sti_gdp.c @@ -266,8 +266,7 @@ static void gdp_node_dump_node(struct seq_file *s, struct sti_gdp_node *node) seq_printf(s, "\n\tKEY2 0x%08X", node->gam_gdp_key2); seq_printf(s, "\n\tPPT 0x%08X", node->gam_gdp_ppt); gdp_dbg_ppt(s, node->gam_gdp_ppt); - seq_printf(s, "\n\tCML 0x%08X", node->gam_gdp_cml); - seq_puts(s, "\n"); + seq_printf(s, "\n\tCML 0x%08X\n", node->gam_gdp_cml); } static int gdp_node_dbg_show(struct seq_file *s, void *arg) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 0c0a75bc8bc3..e3475a17eaeb 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -320,8 +320,7 @@ static void hda_dbg_awg_microcode(struct seq_file *s, void __iomem *reg) { unsigned int i; - seq_puts(s, "\n\n"); - seq_puts(s, " HDA AWG microcode:"); + seq_puts(s, "\n\n HDA AWG microcode:"); for (i = 0; i < AWG_MAX_INST; i++) { if (i % 8 == 0) seq_printf(s, "\n %04X:", i); @@ -333,8 +332,7 @@ static void hda_dbg_video_dacs_ctrl(struct seq_file *s, void __iomem *reg) { u32 val = readl(reg); - seq_puts(s, "\n"); - seq_printf(s, "\n %-25s 0x%08X", "VIDEO_DACS_CONTROL", val); + seq_printf(s, "\n\n %-25s 0x%08X", "VIDEO_DACS_CONTROL", val); seq_puts(s, "\tHD DACs "); seq_puts(s, val & DAC_CFG_HD_HZUVW_OFF_MASK ? "disabled" : "enabled"); } diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 243905b6ae59..52cdff651c0d 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -692,8 +692,7 @@ static int hdmi_dbg_show(struct seq_file *s, void *data) DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AVI); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AVI); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AVI); - seq_puts(s, "\n"); - seq_printf(s, "\n AUDIO Infoframe (Data Island slot N=%d):", + seq_printf(s, "\n\n AUDIO Infoframe (Data Island slot N=%d):", HDMI_IFRAME_SLOT_AUDIO); DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_AUDIO); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_AUDIO); @@ -703,8 +702,7 @@ static int hdmi_dbg_show(struct seq_file *s, void *data) DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AUDIO); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AUDIO); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AUDIO); - seq_puts(s, "\n"); - seq_printf(s, "\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):", + seq_printf(s, "\n\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):", HDMI_IFRAME_SLOT_VENDOR); DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_VENDOR); DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_VENDOR); -- 2.12.2