From: Dan Carpenter <dan.carpenter@linaro.org>
To: Matteo Martelli <matteomartelli3@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] iio: adc: pac1921: add missing error return in probe()
Date: Thu, 8 Aug 2024 22:28:17 +0300 [thread overview]
Message-ID: <1fa4ab12-0939-477d-bc92-306fd32e4fd9@stanley.mountain> (raw)
This error path was intended to return, and not just print an error. The
current code will lead to an error pointer dereference.
Fixes: 371f778b83cd ("iio: adc: add support for pac1921")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/iio/adc/pac1921.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
index d04c6685d780..8200a47bdf21 100644
--- a/drivers/iio/adc/pac1921.c
+++ b/drivers/iio/adc/pac1921.c
@@ -1168,8 +1168,8 @@ static int pac1921_probe(struct i2c_client *client)
priv->regmap = devm_regmap_init_i2c(client, &pac1921_regmap_config);
if (IS_ERR(priv->regmap))
- dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
- "Cannot initialize register map\n");
+ return dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
+ "Cannot initialize register map\n");
devm_mutex_init(dev, &priv->lock);
--
2.43.0
next reply other threads:[~2024-08-08 19:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 19:28 Dan Carpenter [this message]
2024-08-09 6:18 ` [PATCH] iio: adc: pac1921: add missing error return in probe() Christophe JAILLET
2024-08-09 7:31 ` Matteo Martelli
2024-08-09 8:41 ` Christophe JAILLET
2024-08-09 15:51 ` Matteo Martelli
2024-08-09 17:04 ` Matteo Martelli
2024-08-09 17:27 ` Dan Carpenter
2024-08-09 15:18 ` Dan Carpenter
2024-08-10 10:35 ` Jonathan Cameron
2024-09-11 9:32 ` Matteo Martelli
2024-09-13 19:39 ` Jonathan Cameron
2024-08-09 7:19 ` Matteo Martelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fa4ab12-0939-477d-bc92-306fd32e4fd9@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteomartelli3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox