From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E15230B514 for ; Thu, 23 Oct 2025 11:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761217417; cv=none; b=loGeu7LsFE5txGDsDi81+kAwnGgkiUG481MSQPSeFui3euayTqFfmRwv83AvPj5c4vuizj0KbSXklvHAmkW9tWrlgcyTAZ1so1SpaXO5DYW5FyyKlDNNUMLicGQdcdT4ruEwYp8bfYzoS5G5WuTU20+qIoyHNBfoDQUe5+XFU3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761217417; c=relaxed/simple; bh=2/gABdtSagvvRvXcgYkvrUxlpN85FD7cuZAxp8ojVKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bEGJKsTXLCKiVSbini8xxqDgOOiXdxoVSkMuwNebh14aJmzmMHnVnEgXt4J2o02r7iQDoQ9oVBsKSp8gVaIV07ScXlokuhvgZVBZZsBRubfUs3VAjfLNhA6mC6JS/AB6xA67G60af4TsTCeB1atenRIL3yOEA9PiJQ0GTu8tBsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hIiRUlId; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hIiRUlId" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761217415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IffLhB/dtgzsB8Rx7XpZkACOwzSFp8CqfXzEdzYdCTE=; b=hIiRUlIdxT6zC8UC+G0bRntzMC2tGcX+rcAMEgKhlTSN2ykp4frJeTIZBkVOWYjvjVD7Sq d7a2tuaBkrvmmGxlxMCezYQDne2KJ13NqIh2Cpem0H6d5IlBDejJeRcRzeros/hUshvW7o 60G1N5sG5qaovRyilCDeVbXHPYWhz10= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-JxMmlIizNkWm0dc3fF_VOg-1; Thu, 23 Oct 2025 07:03:33 -0400 X-MC-Unique: JxMmlIizNkWm0dc3fF_VOg-1 X-Mimecast-MFC-AGG-ID: JxMmlIizNkWm0dc3fF_VOg_1761217413 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4711899ab0aso4766645e9.2 for ; Thu, 23 Oct 2025 04:03:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761217412; x=1761822212; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IffLhB/dtgzsB8Rx7XpZkACOwzSFp8CqfXzEdzYdCTE=; b=LLI11AsJM6aDEfUdIOJM3UQtflZ7+t58bQ0mOIrQGKzQ3wqzqpoi/BmINUsEcdLX9m iaHFeAg63bv5PUmUxVoDG7wmB6BpZ7yWI6ICJ5lNBcdM+GjK3poMb0FS0zyg9D/QOELt snxoX0DGDSQBCNmpmoddEbx9ngPhr/ZEkWRaiC8ErNDxs8deZloloh2swzzegWZ9IPTh 2aUiclF0LdIs5dzpka517DtWgyh9Dv6x56AU/o3ombzvRYfZ291+Qfag3jB+gnMZsoA6 WFXzn66Uc630OVKy6CDm+BqcGakMXhHB+5foseBl/K/j5q9A901t41zeMLyA44TZgxXh jlHg== X-Forwarded-Encrypted: i=1; AJvYcCVUzn23hYm8RU+f/UK4LgAh8AhkF1sxIvDPGpjbEAd7RQn56m0X1F3BTCIusqpxbMkPgQk8Kg5bCOF0XZU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8t8/LNMnKKlSzsYYCIJJ1xAxeSXPxKlEXwsnzIQ4y0URnCNxB ExYhEMFcGkRxbRnvYiDRcNk49hdQiIqS+S+1Op2iTWs3rCiWUFUhSUUtzONMAyZjBQMD4q4Krl/ +pVPwfYlxow1GHXYkeynVNLSTPTLlAbeTO9LSw2Q8kYSk2Ti7OxY34t4lK8Y0bSr1wQ== X-Gm-Gg: ASbGncuYbHHiStLUt9oNnEjYb4J55JBzW770USyjNt88tfevT9KGBmYuXBhCKyqM0JF xViWWLyIOlcxfoo1Wogj/h9ZgCi4MXuU+4R+gRtErd7bqunJjm1buKlYeNK4qa7b/ywscSVL4W3 ct9BkwYY7yOqTPJLcct+yerkbugQezMC/FXV0ldwel52Yl5MaQb3V5iEVODpM1mraYbPbrrQtUo HnhGuXX1XVWt9U1mSUmOrq8kRkwsiWASCnW5TQPwYEuIi/0zMGzhE1yNrMlGAeFxyeagagpfmdH oTAJ8dvpFlrekdRqWLjeu0GkDAGPO1Lf8OKLpCVfGt/9nV6Hs9+sGQ9m8rE6FSuZ3fdVxFP6OF7 Hs7MkPDESyRJamopf9hyqdZP21WjMZGw9kA05UzRkciC0M8s= X-Received: by 2002:a05:600c:64cf:b0:46e:3dcb:35b0 with SMTP id 5b1f17b1804b1-4711786d332mr203648575e9.2.1761217412548; Thu, 23 Oct 2025 04:03:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcmAKT0d5E/+UDMPzD2Uu8sJN+s2YwSJhnRUKFlKICL+VtTqA3NDebN0QlDpDV/hBH/3a+iA== X-Received: by 2002:a05:600c:64cf:b0:46e:3dcb:35b0 with SMTP id 5b1f17b1804b1-4711786d332mr203648285e9.2.1761217412134; Thu, 23 Oct 2025 04:03:32 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898ccc60sm3389854f8f.34.2025.10.23.04.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 04:03:31 -0700 (PDT) Message-ID: <1fb1a9dc-e4c0-40a0-9536-82653b5d0598@redhat.com> Date: Thu, 23 Oct 2025 13:03:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map_page To: Chu Guangqing , jes@trained-monkey.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.xn--org-o16s Cc: linux-acenic@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251021020939.1121-1-chuguangqing@inspur.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251021020939.1121-1-chuguangqing@inspur.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/21/25 4:09 AM, Chu Guangqing wrote: > @@ -2362,9 +2359,8 @@ ace_map_tx_skb(struct ace_private *ap, struct sk_buff *skb, > dma_addr_t mapping; > struct tx_ring_info *info; > > - mapping = dma_map_page(&ap->pdev->dev, virt_to_page(skb->data), > - offset_in_page(skb->data), skb->len, > - DMA_TO_DEVICE); > + mapping = dma_map_phys(&ap->pdev->dev, skb->data, > + skb->len, DMA_TO_DEVICE, 0); It looks like here a virt_to_phys() is missing around skb->data. /P