From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdFNQXC (ORCPT ); Wed, 14 Jun 2017 12:23:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:54913 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750735AbdFNQXB (ORCPT ); Wed, 14 Jun 2017 12:23:01 -0400 Subject: Re: [RFC PATCH 4/4] mm, hugetlb, soft_offline: use new_page_nodemask for soft offline migration To: Michal Hocko , linux-mm@kvack.org Cc: Naoya Horiguchi , Mike Kravetz , Mel Gorman , Andrew Morton , LKML , Michal Hocko References: <20170613090039.14393-1-mhocko@kernel.org> <20170613090039.14393-5-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <1fdaa94e-33a7-f280-d682-1ffb0b8547db@suse.cz> Date: Wed, 14 Jun 2017 18:22:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170613090039.14393-5-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2017 11:00 AM, Michal Hocko wrote: > From: Michal Hocko > > new_page is yet another duplication of the migration callback which has > to handle hugetlb migration specially. We can safely use the generic > new_page_nodemask for the same purpose. > > Please note that gigantic hugetlb pages do not need any special handling > because alloc_huge_page_nodemask will make sure to check pages in all > per node pools. The reason this was done previously was that > alloc_huge_page_node treated NO_NUMA_NODE and a specific node > differently and so alloc_huge_page_node(nid) would check on this > specific node. > > Noticed-by: Vlastimil Babka > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka > --- > mm/memory-failure.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 3615bffbd269..7040f60ecb71 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1487,16 +1487,8 @@ EXPORT_SYMBOL(unpoison_memory); > static struct page *new_page(struct page *p, unsigned long private, int **x) > { > int nid = page_to_nid(p); > - if (PageHuge(p)) { > - struct hstate *hstate = page_hstate(compound_head(p)); > > - if (hstate_is_gigantic(hstate)) > - return alloc_huge_page_node(hstate, NUMA_NO_NODE); > - > - return alloc_huge_page_node(hstate, nid); > - } else { > - return __alloc_pages_node(nid, GFP_HIGHUSER_MOVABLE, 0); > - } > + return new_page_nodemask(p, nid, &node_states[N_MEMORY]); > } > > /* >