From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A49C433EF for ; Thu, 24 Feb 2022 20:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233546AbiBXUPs (ORCPT ); Thu, 24 Feb 2022 15:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbiBXUPq (ORCPT ); Thu, 24 Feb 2022 15:15:46 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDE14278CA0; Thu, 24 Feb 2022 12:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645733715; x=1677269715; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=6B/f+27LYRUPDQxWW8vRZGhcXmfz2Oq/sefZhYbxRaM=; b=TWzMdUsXSnu9E2/SNzuThiiPF6sS3a23cVmL8KA/IjpgRmNYWIFoY0ls 5cr5vkXKQkSD9qq8sjy4mVAcYil4JqJVvQCNFCo2uc9VUbTB8bpq0lmYs 7ng792Z0WAyAhZ8PlWwBzsUxn3TUMjbIcEn612fhaPf9sjPo9jiRYjSfv +SfwatcMWBjufucMornigNNYDO1KYac8glphhu9/u05jmDi7fO03JJDgX Ut8q7VwDTMla9DV98Jdn5ikNltez05g9+ptCKmy2irxGoCNmmP9oGJOxj AeBC2bxjzT2M2nw2Wj41HoTNDLPU21ilmTV7iMQSAfHyMIoCG5DF+drZb A==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252260480" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="252260480" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 12:15:15 -0800 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="787984782" Received: from rjfenger-mobl.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.209.48.94]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 12:15:14 -0800 Message-ID: <1fe034be43340d413f13adea219f25917dcebdf7.camel@linux.intel.com> Subject: Re: [PATCH] thermal: int340x: fix memory leak in int3400_notify() From: srinivas pandruvada To: "Rafael J. Wysocki" , Chuansheng Liu Cc: Linux Kernel Mailing List , Linux PM Date: Thu, 24 Feb 2022 12:15:14 -0800 In-Reply-To: References: <20220223002024.55026-1-chuansheng.liu@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-02-24 at 20:16 +0100, Rafael J. Wysocki wrote: > On Wed, Feb 23, 2022 at 1:33 AM Chuansheng Liu > wrote: > > > > It is easy to hit the below memory leaks in my TigerLake platform: > > > > -- > > unreferenced object 0xffff927c8b91dbc0 (size 32): > >   comm "kworker/0:2", pid 112, jiffies 4294893323 (age 83.604s) > >   hex dump (first 32 bytes): > >     4e 41 4d 45 3d 49 4e 54 33 34 30 30 20 54 68 65  NAME=INT3400 > > The > >     72 6d 61 6c 00 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  > > rmal.kkkkkkkkkk. > >   backtrace: > >     [] __kmalloc_track_caller+0x2fe/0x4a0 > >     [] kvasprintf+0x65/0xd0 > >     [] kasprintf+0x4e/0x70 > >     [] int3400_notify+0x82/0x120 > > [int3400_thermal] > >     [] acpi_ev_notify_dispatch+0x54/0x71 > >     [] acpi_os_execute_deferred+0x17/0x30 > >     [] process_one_work+0x21a/0x3f0 > >     [] worker_thread+0x4a/0x3b0 > >     [] kthread+0xfd/0x130 > >     [] ret_from_fork+0x1f/0x30 > > --- > > > > Fix it by calling kfree() accordingly. > > > > Fixes: 38e44da59130 ("thermal: int3400_thermal: process "thermal > > table > > changed" event") > > > > Cc: linux-pm@vger.kernel.org > > Cc: stable@vger.kernel.org > > Cc: rafael@kernel.org > > Cc: srinivas.pandruvada@linux.intel.com > > Signed-off-by: Chuansheng Liu > > Applied as a fix for 5.17-rc, thanks! > > Srinivas, any concerns? None. Thanks, Srinivas > > > --- > >  drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 4 ++++ > >  1 file changed, 4 insertions(+) > > > > diff --git > > a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > index 72acb1f61849..4f478812cb51 100644 > > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > > @@ -404,6 +404,10 @@ static void int3400_notify(acpi_handle handle, > >         thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", > > therm_event); > >         thermal_prop[4] = NULL; > >         kobject_uevent_env(&priv->thermal->device.kobj, > > KOBJ_CHANGE, thermal_prop); > > +       kfree(thermal_prop[0]); > > +       kfree(thermal_prop[1]); > > +       kfree(thermal_prop[2]); > > +       kfree(thermal_prop[3]); > >  } > > > >  static int int3400_thermal_get_temp(struct thermal_zone_device > > *thermal, > > -- > > 2.25.0.rc2 > >