From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B891F201113 for ; Sun, 3 May 2026 03:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777779765; cv=none; b=G/Z98r+OSU10ZYVboNkSWOrSfUbaoGCZhhkEA5lv0e7jsUyFElHwfA71d7SzW5SlTTneyFgpGVu2K5+Igq/PqWXLYMohXh8+Rx5RbvnOT5cEdVSjv8ql2mzcuKVVYrGo0ZLMivfsYriy47oI7V1UZyu6M4LZ8KOUL5nzw2yxXjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777779765; c=relaxed/simple; bh=tjG1kTWygatN70wVlmDcJrkF7ZiwlCkEtZ14WpNp9YM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b8/RWmD2SZFW6TY0XwYxIraNOfpzBPrRQD0TwfR3NEZdy9A9iCHADgqHhH4hboQzIcqmY/qT2rQRvUe6q/lNpKAVYb+yUA9Idp3/HfqhsMkRHo1gwQdGAUp1dlM33emzcuVunbjxBS9VC7HOdKmbQYp7Bf2ZRVrza0q4LXE0czg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bogIRTBj; arc=none smtp.client-ip=209.85.222.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bogIRTBj" Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-94ac8cbf3feso2063459241.0 for ; Sat, 02 May 2026 20:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777779763; x=1778384563; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=PiiXKGJux6g44aioDbCLD/YNgU+NyVlVqd4RaEM0CyY=; b=bogIRTBj2NYB1Wx+NISe61rixqiMmilhr6CMCY7MKJG9isjO5Seco0qVA/yOZsaVcG 5pOsfzym9wWCYc+pUCe6ybYbOqDaw5zC0prMnbavrZN7dY+N7ngFWBC2pIh3QZYnKi1A MXRpArxUJogCawuyP3oz0W1TlDavMuTk+pzBS71GlcJV/OQ/DfIqTQmnc+REdEkj0Z23 ypD37ohPkyq6mpAQIl6Oci4+/yiHktxJXiKQTsRzk7G4WARSfY3POLfuEX+YzMzRsQVn YCRXv2utqrytLSwHwSQ5lGMMCAVityzCZ7CO7b2wBaQGFvkVWyXqQ0wCLDnkKySuwXAh +ZmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777779763; x=1778384563; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PiiXKGJux6g44aioDbCLD/YNgU+NyVlVqd4RaEM0CyY=; b=q3V/0JDXv3GHiA7ou+/xUoLx50qlMaQzsKHEgq3IjyX4ypqk0HWcDYMOYuUfsWwPXB VF2jthR4/G+ZkJqZCx1vUYQ/MNjIJr1Xlp/FlIUBOjtWgOVBw4AqwmMeZX4eWNb5NoiK f6fxUTLdAZ0+CA0PdQgf+XlZiMHsgQmVjoau7jQAuVU88XCDkOV2iRpz4dKxtVdCyP9O lHXy+yq0rNWCrMqN0ApLE3Y/Ms2GDXy+jaC18Wzu7fNZXe6W/wsUbNygWxwfwbjxaiLA KilLLYTsENf7qKypotXsxk/M0WaVdmhShdzHNKYPqsRGSIBKxGvrTTEGLxNb878NPMWG M5rg== X-Forwarded-Encrypted: i=1; AFNElJ9R+PGPvbRC14PW729jnTOaA/CBY5iGsxaIj4XuI4GrL7acnC6Q30ufG0QC6fBfwRbZVqGjqqnNI0NuoPE=@vger.kernel.org X-Gm-Message-State: AOJu0YxutxW5F3fFAcsh5BQAaZD3Ih90S5S9hXu3Z0ESk6CTqxvTEHOU 24j5bfQUUgUdl0GOm3O1LOW6RMRrAFdUvZI8Yb8DNbbU9ZIt1J2/md8U X-Gm-Gg: AeBDiesMHzbUvV5Al7cRfHTI6376d1+BqhWR/W0BQYzyixVVZM8jLZjKGXaokEIsWGn 8rHzV6f9puj6bHLlD5lgc9sXz7Y6GLIROgaEWGSrnG1Sn0jt0yHyHTl77FuJdv2BU/EXSY29Cki 1lYe3e/+XvxZg193UcPWljU/wO027Ct/7uLlnZD4BTlSoanmUbtz/O4nfMMyl3B/2MoJZ9HsPNR GahT5zS1wuBGxzhyUAFyuq7jNYK15pqNBDj2CRNRTi/QkBgUVkP6MegT4/YZMGHfIBZFkpUOVyC pA6lMT4G5WmHM6zrPf5feEUieK9fSGYXOrq2yWMU9O3Qp7I14Cj6KlXW/OPfr16dVh8FFhlk+0H YdUhIL+4VFfUmlN4fHk/1nucgz9Xeq+sza/atDQ8Kv5nShdzSj4yEVQqKlFybeAdtoFlvNaVlug Yr5oBGpjbwpK7UCmOTVcveQYbaJ+17LQFr96XYd6SHiiw= X-Received: by 2002:a05:6102:4b0c:b0:604:f29d:84be with SMTP id ada2fe7eead31-62d84a67460mr2488161137.3.1777779762631; Sat, 02 May 2026 20:42:42 -0700 (PDT) Received: from [172.27.209.232] ([129.222.53.215]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95ce0af57f6sm3669350241.8.2026.05.02.20.42.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 May 2026 20:42:41 -0700 (PDT) Sender: Julian Braha Message-ID: <1fe6bcb7-b5c0-454f-ad54-5014006edab5@gmail.com> Date: Sun, 3 May 2026 04:42:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support To: Alex Elder , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-10-elder@riscstar.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260501155421.3329862-10-elder@riscstar.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/1/26 16:54, Alex Elder wrote: > +config GPIO_TC956X > + tristate "Toshiba TC956X GPIO support" > + depends on TOSHIBA_TC956X_PCI > + default m if TOSHIBA_TC956X_PCI Hi Alex, In your Kconfig changes, this condition 'if TOSHIBA_TC956X_PCI' is dead code. Since you have the dependency on TOSHIBA_TC956X_PCI, you can just make the 'default m' unconditional - assuming this is what you intended. Perhaps you would prefer to use 'default TOSHIBA_TC956X_PCI', which would have GPIO_TC956X default to 'm' or 'y' when TOSHIBA_TC956X_PCI is 'm' or 'y', respectively. - Julian Braha