Re: [PATCH] VMware balloon: force compiling as a module

[Alexander Clouter <alex@digriz.org.uk>]

Dmitry Torokhov <dtor@vmware.com> wrote:
>
>> > Now we have 2 drivers fighting. There is no backing device and so driver
>> > core will not save us by refusing to bind to already claimed device.
>> 
>> If vmware_balloon is present in /sys/modules or is loaded, don't load
>> vmmemctl.  And vice versa.
>> 
>> I dunno - it's silly for me to sit here proposing solutions.  it's
>> better that you do it!
> 
> Unfortunately I do not have a good solution at the moment. I guess we'll
> have to work with distributions to make sure they keep it as a module
> (it also makes most sense for them since not everyone runs on our
> platform).
> 
I cannot seriously believe you are considering a viable solution is 
"everyone[1] must abide by these rules otherwise our installer might 
barf".  The only benefactor of this patch is your installer and the 
effect is an undocumented and peculiar constraint on a kernel module.

Seriously, add sometime so that you get something in /sys/modules (maybe 
it's time for something in /sys/class?) or maybe do something so that 
you have: VMWARE_BALLOON_CMD(STATUS, ...) where the guest can say if 
there is already something ballooning for it.  Surely the guest should 
be aware if there is more than one balloon driver at play?

I think a friend of mine summed it up rather well: "Fixing the kernel 
instead of fixing the VMWare installer is an inspired move".

Cheers

[1] the dropdown menu on distrowatch lists 319 distrubutions

-- 
Alexander Clouter
.sigmonster says: May the bluebird of happiness twiddle your bits.